Iterator::getIterator() - Code Metrics - Inspection of "refactor: prevent repeating entity hydration in Mt..." - cycle/orm - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#188)

unknown

created 2021-06-07 12:13 UTC

Iterator::getIterator() A

↳ Parent: Iterator

Complexity

Conditions	3
Paths	3

Size

Total Lines	13
Code Lines	6

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
cc	3
eloc	6
nc	3
nop	0
dl	0
loc	13
rs	10
c	0
b	0
f	0

<?php

/**
 * Cycle DataMapper ORM
 *
 * @license   MIT
 * @author    Anton Titov (Wolfy-J)
 */

declare(strict_types=1);

namespace Cycle\ORM;

use Cycle\ORM\Heap\Node;

/**
 * Iterates over given data-set and instantiates objects.
 */
final class Iterator implements \IteratorAggregate
{
    /** @var ORMInterface */
    private $orm;

    /** @var string */
    private $role;

    /** @var iterable */
    private $source;

    /** @var bool */
    private $tryToFindInHeap;

    /**
     * @param ORMInterface $orm
     * @param string $class
     * @param iterable $source
     * @param bool $tryToFindInHeap
     */
    public function __construct(ORMInterface $orm, string $class, iterable $source, bool $tryToFindInHeap = false)
    {
        $this->orm = $orm;
        $this->role = $this->orm->resolveRole($class);
        $this->source = $source;
        $this->tryToFindInHeap = $tryToFindInHeap;
    }

    /**
     * Generate entities using incoming data stream. Pivoted data would be
     * returned as key value if set.
     *
     * @return \Generator
     */
    public function getIterator(): \Generator
    {
        foreach ($this->source as $index => $data) {
            // through-like relations
            if (isset($data['@'])) {
                $index = $data;
                unset($index['@']);
                $data = $data['@'];
            }

            // add pipeline filter support?

            yield $index => $this->getEntity($data);
        }
    }

    private function getEntity(array $data)
    {
        if ($this->tryToFindInHeap) {
            $pk = $this->orm->getSchema()->define($this->role, SchemaInterface::PRIMARY_KEY);
            $id = $data[$pk] ?? null;

            if (null !== $id) {
                $e = $this->orm->getHeap()->find($this->role, [
                    $pk => $id,
                ]);
            }
        }

        return $e ?? $this->orm->make($this->role, $data, Node::MANAGED);
    }
}


1			<?php
2
3			/**
4			* Cycle DataMapper ORM
5			*
6			* @license MIT
7			* @author Anton Titov (Wolfy-J)
8			*/
9
10			declare(strict_types=1);
11
12			namespace Cycle\ORM;
13
14			use Cycle\ORM\Heap\Node;
15
16			/**
17			* Iterates over given data-set and instantiates objects.
18			*/
19			final class Iterator implements \IteratorAggregate
20			{
21			/** @var ORMInterface */
22			private $orm;
23
24			/** @var string */
25			private $role;
26
27			/** @var iterable */
28			private $source;
29
30			/** @var bool */
31			private $tryToFindInHeap;
32
33			/**
34			* @param ORMInterface $orm
35			* @param string $class
36			* @param iterable $source
37			* @param bool $tryToFindInHeap
38			*/
39			public function __construct(ORMInterface $orm, string $class, iterable $source, bool $tryToFindInHeap = false)
40			{
41			$this->orm = $orm;
42			$this->role = $this->orm->resolveRole($class);
43			$this->source = $source;
44			$this->tryToFindInHeap = $tryToFindInHeap;
45			}
46
47			/**
48			* Generate entities using incoming data stream. Pivoted data would be
49			* returned as key value if set.
50			*
51			* @return \Generator
52			*/
53			public function getIterator(): \Generator
54			{
55			foreach ($this->source as $index => $data) {
56			// through-like relations
57			if (isset($data['@'])) {
58			$index = $data;
59			unset($index['@']);
60			$data = $data['@'];
61			}
62
63			// add pipeline filter support?
64
65			yield $index => $this->getEntity($data);
66			}
67			}
68
69			private function getEntity(array $data)
70			{
71			if ($this->tryToFindInHeap) {
72			$pk = $this->orm->getSchema()->define($this->role, SchemaInterface::PRIMARY_KEY);
73			$id = $data[$pk] ?? null;
74
75			if (null !== $id) {
76			$e = $this->orm->getHeap()->find($this->role, [
77			$pk => $id,
78			]);
79			}
80			}
81
82			return $e ?? $this->orm->make($this->role, $data, Node::MANAGED);
83			}
84			}
85

cycle / orm

Pull Request — master (#188)

Iterator::getIterator() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like