cycle / orm

src/Parser/SingularNode.php

<?php
/**
 * Spiral, Core Components
 *
 * @author Wolfy-J
 */
declare(strict_types=1);

namespace Cycle\ORM\Parser;

use Cycle\ORM\Exception\ParserException;

/**
 * Node with ability to push it's data into referenced tree location.
 */
final class SingularNode extends AbstractNode
{
    /** @var string */
    protected $innerKey;

    /**
     * @param array       $columns
     * @param string      $primaryKey
     * @param string      $innerKey Inner relation key (for example user_id)
     * @param string|null $outerKey Outer (parent) relation key (for example id = parent.id)
     */
    public function __construct(array $columns, string $primaryKey, string $innerKey, string $outerKey)
    {
        parent::__construct($columns, $outerKey);
        $this->setDuplicateCriteria($primaryKey);

        $this->innerKey = $innerKey;
    }

    /**
     * {@inheritdoc}
     */
    protected function push(array &$data)
    {
        if (empty($this->parent)) {
            throw new ParserException("Unable to register data tree, parent is missing");
        }

        if (is_null($data[$this->innerKey])) {
            //No data was loaded
            return;
        }

        $this->parent->mount(
            $this->container,
            $this->outerKey,

It seems like $this->outerKey can also be of type null; however, parameter $key of Cycle\ORM\Parser\AbstractNode::mount() does only seem to accept string, maybe add an additional type check?

            $data[$this->innerKey],
            $data
        );
    }
}