cycle / orm

src/Command/Database/Delete.php

<?php

/**
 * Cycle DataMapper ORM
 *
 * @license   MIT
 * @author    Anton Titov (Wolfy-J)
 */

declare(strict_types=1);

namespace Cycle\ORM\Command\Database;

use Cycle\ORM\Command\DatabaseCommand;
use Cycle\ORM\Command\ScopeCarrierInterface;
use Cycle\ORM\Command\Traits\ErrorTrait;
use Cycle\ORM\Command\Traits\ScopeTrait;
use Cycle\ORM\Exception\CommandException;
use Spiral\Database\DatabaseInterface;

final class Delete extends DatabaseCommand implements ScopeCarrierInterface
{
    use ScopeTrait;
    use ErrorTrait;

The trait Cycle\ORM\Command\Traits\ErrorTrait requires the property $waitContext which is not provided by Cycle\ORM\Command\Database\Delete.

    /**
     * @param DatabaseInterface $db
     * @param string            $table
     * @param array             $where
     */
    public function __construct(DatabaseInterface $db, string $table, array $where = [])
    {
        parent::__construct($db, $table);
        $this->scope = $where;
    }

    /**
     * @inheritdoc
     */
    public function isReady(): bool
    {
        return $this->waitScope === [];
    }

    /**
     * Inserting data into associated table.
     */
    public function execute(): void
    {
        if ($this->scope === []) {
            throw new CommandException('Unable to execute delete command without a scope');
        }

        $this->db->delete($this->table, $this->scope)->run();

It seems like $this->table can also be of type null; however, parameter $table of Spiral\Database\DatabaseInterface::delete() does only seem to accept string, maybe add an additional type check?

        parent::execute();
    }

    /**
     * @inheritdoc
     */
    public function register(
        string $key,
        $value,
        bool $fresh = false,
        int $stream = self::DATA
    ): void {
        if ($fresh || $value !== null) {
            $this->freeScope($key);
        }

        $this->setScope($key, $value);
    }
}