Cycle\ORM\Promise\Collection\CollectionPromise

Complexity

Total Complexity

4

Size/Duplication

Total Lines	37
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	3	1
A	doInitialize()	0	3	1
A	getPromise()	0	3	1
A	matching()	0	5	1

<?php

/**
 * Cycle DataMapper ORM
 *
 * @license   MIT
 * @author    Anton Titov (Wolfy-J)
 */

declare(strict_types=1);

namespace Cycle\ORM\Promise\Collection;

use Cycle\ORM\Promise\PromiseInterface;
use Doctrine\Common\Collections\AbstractLazyCollection;
use Doctrine\Common\Collections\ArrayCollection;
use Doctrine\Common\Collections\Criteria;
use Doctrine\Common\Collections\Selectable;

/**
 * LazyLoading collection build at top of data promise.
 */
class CollectionPromise extends AbstractLazyCollection implements CollectionPromiseInterface, Selectable
{
    /** @var PromiseInterface */
    protected $promise;

    /**
     * @param PromiseInterface $promise
     */
    public function __construct(PromiseInterface $promise)
    {
        $this->promise = $promise;
    }

    /**
     * @inheritdoc
     */
    public function getPromise(): PromiseInterface
    {
        return $this->promise;
    }

    /**
     * @inheritdoc
     */
    protected function doInitialize(): void
    {
        $this->collection = new ArrayCollection($this->promise->__resolve());

It seems like $this->promise->__resolve() can also be of type null; however, parameter $elements of Doctrine\Common\Collections\ArrayCollection::__construct() does only seem to accept array, maybe add an additional type check?

    }

    /**
     * @inheritDoc
     */
    public function matching(Criteria $criteria)
    {
        $this->initialize();

        return $this->collection->matching($criteria);

The method matching() does not exist on Doctrine\Common\Collections\Collection. It seems like you code against a sub-type of Doctrine\Common\Collections\Collection such as Doctrine\Common\Collections\ArrayCollection or Cycle\ORM\Promise\Collection\CollectionPromise or Cycle\ORM\Relation\Pivoted\PivotedCollection or Cycle\ORM\Promise\Collection\CollectionPromise.

    }
}