Cycle\ORM\Promise\PromiseOne

Complexity

Total Complexity

7

Size/Duplication

Total Lines	69
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	__resolve()	0	16	3
A	__role()	0	3	1
A	__loaded()	0	3	1
A	__scope()	0	3	1

<?php declare(strict_types=1);
/**
 * Spiral Framework.
 *
 * @license   MIT
 * @author    Anton Titov (Wolfy-J)
 */

namespace Cycle\ORM\Promise;

use Cycle\ORM\ORMInterface;

/**
 * Promises one entity and resolves the result via ORM heap or entity repository.
 */
class PromiseOne implements PromiseInterface
{
    /** @var ORMInterface|null @internal */
    private $orm;

    /** @var string|null */
    private $target;

    /** @var array */
    private $scope;

    /** @var mixed */
    private $resolved;

    /**
     * @param ORMInterface $orm
     * @param string       $target
     * @param array        $scope
     */
    public function __construct(ORMInterface $orm, string $target, array $scope)
    {
        $this->orm = $orm;
        $this->target = $target;
        $this->scope = $scope;
    }

    /**
     * @inheritdoc
     */
    public function __loaded(): bool
    {
        return empty($this->orm);
    }

    /**
     * @inheritdoc
     */
    public function __role(): string
    {
        return $this->target;

The expression return $this->target could return the type null which is incompatible with the type-hinted return string. Consider adding an additional type-check to rule them out.

    }

    /**
     * @inheritdoc
     */
    public function __scope(): array
    {
        return $this->scope;
    }

    /**
     * @inheritdoc
     */
    public function __resolve()
    {
        if (!is_null($this->orm)) {
            if (count($this->scope) !== 1) {
                $this->resolved = $this->orm->getRepository($this->target)->findOne($this->scope);
            } else {
                $key = key($this->scope);
                $value = $this->scope[$key];

                $this->resolved = $this->orm->get($this->target, $key, $value, true);

It seems like $this->target can also be of type null; however, parameter $role of Cycle\ORM\ORMInterface::get() does only seem to accept string, maybe add an additional type check?

            }

            $this->orm = null;
        }

        return $this->resolved;
    }
}