Cycle\ORM\Relation\RefersTo::queue()

Complexity

Conditions	5
Paths	5

Size

Total Lines	38
Code Lines	17

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function queue(CC $parentStore, $parentEntity, Node $parentNode, $related, $original): CommandInterface
    {
        // refers-to relation is always nullable (as opposite to belongs-to)
        if (is_null($related)) {
            if (!is_null($original)) {
                $parentStore->register($this->innerKey, null, true);
            }

            return new Nil();
        }

        $relNode = $this->getNode($related);
        $this->assertValid($relNode);

It seems like $relNode can also be of type null; however, parameter $relNode of Cycle\ORM\Relation\AbstractRelation::assertValid() does only seem to accept Cycle\ORM\Heap\Node, maybe add an additional type check?

        // related object exists, we can update key immediately
        if (!is_null($outerKey = $this->fetchKey($relNode, $this->outerKey))) {
            if ($outerKey != $this->fetchKey($parentNode, $this->innerKey)) {
                $parentStore->register($this->innerKey, $outerKey, true);
            }

            return new Nil();
        }

        // update parent entity once related instance is able to provide us context key
        $update = new Update(
            $this->getSource($parentNode->getRole())->getDatabase(),
            $this->getSource($parentNode->getRole())->getTable()
        );

        // fastest way to identify the entity
        $pk = $this->orm->getSchema()->define($parentNode->getRole(), Schema::PRIMARY_KEY);

The method getSchema() does not exist on Cycle\ORM\Select\SourceProviderInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Cycle\ORM\Select\SourceProviderInterface.

        $this->forwardContext($relNode, $this->outerKey, $update, $parentNode, $this->innerKey);

        // set where condition for update query
        $this->forwardScope($parentNode, $pk, $update, $pk);

        return $update;
    }