Cycle\ORM\Relation\BelongsTo::queue()

Complexity

Conditions	4
Paths	4

Size

Total Lines	23
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

0

<?php
    public function queue(CC $parentStore, $parentEntity, Node $parentNode, $related, $original): CommandInterface
    {
        if (is_null($related)) {
            if ($this->isRequired()) {
                throw new NullException("Relation {$this} can not be null");
            }

            if (!is_null($original)) {
                // reset the key
                $parentStore->register($this->innerKey, null, true);
            }

            // nothing to do
            return new Nil();
        }

        $relStore = $this->orm->queueStore($related);

The method queueStore() does not exist on Cycle\ORM\Select\SourceProviderInterface. Since it exists in all sub-types, consider adding an abstract or default implementation to Cycle\ORM\Select\SourceProviderInterface.

        $relNode = $this->getNode($related);
        $this->assertValid($relNode);

It seems like $relNode can also be of type null; however, parameter $relNode of Cycle\ORM\Relation\AbstractRelation::assertValid() does only seem to accept Cycle\ORM\Heap\Node, maybe add an additional type check?

        $this->forwardContext($relNode, $this->outerKey, $parentStore, $parentNode, $this->innerKey);

        return $relStore;
    }