Cycle\Database\Driver\SQLite\Schema\SQLiteColumn::createInstance()

Complexity

Conditions	13
Paths	28

Size

Total Lines	83
Code Lines	40

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	32
CRAP Score	13.0047

Importance

Changes

0

<?php
    public static function createInstance(
        string $table,
        array $schema,
        ?\DateTimeZone $timezone = null,
    ): self {
        $column = new self($table, $schema['name'], $timezone);

        $column->nullable = !$schema['notnull'];

The property nullable does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        $column->type = \strtolower($schema['type']);

The property type does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        if ((bool) $schema['pk'] && $column->type === 'integer') {
            $column->primaryKey = true;
        }

        /*
         * Normalizing default value.
         */
        $column->defaultValue = $schema['dflt_value'];

The property defaultValue does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        if (
            \is_string($column->defaultValue)
            && \preg_match('/^[\'""].*?[\'"]$/', $column->defaultValue)
        ) {
            $column->defaultValue = \substr($column->defaultValue, 1, -1);
        }

        if (
            !\preg_match(
                '/^(?P<type>[a-z]+) *(?:\((?P<options>[^\)]+)\))?/',
                $schema['type'],
                $matches,
            )
        ) {
            //No type definition included
            return $column;
        }

        // reformatted type value
        $column->type = $matches['type'];

        //Fetching size options
        if (!empty($matches['options'])) {
            $options = \explode(',', $matches['options']);

            if (\count($options) > 1) {
                $column->precision = (int) $options[0];
                $column->scale = (int) $options[1];
            } else {
                $column->size = (int) $options[0];

The property size does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

            }
        }

        if ($column->type === 'enum') {
            //Quoted column name
            $quoted = $schema['identifier'];

            foreach ($schema['table'] as $columnSchema) {
                //Looking for enum values in column definition code
                if (
                    \preg_match(
                        "/{$quoted} +enum.*?CHECK *\\({$quoted} in \\((.*?)\\)\\)/i",
                        \trim($columnSchema),
                        $matches,
                    )
                ) {
                    $enumValues = \explode(',', $matches[1]);
                    foreach ($enumValues as &$value) {
                        //Trimming values
                        if (\preg_match("/^'?(.*?)'?$/", \trim($value), $matches)) {
                            //In database: 'value'
                            $value = $matches[1];
                        }

                        unset($value);
                    }
                    unset($value);

                    $column->enumValues = $enumValues;

The property enumValues does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

                }
            }
        }

        return $column;
    }