cycle /
database
| Conditions | 1 |
| Paths | 1 |
| Total Lines | 20 |
| Code Lines | 9 |
| Lines | 0 |
| Ratio | 0 % |
| Tests | 3 |
| CRAP Score | 1 |
| Changes | 1 | ||
| Bugs | 0 | Features | 0 |
Methods with many parameters are not only hard to understand, but their parameters also often become inconsistent when you need more, or different data.
There are several approaches to avoid long parameter lists:
| 1 | <?php |
||
| 22 | public function __construct( |
||
| 23 | ConnectionConfig $connection, |
||
| 24 | string $driver = MySQLDriver::class, |
||
| 25 | bool $reconnect = true, |
||
| 26 | string $timezone = 'UTC', |
||
| 27 | 4 | bool $queryCache = true, |
|
| 28 | bool $readonlySchema = false, |
||
| 29 | bool $readonly = false, |
||
| 30 | array $options = [], |
||
| 31 | ) { |
||
| 32 | /** @psalm-suppress ArgumentTypeCoercion */ |
||
| 33 | parent::__construct( |
||
| 34 | connection: $connection, |
||
| 35 | driver: $driver, |
||
| 36 | reconnect: $reconnect, |
||
| 37 | 4 | timezone: $timezone, |
|
| 38 | 4 | queryCache: $queryCache, |
|
| 39 | readonlySchema: $readonlySchema, |
||
| 40 | readonly: $readonly, |
||
| 41 | options: $options, |
||
| 42 | ); |
||
| 45 |
Let?s assume that you have a directory layout like this:
. |-- OtherDir | |-- Bar.php | `-- Foo.php `-- SomeDir `-- Foo.phpand let?s assume the following content of
Bar.php:If both files
OtherDir/Foo.phpandSomeDir/Foo.phpare loaded in the same runtime, you will see a PHP error such as the following:PHP Fatal error: Cannot use SomeDir\Foo as Foo because the name is already in use in OtherDir/Foo.phpHowever, as
OtherDir/Foo.phpdoes not necessarily have to be loaded and the error is only triggered if it is loaded beforeOtherDir/Bar.php, this problem might go unnoticed for a while. In order to prevent this error from surfacing, you must import the namespace with a different alias: