cycle / annotated

src/ReaderFactory.php

<?php

declare(strict_types=1);

namespace Cycle\Annotated;

use Doctrine\Common\Annotations\Reader as DoctrineReader;
use Spiral\Attributes\AnnotationReader;
use Spiral\Attributes\AttributeReader;
use Spiral\Attributes\Composite\SelectiveReader;
use Spiral\Attributes\ReaderInterface;

final class ReaderFactory
{
    public static function create(DoctrineReader|ReaderInterface $reader = null): ReaderInterface
    {
        return match (true) {
            $reader instanceof ReaderInterface => $reader,
            $reader instanceof DoctrineReader => new AnnotationReader($reader),

It seems like $reader can also be of type Spiral\Attributes\ReaderInterface; however, parameter $reader of Spiral\Attributes\AnnotationReader::__construct() does only seem to accept Doctrine\Common\Annotations\Reader|null, maybe add an additional type check?

            $reader === null => new SelectiveReader([
                new AttributeReader(),
                new AnnotationReader(),
            ]),
        };
    }
}