Inspection of "Fix SQLite bug with indexes on older versions of l..." - cycle/annotated - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — master (#5)

unknown

created 2020-02-01 18:48 UTC

Switch Indentation -1 removed lines patch added patch discarded remove patch

@@ -249,4 +249,3 @@
 block discarded – undo
  * @link		http://pear.php.net/package/PHP_CodeSniffer
  */
 
-/** No docblock close tag. Must be last test without new line.
\ No newline at end of file

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/CodeAnalysis/EmptyStatementUnitTest.inc 1 patch

Switch Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

@@ -5,10 +5,10 @@
 block discarded – undo
 }
 
 switch ($foo) {
-    case 'bar':
-        break;
-    default:
-        break;
+        case 'bar':
+            break;
+        default:
+            break;
 }
 
 

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Arrays/DisallowLongArraySyntaxUnitTest.php 1 patch

Switch Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

@@ -28,22 +28,22 @@
 block discarded – undo
     public function getErrorList($testFile='')
     {
         switch ($testFile) {
-        case 'DisallowLongArraySyntaxUnitTest.1.inc':
-            return [
-                2  => 1,
-                4  => 1,
-                6  => 1,
-                7  => 1,
-                12 => 1,
-                13 => 1,
-            ];
-        case 'DisallowLongArraySyntaxUnitTest.2.inc':
-            return [
-                2 => 1,
-                9 => 1,
-            ];
-        default:
-            return [];
+            case 'DisallowLongArraySyntaxUnitTest.1.inc':
+                return [
+                    2  => 1,
+                    4  => 1,
+                    6  => 1,
+                    7  => 1,
+                    12 => 1,
+                    13 => 1,
+                ];
+            case 'DisallowLongArraySyntaxUnitTest.2.inc':
+                return [
+                    2 => 1,
+                    9 => 1,
+                ];
+            default:
+                return [];
         }//end switch
 
     }//end getErrorList()

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Arrays/DisallowLongArraySyntaxUnitTest.2.inc 1 patch

Switch Indentation -6 removed lines patch added patch discarded remove patch

		@@ -9,9 +9,3 @@
		block discarded – undo
9	9	$arr = array(
10	10	'a' => 'a',
11	11	<<<<<<< HEAD
12		- 'b' => 'b'
13		-=======
14		- 'c' => 'c'
15		->>>>>>> master
16		- );
17		- }

Please login to merge, or discard this patch.

Standards/Generic/Tests/Formatting/MultipleStatementAlignmentUnitTest.php 1 patch

Switch Indentation +104 added lines, -104 removed lines patch added patch discarded remove patch

		@@ -43,111 +43,111 @@
		block discarded – undo
43	43	public function getWarningList($testFile='MultipleStatementAlignmentUnitTest.inc')
44	44	{
45	45	switch ($testFile) {
46		- case 'MultipleStatementAlignmentUnitTest.inc':
47		- return [
48		- 11 => 1,
49		- 12 => 1,
50		- 23 => 1,
51		- 24 => 1,
52		- 26 => 1,
53		- 27 => 1,
54		- 37 => 1,
55		- 38 => 1,
56		- 48 => 1,
57		- 50 => 1,
58		- 51 => 1,
59		- 61 => 1,
60		- 62 => 1,
61		- 64 => 1,
62		- 65 => 1,
63		- 71 => 1,
64		- 78 => 1,
65		- 79 => 1,
66		- 86 => 1,
67		- 92 => 1,
68		- 93 => 1,
69		- 94 => 1,
70		- 95 => 1,
71		- 123 => 1,
72		- 124 => 1,
73		- 126 => 1,
74		- 129 => 1,
75		- 154 => 1,
76		- 161 => 1,
77		- 178 => 1,
78		- 179 => 1,
79		- 182 => 1,
80		- 206 => 1,
81		- 207 => 1,
82		- 252 => 1,
83		- 257 => 1,
84		- 263 => 1,
85		- 269 => 1,
86		- 293 => 1,
87		- 295 => 1,
88		- 296 => 1,
89		- 297 => 1,
90		- 301 => 1,
91		- 303 => 1,
92		- 308 => 1,
93		- 311 => 1,
94		- 313 => 1,
95		- 314 => 1,
96		- 321 => 1,
97		- 322 => 1,
98		- 324 => 1,
99		- 329 => 1,
100		- 331 => 1,
101		- 336 => 1,
102		- 339 => 1,
103		- 341 => 1,
104		- 342 => 1,
105		- 349 => 1,
106		- 350 => 1,
107		- 352 => 1,
108		- 357 => 1,
109		- 364 => 1,
110		- 396 => 1,
111		- 398 => 1,
112		- 399 => 1,
113		- 401 => 1,
114		- ];
115		- break;
116		- case 'MultipleStatementAlignmentUnitTest.js':
117		- return [
118		- 11 => 1,
119		- 12 => 1,
120		- 23 => 1,
121		- 24 => 1,
122		- 26 => 1,
123		- 27 => 1,
124		- 37 => 1,
125		- 38 => 1,
126		- 48 => 1,
127		- 50 => 1,
128		- 51 => 1,
129		- 61 => 1,
130		- 62 => 1,
131		- 64 => 1,
132		- 65 => 1,
133		- 71 => 1,
134		- 78 => 1,
135		- 79 => 1,
136		- 81 => 1,
137		- 82 => 1,
138		- 83 => 1,
139		- 85 => 1,
140		- 86 => 1,
141		- 100 => 1,
142		- 112 => 1,
143		- 113 => 1,
144		- 114 => 1,
145		- 117 => 1,
146		- ];
147		- break;
148		- default:
149		- return [];
	46	+ case 'MultipleStatementAlignmentUnitTest.inc':
	47	+ return [
	48	+ 11 => 1,
	49	+ 12 => 1,
	50	+ 23 => 1,
	51	+ 24 => 1,
	52	+ 26 => 1,
	53	+ 27 => 1,
	54	+ 37 => 1,
	55	+ 38 => 1,
	56	+ 48 => 1,
	57	+ 50 => 1,
	58	+ 51 => 1,
	59	+ 61 => 1,
	60	+ 62 => 1,
	61	+ 64 => 1,
	62	+ 65 => 1,
	63	+ 71 => 1,
	64	+ 78 => 1,
	65	+ 79 => 1,
	66	+ 86 => 1,
	67	+ 92 => 1,
	68	+ 93 => 1,
	69	+ 94 => 1,
	70	+ 95 => 1,
	71	+ 123 => 1,
	72	+ 124 => 1,
	73	+ 126 => 1,
	74	+ 129 => 1,
	75	+ 154 => 1,
	76	+ 161 => 1,
	77	+ 178 => 1,
	78	+ 179 => 1,
	79	+ 182 => 1,
	80	+ 206 => 1,
	81	+ 207 => 1,
	82	+ 252 => 1,
	83	+ 257 => 1,
	84	+ 263 => 1,
	85	+ 269 => 1,
	86	+ 293 => 1,
	87	+ 295 => 1,
	88	+ 296 => 1,
	89	+ 297 => 1,
	90	+ 301 => 1,
	91	+ 303 => 1,
	92	+ 308 => 1,
	93	+ 311 => 1,
	94	+ 313 => 1,
	95	+ 314 => 1,
	96	+ 321 => 1,
	97	+ 322 => 1,
	98	+ 324 => 1,
	99	+ 329 => 1,
	100	+ 331 => 1,
	101	+ 336 => 1,
	102	+ 339 => 1,
	103	+ 341 => 1,
	104	+ 342 => 1,
	105	+ 349 => 1,
	106	+ 350 => 1,
	107	+ 352 => 1,
	108	+ 357 => 1,
	109	+ 364 => 1,
	110	+ 396 => 1,
	111	+ 398 => 1,
	112	+ 399 => 1,
	113	+ 401 => 1,
	114	+ ];
150	115	break;
	116	+ case 'MultipleStatementAlignmentUnitTest.js':
	117	+ return [
	118	+ 11 => 1,
	119	+ 12 => 1,
	120	+ 23 => 1,
	121	+ 24 => 1,
	122	+ 26 => 1,
	123	+ 27 => 1,
	124	+ 37 => 1,
	125	+ 38 => 1,
	126	+ 48 => 1,
	127	+ 50 => 1,
	128	+ 51 => 1,
	129	+ 61 => 1,
	130	+ 62 => 1,
	131	+ 64 => 1,
	132	+ 65 => 1,
	133	+ 71 => 1,
	134	+ 78 => 1,
	135	+ 79 => 1,
	136	+ 81 => 1,
	137	+ 82 => 1,
	138	+ 83 => 1,
	139	+ 85 => 1,
	140	+ 86 => 1,
	141	+ 100 => 1,
	142	+ 112 => 1,
	143	+ 113 => 1,
	144	+ 114 => 1,
	145	+ 117 => 1,
	146	+ ];
	147	+ break;
	148	+ default:
	149	+ return [];
	150	+ break;
151	151	}//end switch
152	152
153	153	}//end getWarningList()

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Formatting/SpaceAfterNotUnitTest.php 1 patch

Switch Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch

		@@ -28,46 +28,46 @@
		block discarded – undo
28	28	public function getErrorList($testFile='')
29	29	{
30	30	switch ($testFile) {
31		- case 'SpaceAfterNotUnitTest.inc':
32		- return [
33		- 3 => 2,
34		- 4 => 2,
35		- 5 => 2,
36		- 6 => 1,
37		- 7 => 1,
38		- 8 => 1,
39		- 11 => 1,
40		- 14 => 1,
41		- 17 => 1,
42		- 20 => 1,
43		- 28 => 1,
44		- 38 => 2,
45		- 39 => 2,
46		- 40 => 1,
47		- 41 => 1,
48		- 42 => 1,
49		- 48 => 1,
50		- 51 => 1,
51		- 56 => 2,
52		- 57 => 1,
53		- 58 => 1,
54		- 59 => 1,
55		- 62 => 1,
56		- 65 => 1,
57		- 68 => 1,
58		- 71 => 1,
59		- 79 => 1,
60		- ];
	31	+ case 'SpaceAfterNotUnitTest.inc':
	32	+ return [
	33	+ 3 => 2,
	34	+ 4 => 2,
	35	+ 5 => 2,
	36	+ 6 => 1,
	37	+ 7 => 1,
	38	+ 8 => 1,
	39	+ 11 => 1,
	40	+ 14 => 1,
	41	+ 17 => 1,
	42	+ 20 => 1,
	43	+ 28 => 1,
	44	+ 38 => 2,
	45	+ 39 => 2,
	46	+ 40 => 1,
	47	+ 41 => 1,
	48	+ 42 => 1,
	49	+ 48 => 1,
	50	+ 51 => 1,
	51	+ 56 => 2,
	52	+ 57 => 1,
	53	+ 58 => 1,
	54	+ 59 => 1,
	55	+ 62 => 1,
	56	+ 65 => 1,
	57	+ 68 => 1,
	58	+ 71 => 1,
	59	+ 79 => 1,
	60	+ ];
61	61
62		- case 'SpaceAfterNotUnitTest.js':
63		- return [
64		- 2 => 2,
65		- 4 => 2,
66		- 5 => 1,
67		- ];
	62	+ case 'SpaceAfterNotUnitTest.js':
	63	+ return [
	64	+ 2 => 2,
	65	+ 4 => 2,
	66	+ 5 => 1,
	67	+ ];
68	68
69		- default:
70		- return [];
	69	+ default:
	70	+ return [];
71	71	}//end switch
72	72
73	73	}//end getErrorList()

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Strings/UnnecessaryStringConcatUnitTest.php 1 patch

Switch Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

@@ -28,28 +28,28 @@
 block discarded – undo
     public function getErrorList($testFile='UnnecessaryStringConcatUnitTest.inc')
     {
         switch ($testFile) {
-        case 'UnnecessaryStringConcatUnitTest.inc':
-            return [
-                2  => 1,
-                6  => 1,
-                9  => 1,
-                12 => 1,
-                19 => 1,
-                20 => 1,
-            ];
-            break;
-        case 'UnnecessaryStringConcatUnitTest.js':
-            return [
-                1  => 1,
-                8  => 1,
-                11 => 1,
-                14 => 1,
-                15 => 1,
-            ];
-            break;
-        default:
-            return [];
-            break;
+            case 'UnnecessaryStringConcatUnitTest.inc':
+                return [
+                    2  => 1,
+                    6  => 1,
+                    9  => 1,
+                    12 => 1,
+                    19 => 1,
+                    20 => 1,
+                ];
+                break;
+            case 'UnnecessaryStringConcatUnitTest.js':
+                return [
+                    1  => 1,
+                    8  => 1,
+                    11 => 1,
+                    14 => 1,
+                    15 => 1,
+                ];
+                break;
+            default:
+                return [];
+                break;
         }//end switch
 
     }//end getErrorList()

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Files/EndFileNewlineUnitTest.php 1 patch

Switch Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

@@ -28,13 +28,13 @@
 block discarded – undo
     public function getErrorList($testFile='')
     {
         switch ($testFile) {
-        case 'EndFileNewlineUnitTest.3.inc':
-        case 'EndFileNewlineUnitTest.3.js':
-        case 'EndFileNewlineUnitTest.3.css':
-        case 'EndFileNewlineUnitTest.4.inc':
-            return [2 => 1];
-        default:
-            return [];
+            case 'EndFileNewlineUnitTest.3.inc':
+            case 'EndFileNewlineUnitTest.3.js':
+            case 'EndFileNewlineUnitTest.3.css':
+            case 'EndFileNewlineUnitTest.4.inc':
+                return [2 => 1];
+            default:
+                return [];
         }//end switch
 
     }//end getErrorList()

Please login to merge, or discard this patch.

src/Standards/Generic/Tests/Files/EndFileNoNewlineUnitTest.5.inc 1 patch

Switch Indentation -1 removed lines patch added patch discarded remove patch

		@@ -1,2 +1,1 @@
		block discarded – undo
1	1	<?php
2		-/** Why me?
3	2	\ No newline at end of file

Please login to merge, or discard this patch.

		@@ -249,4 +249,3 @@
		block discarded – undo
249	249	* @link http://pear.php.net/package/PHP_CodeSniffer
250	250	*/
251	251
252		-/** No docblock close tag. Must be last test without new line.
253	252	\ No newline at end of file

		@@ -5,10 +5,10 @@
		block discarded – undo
5	5	}
6	6
7	7	switch ($foo) {
8		- case 'bar':
9		- break;
10		- default:
11		- break;
	8	+ case 'bar':
	9	+ break;
	10	+ default:
	11	+ break;
12	12	}
13	13
14	14

		@@ -28,22 +28,22 @@
		block discarded – undo
28	28	public function getErrorList($testFile='')
29	29	{
30	30	switch ($testFile) {
31		- case 'DisallowLongArraySyntaxUnitTest.1.inc':
32		- return [
33		- 2 => 1,
34		- 4 => 1,
35		- 6 => 1,
36		- 7 => 1,
37		- 12 => 1,
38		- 13 => 1,
39		- ];
40		- case 'DisallowLongArraySyntaxUnitTest.2.inc':
41		- return [
42		- 2 => 1,
43		- 9 => 1,
44		- ];
45		- default:
46		- return [];
	31	+ case 'DisallowLongArraySyntaxUnitTest.1.inc':
	32	+ return [
	33	+ 2 => 1,
	34	+ 4 => 1,
	35	+ 6 => 1,
	36	+ 7 => 1,
	37	+ 12 => 1,
	38	+ 13 => 1,
	39	+ ];
	40	+ case 'DisallowLongArraySyntaxUnitTest.2.inc':
	41	+ return [
	42	+ 2 => 1,
	43	+ 9 => 1,
	44	+ ];
	45	+ default:
	46	+ return [];
47	47	}//end switch
48	48
49	49	}//end getErrorList()

		@@ -28,28 +28,28 @@
		block discarded – undo
28	28	public function getErrorList($testFile='UnnecessaryStringConcatUnitTest.inc')
29	29	{
30	30	switch ($testFile) {
31		- case 'UnnecessaryStringConcatUnitTest.inc':
32		- return [
33		- 2 => 1,
34		- 6 => 1,
35		- 9 => 1,
36		- 12 => 1,
37		- 19 => 1,
38		- 20 => 1,
39		- ];
40		- break;
41		- case 'UnnecessaryStringConcatUnitTest.js':
42		- return [
43		- 1 => 1,
44		- 8 => 1,
45		- 11 => 1,
46		- 14 => 1,
47		- 15 => 1,
48		- ];
49		- break;
50		- default:
51		- return [];
52		- break;
	31	+ case 'UnnecessaryStringConcatUnitTest.inc':
	32	+ return [
	33	+ 2 => 1,
	34	+ 6 => 1,
	35	+ 9 => 1,
	36	+ 12 => 1,
	37	+ 19 => 1,
	38	+ 20 => 1,
	39	+ ];
	40	+ break;
	41	+ case 'UnnecessaryStringConcatUnitTest.js':
	42	+ return [
	43	+ 1 => 1,
	44	+ 8 => 1,
	45	+ 11 => 1,
	46	+ 14 => 1,
	47	+ 15 => 1,
	48	+ ];
	49	+ break;
	50	+ default:
	51	+ return [];
	52	+ break;
53	53	}//end switch
54	54
55	55	}//end getErrorList()

		@@ -28,13 +28,13 @@
		block discarded – undo
28	28	public function getErrorList($testFile='')
29	29	{
30	30	switch ($testFile) {
31		- case 'EndFileNewlineUnitTest.3.inc':
32		- case 'EndFileNewlineUnitTest.3.js':
33		- case 'EndFileNewlineUnitTest.3.css':
34		- case 'EndFileNewlineUnitTest.4.inc':
35		- return [2 => 1];
36		- default:
37		- return [];
	31	+ case 'EndFileNewlineUnitTest.3.inc':
	32	+ case 'EndFileNewlineUnitTest.3.js':
	33	+ case 'EndFileNewlineUnitTest.3.css':
	34	+ case 'EndFileNewlineUnitTest.4.inc':
	35	+ return [2 => 1];
	36	+ default:
	37	+ return [];
38	38	}//end switch
39	39
40	40	}//end getErrorList()

cycle / annotated

Pull Request — master (#5)

Category

Switch Indentation -1 removed lines patch added patch discarded remove patch

Switch Indentation +4 added lines, -4 removed lines patch added patch discarded remove patch

Switch Indentation +16 added lines, -16 removed lines patch added patch discarded remove patch

Switch Indentation -6 removed lines patch added patch discarded remove patch

Switch Indentation +104 added lines, -104 removed lines patch added patch discarded remove patch

Switch Indentation +38 added lines, -38 removed lines patch added patch discarded remove patch

Switch Indentation +22 added lines, -22 removed lines patch added patch discarded remove patch

Switch Indentation +7 added lines, -7 removed lines patch added patch discarded remove patch

Switch Indentation -1 removed lines patch added patch discarded remove patch