JoinedTable::__construct() - Code Metrics - Inspection of "Add fk for JTI" - cycle/annotated - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Pull Request — 3.x (#43)

by Aleksei

created 2022-01-11 12:28 UTC

JoinedTable::__construct() A

↳ Parent: JoinedTable

Complexity

Conditions	1
Paths	1

Size

Total Lines	10
Code Lines	1

Duplication

Lines	0
Ratio	0 %

Code Coverage

Tests	2
CRAP Score	1

Importance

Changes	1
Bugs	0	Features	0

Metric	Value
cc	1
eloc	1
c	1
b	0
f	0
nc	1
nop	3
dl	0
loc	10
ccs	2
cts	2
cp	1
crap	1
rs	10

<?php

declare(strict_types=1);

namespace Cycle\Annotated\Annotation\Inheritance;

use Cycle\Annotated\Annotation\Inheritance;
use Doctrine\Common\Annotations\Annotation\NamedArgumentConstructor;
use JetBrains\PhpStorm\ExpectedValues;

/**
 * @Annotation
 * @NamedArgumentConstructor
 * @Target("CLASS")
 */
#[\Attribute(\Attribute::TARGET_CLASS), NamedArgumentConstructor]
class JoinedTable extends Inheritance
{
    /**
     * @param non-empty-string|null $outerKey Outer (parent) key name.

     * @param bool $fkCreate Set to true to automatically create FK on outerKey.
     * @param non-empty-string|null $fkAction FK onDelete and onUpdate action.
     */
    public function __construct(
        private ?string $outerKey = null,
        private bool $fkCreate = true,
        /**
         * @Enum({"NO ACTION", "CASCADE", "SET NULL"})
         */
        #[ExpectedValues(values: ['NO ACTION', 'CASCADE', 'SET NULL'])]
        private ?string $fkAction = 'CASCADE',
    ) {
        parent::__construct('joined');
    }

    public function getOuterKey(): ?string
    {
        return $this->outerKey;
    }

    public function isCreateFk(): bool
    {
        return $this->fkCreate;
    }

    public function getFkAction(): string
    {
        return $this->fkAction;

    }
}


1		<?php
2
3		declare(strict_types=1);
4
5		namespace Cycle\Annotated\Annotation\Inheritance;
6
7		use Cycle\Annotated\Annotation\Inheritance;
8		use Doctrine\Common\Annotations\Annotation\NamedArgumentConstructor;
9		use JetBrains\PhpStorm\ExpectedValues;
10
11		/**
12		* @Annotation
13		* @NamedArgumentConstructor
14		* @Target("CLASS")
15		*/
16		#[\Attribute(\Attribute::TARGET_CLASS), NamedArgumentConstructor]
17		class JoinedTable extends Inheritance
18	72	{
19		/**
20		* @param non-empty-string\|null $outerKey Outer (parent) key name.
		0 ignored issues – show Documentation Bug introduced 2022-01-11 12:38 UTC by Report Bug Copy Issue Report The doc comment `non-empty-string\|null` at position `0` could not be parsed: Unknown type name 'non-empty-string' at position 0 in non-empty-string\|null. Loading history...
21	72	* @param bool $fkCreate Set to true to automatically create FK on outerKey.
22	72	* @param non-empty-string\|null $fkAction FK onDelete and onUpdate action.
23		*/
24	72	public function __construct(
25		private ?string $outerKey = null,
26	72	private bool $fkCreate = true,
27		/**
28		* @Enum({"NO ACTION", "CASCADE", "SET NULL"})
29		*/
30		#[ExpectedValues(values: ['NO ACTION', 'CASCADE', 'SET NULL'])]
31		private ?string $fkAction = 'CASCADE',
32		) {
33		parent::__construct('joined');
34		}
35
36		public function getOuterKey(): ?string
37		{
38		return $this->outerKey;
39		}
40
41		public function isCreateFk(): bool
42		{
43		return $this->fkCreate;
44		}
45
46		public function getFkAction(): string
47		{
48		return $this->fkAction;
		0 ignored issues – show Bug Best Practice introduced 2022-01-11 12:38 UTC by Report Bug Copy Issue Report The expression `return $this->fkAction` could return the type `null` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
49		}
50		}
51

cycle / annotated

Pull Request — 3.x (#43)

JoinedTable::__construct() A

Complexity

Size

Duplication

Code Coverage

Importance

Duplication Side-by-Side

Filter issues like