Response - Code Metrics - Inspection of "Refactor HTTP controllers (#12)" - cybercog/laravel-sense - Measure and Improve Code Quality continuously with Scrutinizer

Passed

Push — master ( cf066d...0d7181 )

by Anton

created 2018-10-06 23:43 UTC

Response A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	34
Duplicated Lines	0 %

Importance

Changes

Metric	Value
eloc	10
dl	0
loc	34
rs	10
c	0
b	0
f	0
wmc	5

4 Methods

Rating	Name	Size	Complexity
A	toJson()	3	1
A	toResponse()	3	2
A	__construct()	4	1
A	toHtml()	5	1

<?php

/*
 * This file is part of Laravel Sense.
 *
 * (c) Anton Komarev <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Laravel\Sense\Http\Controllers\Requests\Get;

use Illuminate\Contracts\Support\Responsable;

class Response implements Responsable
{
    /**
     * @var \Cog\Laravel\Sense\RequestSummary\Models\RequestSummary
     */
    private $requestSummary;

    /**
     * @var \Cog\Laravel\Sense\StatementSummary\Models\StatementSummary[]
     */
    private $statementSummaries;

    public function __construct($requestSummary, $statementSummaries)
    {
        $this->requestSummary = $requestSummary;
        $this->statementSummaries = $statementSummaries;
    }

    public function toResponse($request)
    {
        return $request->wantsJson() ? $this->toJson() : $this->toHtml();
interface HasName {
    /** @return string */
    public function getName();
}

class Name {
    public $name;
}

class User implements HasName {
    /** @return string|Name */
    public function getName() {
        return new Name('foo'); // This is a violation of the ``HasName`` interface
                                // which only allows a string value to be returned.
    }
}
    }

    private function toHtml()
    {
        return view('sense::requests.view', [
            'requestSummary' => $this->requestSummary,
            'statementSummaries' => $this->statementSummaries,
        ]);
    }

    private function toJson()
    {
        return [];
    }
}


1			<?php
2
3			/*
4			* This file is part of Laravel Sense.
5			*
6			* (c) Anton Komarev <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Cog\Laravel\Sense\Http\Controllers\Requests\Get;
15
16			use Illuminate\Contracts\Support\Responsable;
17
18			class Response implements Responsable
19			{
20			/**
21			* @var \Cog\Laravel\Sense\RequestSummary\Models\RequestSummary
22			*/
23			private $requestSummary;
24
25			/**
26			* @var \Cog\Laravel\Sense\StatementSummary\Models\StatementSummary[]
27			*/
28			private $statementSummaries;
29
30			public function __construct($requestSummary, $statementSummaries)
31			{
32			$this->requestSummary = $requestSummary;
33			$this->statementSummaries = $statementSummaries;
34			}
35
36			public function toResponse($request)
37			{
38			return $request->wantsJson() ? $this->toJson() : $this->toHtml();
			0 ignored issues – show Bug Best Practice introduced 2018-10-06 23:30 UTC by Report Bug Copy Issue Report The expression `return $request->wantsJs...son() : $this->toHtml()` returns the type `Illuminate\View\View\|array` which is incompatible with the return type mandated by `Illuminate\Contracts\Sup...sponsable::toResponse()` of `Illuminate\Http\Response`. In the issue above, the returned value is violating the contract defined by the mentioned interface. Let's take a look at an example: interface HasName { /** @return string / public function getName(); } class Name { public $name; } class User implements HasName { /* @return string\|Name */ public function getName() { return new Name('foo'); // This is a violation of the ``HasName`` interface // which only allows a string value to be returned. } } Loading history...
39			}
40
41			private function toHtml()
42			{
43			return view('sense::requests.view', [
44			'requestSummary' => $this->requestSummary,
45			'statementSummaries' => $this->statementSummaries,
46			]);
47			}
48
49			private function toJson()
50			{
51			return [];
52			}
53			}
54

cybercog / laravel-sense

Push — master ( cf066d...0d7181 )

Response A

Complexity

Size/Duplication

Importance

4 Methods

Duplication Side-by-Side

Filter issues like