cybercog / laravel-paket

src/Http/Controllers/Api/Requirements/Post/Action.php

<?php

/*
 * This file is part of Laravel Paket.
 *
 * (c) Anton Komarev <anton@komarev.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Laravel\Paket\Http\Controllers\Api\Requirements\Post;

use Cog\Contracts\Paket\Job\Repositories\JobRepository as JobRepositoryContract;
use Cog\Laravel\Paket\Job\Entities\Job;
use Cog\Laravel\Paket\Requirement\Entities\Requirement;
use Cog\Laravel\Paket\Requirement\Events\RequirementInstalling;
use Cog\Laravel\Paket\Support\Composer;
use Illuminate\Contracts\Support\Responsable as ResponsableContract;
use Illuminate\Support\Arr;
use Illuminate\Validation\ValidationException;
use MCStreetguy\ComposerParser\Factory as ComposerParser;

final class Action
{
    public function __invoke(JobRepositoryContract $jobs, Composer $composer, Request $request): ResponsableContract
    {
        $name = $request->input('name');
        $version = $request->input('version');
        $isDevelopment = (bool) $request->input('isDevelopment');

        $requirement = new Requirement($name, $version, $isDevelopment);

It seems like $name defined by $request->input('name') on line 30 can also be of type array or null; however, Cog\Laravel\Paket\Requirement\Entities\Requirement::__construct() does only seem to accept string, maybe add an additional type check?

        $installedRequirements = $this->getInstalledRequirements();

        $installedRequirement = Arr::first($installedRequirements, function (array $value) use ($name) {
            return $value['name'] === $name;
        });

        if (!is_null($installedRequirement)) {
            if ($version === $installedRequirement['version'] && $installedRequirement['isDevelopment'] === $isDevelopment) {
                $error = ValidationException::withMessages([
                    'name' => [
                        "Package `{$name}` v{$version} already installed",
                    ],
                ]);
                throw $error;
            }
        }

        $job = Job::ofType('ComposerInstall');

        $jobs
            ->store($job, $requirement);

        event(new RequirementInstalling($requirement, $job));

        return new Response($requirement, $job);
    }

    private function getInstalledRequirements(): array
    {
        $lockFile = ComposerParser::parseLockfile(base_path('composer.lock'));

        $packages = $lockFile->getPackages()->getData();
        $devPackages = $lockFile->getPackagesDev()->getData();

        foreach ($packages as &$package) {
            $package['isDevelopment'] = false;
        }
        foreach ($devPackages as &$package) {
            $package['isDevelopment'] = true;
        }

        return array_merge($packages, $devPackages);
    }
}