DeleteResponse::__construct() - Code Metrics - Inspection of "Jobs delete button (#39)" - cybercog/laravel-paket - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 3776e9...4c421f )

by Anton

created 2019-09-06 19:41 UTC

DeleteResponse::__construct() A

↳ Parent: DeleteResponse

Complexity

Conditions	1
Paths	1

Size

Total Lines

Duplication

Lines	4
Ratio	100 %

Importance

Changes

Metric	Value
dl	4
loc	4
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	1

<?php

/*
 * This file is part of Laravel Paket.
 *
 * (c) Anton Komarev <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Laravel\Paket\Http\Controllers\Api\Jobs;

use Cog\Contracts\Paket\Job\Entities\Job as JobContract;
use Illuminate\Contracts\Support\Responsable as ResponsableContract;
use Illuminate\Http\JsonResponse;

final class DeleteResponse implements ResponsableContract

{
    private $job;

    public function __construct(JobContract $job)
    {
        $this->job = $job;
    }

    /**
     * Create an HTTP response that represents the object.
     *
     * @param  \Illuminate\Http\Request $request
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function toResponse($request)
    {
        return $this->toJson();
    }

    private function toJson(): JsonResponse
    {
        return response()->json($this->job->toArray());
class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}
    }
}


1		<?php
2
3		/*
4		* This file is part of Laravel Paket.
5		*
6		* (c) Anton Komarev <[email protected]>
7		*
8		* For the full copyright and license information, please view the LICENSE
9		* file that was distributed with this source code.
10		*/
11
12		declare(strict_types=1);
13
14		namespace Cog\Laravel\Paket\Http\Controllers\Api\Jobs;
15
16		use Cog\Contracts\Paket\Job\Entities\Job as JobContract;
17		use Illuminate\Contracts\Support\Responsable as ResponsableContract;
18		use Illuminate\Http\JsonResponse;
19
20	View Code Duplication	final class DeleteResponse implements ResponsableContract
		0 ignored issues – show Duplication introduced 2019-06-29 00:15 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
21		{
22		private $job;
23
24		public function __construct(JobContract $job)
25		{
26		$this->job = $job;
27		}
28
29		/**
30		* Create an HTTP response that represents the object.
31		*
32		* @param \Illuminate\Http\Request $request
33		* @return \Symfony\Component\HttpFoundation\Response
34		*/
35		public function toResponse($request)
36		{
37		return $this->toJson();
38		}
39
40		private function toJson(): JsonResponse
41		{
42		return response()->json($this->job->toArray());
		0 ignored issues – show Bug introduced 2019-09-06 16:05 UTC by Report Bug Copy Issue Report The method `json` does only exist in `Illuminate\Contracts\Routing\ResponseFactory`, but not in `Illuminate\Http\Response`. It seems like the method you are trying to call exists only in some of the possible types. Let’s take a look at an example: class A { public function foo() { } } class B extends A { public function bar() { } } /** * @param A\|B $x / function someFunction($x) { $x->foo(); // This call is fine as the method exists in A and B. $x->bar(); // This method only exists in B and might cause an error. } Available Fixes Add an additional type-check: /* * @param A\|B $x / function someFunction($x) { $x->foo(); if ($x instanceof B) { $x->bar(); } } Only allow a single type to be passed if the variable comes from a parameter: function someFunction(B $x) { /* ... */ } Loading history...
43		}
44		}
45

cybercog / laravel-paket

Push — master ( 3776e9...4c421f )

DeleteResponse::__construct() A

Complexity

Size

Duplication

Importance

Available Fixes

Duplication Side-by-Side

Filter issues like