Completed
Push — master ( b74201...e72f98 )
by Anton
05:56
created

src/Http/Controllers/App/Response.php (2 issues)

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

1
<?php
2
3
/*
4
 * This file is part of Laravel Paket.
5
 *
6
 * (c) Anton Komarev <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
declare(strict_types=1);
13
14
namespace Cog\Laravel\Paket\Http\Controllers\App;
15
16
use Illuminate\Contracts\Support\Responsable as ResponsableContract;
17
use Illuminate\Http\Request;
18
use Illuminate\Http\Response as IlluminateResponse;
19
use Illuminate\Support\Facades\Config;
20
21
final class Response implements ResponsableContract
22
{
23
    /**
24
     * Create an HTTP response that represents the object.
25
     *
26
     * @param  \Illuminate\Http\Request $request
27
     * @return \Symfony\Component\HttpFoundation\Response
28
     */
29
    public function toResponse($request)
30
    {
31
        return $this->toHtml($request);
32
    }
33
34
    private function toHtml(Request $request): IlluminateResponse
0 ignored issues
show
The parameter $request is not used and could be removed.

This check looks from parameters that have been defined for a function or method, but which are not used in the method body.

Loading history...
35
    {
36
        return response()->view('paket::app', [
0 ignored issues
show
The method view does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
37
            'cssFile' => 'app.css',
38
            'paketScriptVariables' => [
39
                'baseUri' => Config::get('paket.base_uri'),
40
            ],
41
        ]);
42
    }
43
}
44