cybercog / laravel-paket

src/Http/Controllers/Api/Jobs/Collect/Response.php

<?php

/*
 * This file is part of Laravel Paket.
 *
 * (c) Anton Komarev <anton@komarev.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Laravel\Paket\Http\Controllers\Api\Jobs\Collect;

use Illuminate\Contracts\Support\Responsable as ResponsableContract;
use Illuminate\Http\JsonResponse;
use Illuminate\Http\Request;

final class Response implements ResponsableContract
{
    private $jobs;

    public function __construct(iterable $jobs)
    {
        $this->jobs = $jobs;
    }

    /**
     * Create an HTTP response that represents the object.
     *
     * @param  \Illuminate\Http\Request $request
     * @return \Symfony\Component\HttpFoundation\Response
     */
    public function toResponse($request)
    {
        return $this->toJson($request);
    }

    private function toJson(Request $request): JsonResponse

The parameter $request is not used and could be removed.

    {
        $jobs = [];
        foreach ($this->jobs as $job) {
            $jobs[] = $job->toArray();
        }

        return response()->json($jobs);

The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

    }
}