Completed
Push — master ( 43792a...dc88f4 )
by Anton
12s queued 11s
created

CollectResponse::toJson()   A

Complexity

Conditions 1
Paths 1

Size

Total Lines 4

Duplication

Lines 0
Ratio 0 %

Importance

Changes 0
Metric Value
dl 0
loc 4
rs 10
c 0
b 0
f 0
cc 1
nc 1
nop 0
1
<?php
2
3
/*
4
 * This file is part of Laravel Paket.
5
 *
6
 * (c) Anton Komarev <[email protected]>
7
 *
8
 * For the full copyright and license information, please view the LICENSE
9
 * file that was distributed with this source code.
10
 */
11
12
declare(strict_types=1);
13
14
namespace Cog\Laravel\Paket\Http\Controllers\Api\Repositories;
15
16
use Illuminate\Contracts\Support\Responsable as ResponsableContract;
17
use Illuminate\Http\JsonResponse;
18
19
final class CollectResponse implements ResponsableContract
20
{
21
    private $repositories;
22
23
    public function __construct(iterable $repositories)
24
    {
25
        $this->repositories = $repositories;
26
    }
27
28
    /**
29
     * Create an HTTP response that represents the object.
30
     *
31
     * @param  \Illuminate\Http\Request $request
32
     * @return \Symfony\Component\HttpFoundation\Response
33
     */
34
    public function toResponse($request)
35
    {
36
        return $this->toJson();
37
    }
38
39
    private function toJson(): JsonResponse
40
    {
41
        return response()->json($this->repositories);
0 ignored issues
show
Bug introduced by antonkomarev
The method json does only exist in Illuminate\Contracts\Routing\ResponseFactory, but not in Illuminate\Http\Response.

It seems like the method you are trying to call exists only in some of the possible types.

Let’s take a look at an example:

class A
{
    public function foo() { }
}

class B extends A
{
    public function bar() { }
}

/**
 * @param A|B $x
 */
function someFunction($x)
{
    $x->foo(); // This call is fine as the method exists in A and B.
    $x->bar(); // This method only exists in B and might cause an error.
}

Available Fixes

  1. Add an additional type-check:

    /**
     * @param A|B $x
     */
    function someFunction($x)
    {
        $x->foo();
    
        if ($x instanceof B) {
            $x->bar();
        }
    }
    
  2. Only allow a single type to be passed if the variable comes from a parameter:

    function someFunction(B $x) { /** ... */ }
    
Loading history...
42
    }
43
}
44