ReactionTypeAdd::createReactionType() - Code Metrics - Inspection of "Add love:reaction-type-add command (#51)" - cybercog/laravel-love - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( 115cf1...6727e2 )

by Anton

created 2019-05-07 09:07 UTC

ReactionTypeAdd::createReactionType() A

↳ Parent: ReactionTypeAdd

Complexity

Conditions	1
Paths	1

Size

Total Lines	11
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
eloc	7
dl	0
loc	11
rs	10
c	0
b	0
f	0
cc	1
nc	1
nop	2

<?php

/*
 * This file is part of Laravel Love.
 *
 * (c) Anton Komarev <[email protected]>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Laravel\Love\Console\Commands;

use Cog\Laravel\Love\ReactionType\Models\ReactionType;
use Illuminate\Console\Command;
use Illuminate\Support\Str;

final class ReactionTypeAdd extends Command
{
    /**
     * The name and signature of the console command.
     *
     * @var string
     */
    protected $signature = 'love:reaction-type-add
                            {--default}
                            {name?}
                            {weight?}';

    /**
     * The console command description.
     *
     * @var string
     */
    protected $description = 'Add Reaction Type to Laravel Love';

    /**
     * Execute the console command.
     *
     * @return int
     */
    public function handle(): int
    {
        if ($this->option('default')) {
            $this->createDefaultReactionTypes();

            return 0;
        }

        $name = $this->resolveName();
        $name = $this->sanitizeName($name);

        if ($this->isNameInvalid($name)) {
            $this->error(sprintf(
                'Reaction type with name `%s` is invalid.',
                $name
            ));

            return 1;
        }

        if ($this->isReactionTypeNameExists($name)) {
            $this->error(sprintf(
                'Reaction type with name `%s` already exists.',
                $name
            ));

            return 1;
        }

        $this->createReactionType($name, $this->resolveWeight());

        return 0;
    }

    private function createDefaultReactionTypes(): void
    {
        $types = [
            [
                'name' => 'Like',
                'weight' => 1,
            ],
            [
                'name' => 'Dislike',
                'weight' => -1,
            ],
        ];

        foreach ($types as $type) {
            if ($this->isReactionTypeNameExists($type['name'])) {
                continue;
            }

            $this->createReactionType($type['name'], $type['weight']);
        }
    }

    private function createReactionType(string $name, int $weight): void
    {
        ReactionType::query()->create([
            'name' => $name,
            'weight' => $weight,
        ]);

        $this->line(sprintf(
            'Reaction type with name `%s` and weight `%d` was added.',
            $name,
            $weight
        ));
    }

    private function resolveName(): string
    {
        return $this->argument('name')

            ?? $this->ask('How to name reaction type?')
            ?? $this->resolveName();
    }

    private function resolveWeight(): int
    {
        return intval($this->argument('weight') ?? $this->ask('What is the weight of this reaction type?'));
    }

    private function sanitizeName(string $name): string
    {
        $name = trim($name);
        $name = Str::studly($name);

        return $name;
    }

    private function isReactionTypeNameExists(string $name): bool
    {
        return ReactionType::query()->where('name', $name)->exists();

    }

    private function isNameInvalid(string $name): bool
    {
        return preg_match('#^[A-Z][a-zA-Z0-9_]*$#', $name) === 0;
    }
}


1			<?php
2
3			/*
4			* This file is part of Laravel Love.
5			*
6			* (c) Anton Komarev <[email protected]>
7			*
8			* For the full copyright and license information, please view the LICENSE
9			* file that was distributed with this source code.
10			*/
11
12			declare(strict_types=1);
13
14			namespace Cog\Laravel\Love\Console\Commands;
15
16			use Cog\Laravel\Love\ReactionType\Models\ReactionType;
17			use Illuminate\Console\Command;
18			use Illuminate\Support\Str;
19
20			final class ReactionTypeAdd extends Command
21			{
22			/**
23			* The name and signature of the console command.
24			*
25			* @var string
26			*/
27			protected $signature = 'love:reaction-type-add
28			{--default}
29			{name?}
30			{weight?}';
31
32			/**
33			* The console command description.
34			*
35			* @var string
36			*/
37			protected $description = 'Add Reaction Type to Laravel Love';
38
39			/**
40			* Execute the console command.
41			*
42			* @return int
43			*/
44			public function handle(): int
45			{
46			if ($this->option('default')) {
47			$this->createDefaultReactionTypes();
48
49			return 0;
50			}
51
52			$name = $this->resolveName();
53			$name = $this->sanitizeName($name);
54
55			if ($this->isNameInvalid($name)) {
56			$this->error(sprintf(
57			'Reaction type with name `%s` is invalid.',
58			$name
59			));
60
61			return 1;
62			}
63
64			if ($this->isReactionTypeNameExists($name)) {
65			$this->error(sprintf(
66			'Reaction type with name `%s` already exists.',
67			$name
68			));
69
70			return 1;
71			}
72
73			$this->createReactionType($name, $this->resolveWeight());
74
75			return 0;
76			}
77
78			private function createDefaultReactionTypes(): void
79			{
80			$types = [
81			[
82			'name' => 'Like',
83			'weight' => 1,
84			],
85			[
86			'name' => 'Dislike',
87			'weight' => -1,
88			],
89			];
90
91			foreach ($types as $type) {
92			if ($this->isReactionTypeNameExists($type['name'])) {
93			continue;
94			}
95
96			$this->createReactionType($type['name'], $type['weight']);
97			}
98			}
99
100			private function createReactionType(string $name, int $weight): void
101			{
102			ReactionType::query()->create([
103			'name' => $name,
104			'weight' => $weight,
105			]);
106
107			$this->line(sprintf(
108			'Reaction type with name `%s` and weight `%d` was added.',
109			$name,
110			$weight
111			));
112			}
113
114			private function resolveName(): string
115			{
116			return $this->argument('name')
			0 ignored issues – show Bug Best Practice introduced 2019-05-07 07:35 UTC by Report Bug Copy Issue Report The expression `return $this->argument('...?? $this->resolveName()` could return the type `null\|string[]` which is incompatible with the type-hinted return `string`. Consider adding an additional type-check to rule them out. Loading history...
117			?? $this->ask('How to name reaction type?')
118			?? $this->resolveName();
119			}
120
121			private function resolveWeight(): int
122			{
123			return intval($this->argument('weight') ?? $this->ask('What is the weight of this reaction type?'));
124			}
125
126			private function sanitizeName(string $name): string
127			{
128			$name = trim($name);
129			$name = Str::studly($name);
130
131			return $name;
132			}
133
134			private function isReactionTypeNameExists(string $name): bool
135			{
136			return ReactionType::query()->where('name', $name)->exists();
			0 ignored issues – show Bug Best Practice introduced 2019-05-07 00:30 UTC by Report Bug Copy Issue Report The expression `return Cog\Laravel\Love\...name', $name)->exists()` could return the type `Illuminate\Database\Eloquent\Builder` which is incompatible with the type-hinted return `boolean`. Consider adding an additional type-check to rule them out. Loading history...
137			}
138
139			private function isNameInvalid(string $name): bool
140			{
141			return preg_match('#^[A-Z][a-zA-Z0-9_]*$#', $name) === 0;
142			}
143			}
144

cybercog / laravel-love

Push — master ( 115cf1...6727e2 )

ReactionTypeAdd::createReactionType() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like