cybercog / laravel-eloquent-flag

src/Traits/Classic/HasKeptFlagHelpers.php

<?php

/*
 * This file is part of Laravel Eloquent Flag.
 *
 * (c) Anton Komarev <anton@komarev.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Flag\Traits\Classic;

use Cog\Flag\Scopes\Classic\KeptFlagScope;
use Illuminate\Database\Eloquent\Builder;
use Illuminate\Support\Facades\Date;

trait HasKeptFlagHelpers
{
    public function initializeHasKeptFlagHelpers(): void
    {
        $this->casts['is_kept'] = 'boolean';

The property casts does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function isKept(): bool
    {
        return $this->getAttributeValue('is_kept');

It seems like getAttributeValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function isNotKept(): bool
    {
        return !$this->isKept();
    }

    public function keep(): void
    {
        $this->setAttribute('is_kept', true);

It seems like setAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->fireModelEvent('kept', false);

It seems like fireModelEvent() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function undoKeep(): void
    {
        $this->setAttribute('is_kept', false);
        if (property_exists($this, 'setKeptOnUpdate')) {
            $this->setKeptOnUpdate = false;

The property setKeptOnUpdate does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

        }
        $this->save();

        $this->fireModelEvent('keptUndone', false);
    }

    /**
     * Get unkept models that are older than the given number of hours.
     *
     * @param \Illuminate\Database\Eloquent\Builder $builder
     * @param int $hours
     * @return \Illuminate\Database\Eloquent\Builder
     */
    public function scopeOnlyUnkeptOlderThanHours(Builder $builder, $hours)
    {
        return $builder
            ->withoutGlobalScope(KeptFlagScope::class)
            ->where('is_kept', 0)
            ->where(static::getCreatedAtColumn(), '<=', Date::now()->subHours($hours)->toDateTimeString());
    }
}