cybercog / laravel-eloquent-flag

src/Traits/Classic/HasApprovedAtHelpers.php

<?php

/*
 * This file is part of Laravel Eloquent Flag.
 *
 * (c) Anton Komarev <anton@komarev.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Flag\Traits\Classic;

use Illuminate\Support\Facades\Date;

trait HasApprovedAtHelpers
{
    public function initializeHasApprovedAtHelpers(): void
    {
        $this->casts['approved_at'] = 'datetime';

The property casts does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function isApproved(): bool
    {
        return !is_null($this->getAttributeValue('approved_at'));

It seems like getAttributeValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function isNotApproved(): bool
    {
        return !$this->isApproved();
    }

    public function approve(): void
    {
        $this->setAttribute('approved_at', Date::now());

It seems like setAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->fireModelEvent('approved', false);

It seems like fireModelEvent() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function undoApprove(): void
    {
        $this->setAttribute('approved_at', null);
        $this->save();

        $this->fireModelEvent('approvedUndone', false);
    }
}