cybercog / laravel-eloquent-flag

src/Traits/Classic/HasActiveFlagHelpers.php

<?php

/*
 * This file is part of Laravel Eloquent Flag.
 *
 * (c) Anton Komarev <anton@komarev.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Flag\Traits\Classic;

trait HasActiveFlagHelpers
{
    public function initializeHasActiveFlagHelpers(): void
    {
        $this->casts['is_active'] = 'boolean';

The property casts does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function isActivated(): bool
    {
        return $this->getAttributeValue('is_active');

It seems like getAttributeValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function isNotActivated(): bool
    {
        return !$this->isActivated();
    }

    public function activate(): void
    {
        $this->setAttribute('is_active', true);

It seems like setAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->fireModelEvent('activated', false);

It seems like fireModelEvent() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function undoActivate(): void
    {
        $this->setAttribute('is_active', false);
        $this->save();

        $this->fireModelEvent('activatedUndone', false);
    }
}