Cog\Flag\Traits\Classic\HasAcceptedAtHelpers

Complexity

Total Complexity

5

Size/Duplication

Total Lines	51
Duplicated Lines	0 %

Importance

Changes

0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	initializeHasAcceptedAtHelpers()	0	3	1
A	reject()	0	6	1
A	isRejected()	0	3	1
A	isAccepted()	0	3	1
A	accept()	0	6	1

<?php

/*
 * This file is part of Laravel Eloquent Flag.
 *
 * (c) Anton Komarev <a.komarev@cybercog.su>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Flag\Traits\Classic;

use Illuminate\Support\Facades\Date;

trait HasAcceptedAtHelpers
{
    public function initializeHasAcceptedAtHelpers(): void
    {
        $this->dates[] = 'accepted_at';

The property dates does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    /**
     * If entity is accepted.
     *
     * @return bool
     */
    public function isAccepted(): bool
    {
        return !is_null($this->getAttributeValue('accepted_at'));

It seems like getAttributeValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * If entity is rejected.
     *
     * @return bool
     */
    public function isRejected(): bool
    {
        return !$this->isAccepted();
    }

    /**
     * Mark entity as accepted.
     *
     * @return void
     */
    public function accept(): void
    {
        $this->setAttribute('accepted_at', Date::now());

It seems like setAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->fireModelEvent('accepted', false);

It seems like fireModelEvent() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    /**
     * Mark entity as rejected.
     *
     * @return void
     */
    public function reject(): void
    {
        $this->setAttribute('accepted_at', null);
        $this->save();

        $this->fireModelEvent('rejected', false);
    }
}