Cog\Flag\Traits\Classic\HasApprovedFlagHelpers

Complexity

Total Complexity

5

Size/Duplication

Total Lines	31
Duplicated Lines	0 %

Importance

Changes	1
Bugs	0	Features	0

5 Methods

Rating	Name	Duplication	Size	Complexity
A	initializeHasApprovedFlagHelpers()	0	3	1
A	approve()	0	6	1
A	isNotApproved()	0	3	1
A	isApproved()	0	3	1
A	undoApprove()	0	6	1

<?php

/*
 * This file is part of Laravel Eloquent Flag.
 *
 * (c) Anton Komarev <anton@komarev.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Flag\Traits\Classic;

trait HasApprovedFlagHelpers
{
    public function initializeHasApprovedFlagHelpers(): void
    {
        $this->casts['is_approved'] = 'boolean';

The property casts does not exist. Although not strictly required by PHP, it is generally a best practice to declare properties explicitly.

    }

    public function isApproved(): bool
    {
        return $this->getAttributeValue('is_approved');

It seems like getAttributeValue() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function isNotApproved(): bool
    {
        return !$this->isApproved();
    }

    public function approve(): void
    {
        $this->setAttribute('is_approved', true);

It seems like setAttribute() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->save();

It seems like save() must be provided by classes using this trait. How about adding it as abstract method to this trait?

        $this->fireModelEvent('approved', false);

It seems like fireModelEvent() must be provided by classes using this trait. How about adding it as abstract method to this trait?

    }

    public function undoApprove(): void
    {
        $this->setAttribute('is_approved', false);
        $this->save();

        $this->fireModelEvent('approvedUndone', false);
    }
}