cybercog / laravel-ban

src/Observers/BanObserver.php

<?php

/*
 * This file is part of Laravel Ban.
 *
 * (c) Anton Komarev <anton@komarev.com>
 *
 * For the full copyright and license information, please view the LICENSE
 * file that was distributed with this source code.
 */

declare(strict_types=1);

namespace Cog\Laravel\Ban\Observers;

use Cog\Contracts\Ban\Ban as BanContract;
use Cog\Laravel\Ban\Events\ModelWasBanned;
use Cog\Laravel\Ban\Events\ModelWasUnbanned;

class BanObserver
{
    /**
     * Handle the creating event for the Ban model.
     *
     * @param \Cog\Contracts\Ban\Ban $ban
     * @return void
     */
    public function creating(BanContract $ban): void
    {
        $bannedBy = auth()->user();
        if ($bannedBy && is_null($ban->created_by_type) && is_null($ban->created_by_id)) {

Accessing created_by_id on the interface Cog\Contracts\Ban\Ban suggest that you code against a concrete implementation. How about adding an instanceof check?

Accessing created_by_type on the interface Cog\Contracts\Ban\Ban suggest that you code against a concrete implementation. How about adding an instanceof check?

            $ban->fill([

The method fill() does not exist on Cog\Contracts\Ban\Ban. Since it exists in all sub-types, consider adding an abstract or default implementation to Cog\Contracts\Ban\Ban.

                'created_by_type' => $bannedBy->getMorphClass(),
                'created_by_id' => $bannedBy->getKey(),
            ]);
        }
    }

    /**
     * Handle the created event for the Ban model.
     *
     * @param \Cog\Contracts\Ban\Ban $ban
     * @return void
     */
    public function created(BanContract $ban): void
    {
        $bannable = $ban->bannable()->withBanned()->first();

The method bannable() does not exist on Cog\Contracts\Ban\Ban. Since it exists in all sub-types, consider adding an abstract or default implementation to Cog\Contracts\Ban\Ban.

        $bannable->setBannedFlag($ban->created_at)->save();

Accessing created_at on the interface Cog\Contracts\Ban\Ban suggest that you code against a concrete implementation. How about adding an instanceof check?

        event(new ModelWasBanned($bannable, $ban));
    }

    /**
     * Handle the deleted event for the Ban model.
     *
     * @param \Cog\Contracts\Ban\Ban $ban
     * @return void
     */
    public function deleted(BanContract $ban): void
    {
        $bannable = $ban->bannable()->withBanned()->first();
        if ($bannable->bans->count() === 0) {
            $bannable->unsetBannedFlag()->save();

            event(new ModelWasUnbanned($bannable));
        }
    }
}