Fluentd\Log\File::write()

Complexity

Conditions	24
Paths	> 20000

Size

Total Lines	104
Code Lines	61

Duplication

Lines	20
Ratio	19.23 %

Importance

Changes	1
Bugs	0	Features	0

<?php
	public static function write($level, $msg, $method = null)
	{
		$log_threshold = \Config::get('log_threshold');
		$config = \Config::get('log',array());

		if( isset($config['drivers']['file']['log_threshold']))
		{
			$log_threshold = $config['drivers']['file']['log_threshold'];
		}
		if ($level > $log_threshold)
		{
			return false;
		}
		$levels = array(
			1  => 'Error',
			2  => 'Warning',
			3  => 'Debug',
			4  => 'Info',
		);
		$level = isset($levels[$level]) ? $levels[$level] : $level;

		if (\Config::get('profiling'))
		{
			\Console::log($method.' - '.$msg);
		}

		$filepath = \Config::get('log_path').date('Y/m').'/';

		if ( ! is_dir($filepath))
		{
			$old = umask(0);

			mkdir($filepath, \Config::get('file.chmod.folders', 0777), true);
			umask($old);
		}

		$filename = $filepath.date('Y-m-d').'_log';

		$message  = '';

		if ( ! $exists = file_exists($filename))
		{
			$message .= "<"."?php defined('COREPATH') or exit('No direct script access allowed'); ?".">".PHP_EOL.PHP_EOL;
		}

		if ( ! $fp = @fopen($filename, 'a'))
		{
			return false;
		}

		$call = '';
		if ( ! empty($method))
		{
			$call .= $method;
		}else{
			$backtrace = debug_backtrace();
			$i=0;
			for(;$i<count($backtrace);$i++){

It seems like you are calling the size function count() as part of the test condition. You might want to compute the size beforehand, and not on each iteration.

This code seems to be duplicated across your project.

				$backtrace[$i]['object'] = null;
				$break = false;

				if(isset($backtrace[$i]['class'])){
					if(!strstr($backtrace[$i]['class'],__NAMESPACE__)
						and !strstr($backtrace[$i]['class'],'Fuel\Core\Log')) {

Using logical operators such as and instead of && is generally not recommended.

	
						//
						if($level === 'Error'){
							if ($level == 'Error') var_dump($backtrace);

var_dump($backtrace); looks like debug code. Are you sure you do not want to remove it? This might expose sensitive data.

						}
						$break = true;
					}
				}

				if($break){
					break;
				}
			}
			if(isset($backtrace[$i])){
				$call .= isset($backtrace[$i]['class'])    ? $backtrace[$i]['class']      : ' - ';
				$call .= isset($backtrace[$i]['type'])     ? $backtrace[$i]['type']       : ' - ';
				$call .= isset($backtrace[$i]['function']) ? $backtrace[$i]['function']   : ' - ';
				$call .= isset($backtrace[$i-1]['line'])   ? ':'.$backtrace[$i-1]['line'] : ' - ';
			}
		}

		$message .= $level.' '.(($level == 'info') ? ' -' : '-').' ';
		$message .= date(\Config::get('log_date_format'));
		$message .= ' - ' . 'ouid=' . parent::$opensocial_user_id;
		$message .= ' --> '.(empty($call) ? '' : $call.' - ').$msg.PHP_EOL;

		flock($fp, LOCK_EX);
		fwrite($fp, $message);
		flock($fp, LOCK_UN);
		fclose($fp);

		if ( ! $exists)
		{
			$old = umask(0);
			@chmod($filename, \Config::get('file.chmod.files', 0666));

It seems like you do not handle an error condition here. This can introduce security issues, and is generally not recommended.

			umask($old);
		}

		return true;
	}
}