Session::getSession() - Code Metrics - cvweiss/projectbase - Measure and Improve Code Quality continuously with Scrutinizer

Session::getSession() A
last analyzed 2016-08-04 14:47 UTC

↳ Parent: Session

Complexity

Conditions	2
Paths	2

Size

Total Lines	14
Code Lines	9

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	14
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	9
nc	2
nop	1

<?php

namespace cvweiss\projectbase;

class Session
{
    private static $session = null;
    private static $segment = null;

    public static function getSession($segmentName = __NAMESPACE__)
// Bad
class Router
{
    public function generate($path)
    {
        return $_SERVER['HOST'].$path;
    }
}

// Better
class Router
{
    private $host;

    public function __construct($host)
    {
        $this->host = $host;
    }

    public function generate($path)
    {
        return $this->host.$path;
    }
}

class Controller
{
    public function myAction(Request $request)
    {
        // Instead of
        $page = isset($_GET['page']) ? intval($_GET['page']) : 1;

        // Better (assuming you use the Symfony2 request)
        $page = $request->query->get('page', 1);
    }
}
    {
        if (self::$segment === null) {
            $sessionTimeout = (int) Config::getInstance()->get("session_timeout", 3600);

            session_set_save_handler(new RedisSessionHandler(), true);
            $sessionFactory = new \Aura\Session\SessionFactory;

            self::$session = $sessionFactory->newInstance($_COOKIE);
            self::$session->setCookieParams(['lifetime' => $sessionTimeout, 'secure' => true, 'httponly' => true]);
            self::$segment = self::$session->getSegment($segmentName);
        }
        return self::$segment;
    }

    public static function destroy()
    {
        self::$session->destroy();
    }

    public static function commit()
    {
        self::$session->commit();
    }
}


1			<?php
2
3			namespace cvweiss\projectbase;
4
5			class Session
6			{
7			private static $session = null;
8			private static $segment = null;
9
10			public static function getSession($segmentName = __NAMESPACE__)
			0 ignored issues – show Coding Style introduced 2016-07-06 14:27 UTC by Report Bug Copy Issue Report `getSession` uses the super-global variable `$_COOKIE` which is generally not recommended. Instead of super-globals, we recommend to explicitly inject the dependencies of your class. This makes your code less dependent on global state and it becomes generally more testable: // Bad class Router { public function generate($path) { return $_SERVER['HOST'].$path; } } // Better class Router { private $host; public function __construct($host) { $this->host = $host; } public function generate($path) { return $this->host.$path; } } class Controller { public function myAction(Request $request) { // Instead of $page = isset($_GET['page']) ? intval($_GET['page']) : 1; // Better (assuming you use the Symfony2 request) $page = $request->query->get('page', 1); } } Loading history...
11			{
12			if (self::$segment === null) {
13			$sessionTimeout = (int) Config::getInstance()->get("session_timeout", 3600);
14
15			session_set_save_handler(new RedisSessionHandler(), true);
16			$sessionFactory = new \Aura\Session\SessionFactory;
17
18			self::$session = $sessionFactory->newInstance($_COOKIE);
19			self::$session->setCookieParams(['lifetime' => $sessionTimeout, 'secure' => true, 'httponly' => true]);
20			self::$segment = self::$session->getSegment($segmentName);
21			}
22			return self::$segment;
23			}
24
25			public static function destroy()
26			{
27			self::$session->destroy();
28			}
29
30			public static function commit()
31			{
32			self::$session->commit();
33			}
34			}
35

cvweiss / projectbase

Session::getSession() A last analyzed 2016-08-04 14:47 UTC

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like

Session::getSession() A
last analyzed 2016-08-04 14:47 UTC