AliasSwitchIndexCommand::argumentsAreValid() - Code Metrics - Inspection of "add alias-switch-index console command" - cviebrock/laravel-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#98)

unknown

created 2020-09-28 21:08 UTC

AliasSwitchIndexCommand::argumentsAreValid() B

↳ Parent: AliasSwitchIndexCommand

Complexity

Conditions	10
Paths	4

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	40
rs	7.6666
c	0
b	0
f	0
cc	10
nc	4
nop	3

How to fix Complexity

<?php

declare(strict_types=1);

namespace Cviebrock\LaravelElasticsearch\Console\Command;

use Elasticsearch\Client;
use Illuminate\Console\Command;
use Throwable;

final class AliasSwitchIndexCommand extends Command
{
    /**
     * @var string
     */
    protected $signature = 'laravel-elasticsearch:utils:alias-switch-index
                            {new-index-name : The new index name}
                            {old-index-name : The old index name}
                            {alias-name : The alias name}';

    /**
     * @var Client
     */
    private $client;

    public function __construct(
        Client $client
    ) {
        $this->client = $client;

        parent::__construct();
    }

    public function handle(): int
    {
        $newIndexName = $this->argument('new-index-name');
        $oldIndexName = $this->argument('old-index-name');
        $aliasName = $this->argument('alias-name');

        if (!$this->argumentsAreValid(
            $newIndexName,
            $oldIndexName,
            $aliasName
        )) {
            return self::FAILURE;
        }

        if (!$this->client->indices()->exists([
            'index' => $newIndexName,
        ])) {
            $this->output->writeln(
                sprintf(
                    '<error>Index %s cannot be linked to alias because doesn\'t exists.</error>',
                    $newIndexName
                )
            );

            return self::FAILURE;
        }

        try {
            $this->client->indices()->putAlias([
                'index' => $newIndexName,
                'name' => $aliasName,
            ]);

            $this->client->indices()->deleteAlias([
                'index' => $oldIndexName,
                'name' => $aliasName,
            ]);
        } catch (Throwable $exception) {
            $this->output->writeln(
                sprintf(
                    '<error>Error switching indexes - new index: %s, old index: %s in alias %s, exception message: %s.</error>',
                    $newIndexName,
                    $oldIndexName,
                    $aliasName,
                    $exception->getMessage()
                )
            );

            return self::FAILURE;
        }

        $this->output->writeln(
            sprintf(
                '<info>New index %s linked and old index %s removed from alias %s.</info>',
                $newIndexName,
                $oldIndexName,
                $aliasName
            )
        );

        return self::SUCCESS;
    }

    private function argumentsAreValid(
        $newIndexName,
        $oldIndexName,
        $aliasName
    ): bool {
        if ($newIndexName === null ||
            !is_string($newIndexName) ||
            mb_strlen($newIndexName) === 0
        ) {
            $this->output->writeln(
                '<error>Argument new-index-name must be a non empty string.</error>'
            );

            return false;
        }

        if ($oldIndexName === null ||
            !is_string($oldIndexName) ||
            mb_strlen($oldIndexName) === 0
        ) {
            $this->output->writeln(
                '<error>Argument old-index-name must be a non empty string.</error>'
            );

            return false;
        }

        if ($aliasName === null ||
            !is_string($aliasName) ||
            mb_strlen($aliasName) === 0
        ) {
            $this->output->writeln(
                '<error>Argument alias-name must be a non empty string.</error>'
            );

            return false;
        }

        return true;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cviebrock\LaravelElasticsearch\Console\Command;
6
7			use Elasticsearch\Client;
8			use Illuminate\Console\Command;
9			use Throwable;
10
11			final class AliasSwitchIndexCommand extends Command
12			{
13			/**
14			* @var string
15			*/
16			protected $signature = 'laravel-elasticsearch:utils:alias-switch-index
17			{new-index-name : The new index name}
18			{old-index-name : The old index name}
19			{alias-name : The alias name}';
20
21			/**
22			* @var Client
23			*/
24			private $client;
25
26			public function __construct(
27			Client $client
28			) {
29			$this->client = $client;
30
31			parent::__construct();
32			}
33
34			public function handle(): int
35			{
36			$newIndexName = $this->argument('new-index-name');
37			$oldIndexName = $this->argument('old-index-name');
38			$aliasName = $this->argument('alias-name');
39
40			if (!$this->argumentsAreValid(
41			$newIndexName,
42			$oldIndexName,
43			$aliasName
44			)) {
45			return self::FAILURE;
46			}
47
48			if (!$this->client->indices()->exists([
49			'index' => $newIndexName,
50			])) {
51			$this->output->writeln(
52			sprintf(
53			'<error>Index %s cannot be linked to alias because doesn\'t exists.</error>',
54			$newIndexName
55			)
56			);
57
58			return self::FAILURE;
59			}
60
61			try {
62			$this->client->indices()->putAlias([
63			'index' => $newIndexName,
64			'name' => $aliasName,
65			]);
66
67			$this->client->indices()->deleteAlias([
68			'index' => $oldIndexName,
69			'name' => $aliasName,
70			]);
71			} catch (Throwable $exception) {
72			$this->output->writeln(
73			sprintf(
74			'<error>Error switching indexes - new index: %s, old index: %s in alias %s, exception message: %s.</error>',
75			$newIndexName,
76			$oldIndexName,
77			$aliasName,
78			$exception->getMessage()
79			)
80			);
81
82			return self::FAILURE;
83			}
84
85			$this->output->writeln(
86			sprintf(
87			'<info>New index %s linked and old index %s removed from alias %s.</info>',
88			$newIndexName,
89			$oldIndexName,
90			$aliasName
91			)
92			);
93
94			return self::SUCCESS;
95			}
96
97			private function argumentsAreValid(
98			$newIndexName,
99			$oldIndexName,
100			$aliasName
101			): bool {
102			if ($newIndexName === null \|\|
103			!is_string($newIndexName) \|\|
104			mb_strlen($newIndexName) === 0
105			) {
106			$this->output->writeln(
107			'<error>Argument new-index-name must be a non empty string.</error>'
108			);
109
110			return false;
111			}
112
113			if ($oldIndexName === null \|\|
114			!is_string($oldIndexName) \|\|
115			mb_strlen($oldIndexName) === 0
116			) {
117			$this->output->writeln(
118			'<error>Argument old-index-name must be a non empty string.</error>'
119			);
120
121			return false;
122			}
123
124			if ($aliasName === null \|\|
125			!is_string($aliasName) \|\|
126			mb_strlen($aliasName) === 0
127			) {
128			$this->output->writeln(
129			'<error>Argument alias-name must be a non empty string.</error>'
130			);
131
132			return false;
133			}
134
135			return true;
136			}
137			}
138

cviebrock / laravel-elasticsearch

Pull Request — master (#98)

AliasSwitchIndexCommand::argumentsAreValid() B

Complexity

Size

Duplication

Importance

How to fix Complexity

Long Method

Duplication Side-by-Side

Filter issues like