CreateIndexCommand::argumentIsValid() - Code Metrics - Inspection of "add index-create console command" - cviebrock/laravel-elasticsearch - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#94)

unknown

created 2020-09-28 20:52 UTC

CreateIndexCommand::argumentIsValid() A

↳ Parent: CreateIndexCommand

Complexity

Conditions	4
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	4
nc	2
nop	1

<?php

declare(strict_types=1);

namespace Cviebrock\LaravelElasticsearch\Console\Command;

use Elasticsearch\Client;
use Illuminate\Console\Command;
use Throwable;

final class CreateIndexCommand extends Command
{
    /**
     * @var string
     */
    protected $signature = 'laravel-elasticsearch:utils:index-create
                            {index-name : The index name}';

    /**
     * @var Client
     */
    private $client;

    public function __construct(
        Client $client
    ) {
        $this->client = $client;

        parent::__construct();
    }

    public function handle(): int
    {
        $indexName = $this->argument('index-name');

        if (!$this->argumentIsValid($indexName)) {
            return self::FAILURE;
        }

        if ($this->client->indices()->exists([
            'index' => $indexName,
        ])) {
            $this->output->writeln(
                sprintf(
                    '<error>Index %s already exists and cannot be created.</error>',
                    $indexName
                )
            );

            return self::FAILURE;
        }

        try {
            $this->client->indices()->create([
                'index' => $indexName,
            ]);
        } catch (Throwable $exception) {
            $this->output->writeln(
                sprintf(
                    '<error>Error creating index %s, exception message: %s.</error>',
                    $indexName,
                    $exception->getMessage()
                )
            );

            return self::FAILURE;
        }

        $this->output->writeln(
            sprintf(
                '<info>Index %s created.</info>',
                $indexName
            )
        );

        return self::SUCCESS;
    }

    private function argumentIsValid($indexName): bool
    {
        if ($indexName === null ||
            !is_string($indexName) ||
            mb_strlen($indexName) === 0
        ) {
            $this->output->writeln(
                '<error>Argument index-name must be a non empty string.</error>'
            );

            return false;
        }

        return true;
    }
}


1			<?php
2
3			declare(strict_types=1);
4
5			namespace Cviebrock\LaravelElasticsearch\Console\Command;
6
7			use Elasticsearch\Client;
8			use Illuminate\Console\Command;
9			use Throwable;
10
11			final class CreateIndexCommand extends Command
12			{
13			/**
14			* @var string
15			*/
16			protected $signature = 'laravel-elasticsearch:utils:index-create
17			{index-name : The index name}';
18
19			/**
20			* @var Client
21			*/
22			private $client;
23
24			public function __construct(
25			Client $client
26			) {
27			$this->client = $client;
28
29			parent::__construct();
30			}
31
32			public function handle(): int
33			{
34			$indexName = $this->argument('index-name');
35
36			if (!$this->argumentIsValid($indexName)) {
37			return self::FAILURE;
38			}
39
40			if ($this->client->indices()->exists([
41			'index' => $indexName,
42			])) {
43			$this->output->writeln(
44			sprintf(
45			'<error>Index %s already exists and cannot be created.</error>',
46			$indexName
47			)
48			);
49
50			return self::FAILURE;
51			}
52
53			try {
54			$this->client->indices()->create([
55			'index' => $indexName,
56			]);
57			} catch (Throwable $exception) {
58			$this->output->writeln(
59			sprintf(
60			'<error>Error creating index %s, exception message: %s.</error>',
61			$indexName,
62			$exception->getMessage()
63			)
64			);
65
66			return self::FAILURE;
67			}
68
69			$this->output->writeln(
70			sprintf(
71			'<info>Index %s created.</info>',
72			$indexName
73			)
74			);
75
76			return self::SUCCESS;
77			}
78
79			private function argumentIsValid($indexName): bool
80			{
81			if ($indexName === null \|\|
82			!is_string($indexName) \|\|
83			mb_strlen($indexName) === 0
84			) {
85			$this->output->writeln(
86			'<error>Argument index-name must be a non empty string.</error>'
87			);
88
89			return false;
90			}
91
92			return true;
93			}
94			}
95

cviebrock / laravel-elasticsearch

Pull Request — master (#94)

CreateIndexCommand::argumentIsValid() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like