GenerateTraitCommand::execute() - Code Metrics - Inspection of "Refactored the command into multiple atomic method..." - curtiskelsey/doctrine-repo-helper - Measure and Improve Code Quality continuously with Scrutinizer

Passed
Push — master ( 463a83...b762ea )

by Curtis
created 2019-01-12 17:50 UTC
GenerateTraitCommand::execute() A

↳ Parent: GenerateTraitCommand
Complexity

Conditions	3
Paths	3
Size

Total Lines	73
Code Lines	44
Duplication

Lines	0
Ratio	0 %
Importance

Changes
Metric	Value
eloc	44
dl	0
loc	73
rs	9.216
c	0
b	0
f	0
cc	3
nc	3
nop	2
How to fix Long Method

<?php
/**
 * @noinspection PhpUndefinedFieldInspection
 */

namespace DoctrineRepoHelper\Command;

use Doctrine\Common\Persistence\Mapping\ClassMetadata;
use Doctrine\ORM\EntityManager;
use Doctrine\ORM\EntityRepository;
use Symfony\Component\Console\Command\Command;
use Symfony\Component\Console\Input\InputInterface;
use Symfony\Component\Console\Input\InputOption;
use Symfony\Component\Console\Output\OutputInterface;
use Zend\Code\Generator\DocBlockGenerator;
use Zend\Code\Generator\Exception\InvalidArgumentException;
use Zend\Code\Generator\FileGenerator;
use Zend\Code\Generator\MethodGenerator;
use Zend\Code\Generator\TraitGenerator;

/**
 * Class GenerateTraitCommand
 * @package DoctrineRepoHelper\Command
 */
class GenerateTraitCommand extends Command
{
    /** @var EntityManager */
    protected $entityManager;

    /**
     * GenerateTraitCommand constructor.
     * @param EntityManager $entityManager
     */
    public function __construct(EntityManager $entityManager)
    {
        $this->entityManager = $entityManager;
        parent::__construct();
    }

    protected function configure()
    {
        parent::configure();

        $this
            ->setName('orm:generate-repository-trait')
            ->setDescription('Generate a repository helper trait')
            ->setHelp(
                <<<EOT
The generate repository trait command creates a trait that will allow your development environment to autocomplete
custom repository methods
EOT
            )
            ->addOption(
                'namespace',
                null,
                InputOption::VALUE_OPTIONAL,
                'Declares the namespace'
            )
            ->addOption(
                'destination',
                null,
                InputOption::VALUE_OPTIONAL,
                'Path to create the trait in',
                getcwd()
            )
            ->addOption(
                'classname',
                null,
                InputOption::VALUE_OPTIONAL,
                'Classname of the trait',
                'CustomRepositoryAwareTrait'
            )
            ->addOption(
                'em-getter',
                null,
                InputOption::VALUE_OPTIONAL,
                'Name of the property or method classes that use the trait will have to access the EntityManager',
                'getObjectManager()'
            );
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return int|void|null
     * @throws \ReflectionException
     */
    public function execute(InputInterface $input, OutputInterface $output)
    {
        $traitName = $input->getOption('classname');
        $outputFileName = sprintf(
            '%s/%s.php',
            $input->getOption('destination'),
            /** @scrutinizer ignore-type */ $input->getOption('destination'),
            $traitName
        );

        $metaDataEntries = $this->entityManager->getMetadataFactory()->getAllMetadata();
        $trait = $this->generateTrait(
            $input,
            $output
        );

        foreach ($metaDataEntries as $metaData) {
            $method = $this->generateMethod(
                $input,
                $output,
                $metaData
            );

            try {
                $trait->addMethodFromGenerator($method);

            } catch (InvalidArgumentException $e) {
                $output->writeln(
                    sprintf(
                        'Method "%s" already exists in this class',
                        $method->getName()
                    )
                );

                $reflection = new \ReflectionClass($metaData->getName());

                $method->setName(
                    sprintf(
                        'get%sRepository%s',
                        $reflection->getShortName(),
                        str_replace('.', '', uniqid('', true))
                    )
                );

                $trait->addMethodFromGenerator($method);

                $output->writeln(
                    sprintf(
                        'Refactored the method to "%s". Please refactor to a usable name you will remember',
                        $method->getName()
                    )
                );
                $output->writeln('');
            }
        }

        $file = new FileGenerator();
        $file->setClass($trait);

        file_put_contents(
            $outputFileName,
            $file->generate()
        );

        $output->writeln('');

        $output->writeln(
            sprintf(
                'Trait created in "%s"',
                $outputFileName
            )
        );

        $output->writeln('');
    }

    /**
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return TraitGenerator
     */
    private function generateTrait(InputInterface $input, OutputInterface $output): TraitGenerator
    private function generateTrait(InputInterface $input, /** @scrutinizer ignore-unused */ OutputInterface $output): TraitGenerator
    {
        $entityManagerGetter = $input->getOption('em-getter');
        $traitName = $input->getOption('classname');
        $traitNameSpace = $input->getOption('namespace');

        $trait = new TraitGenerator(
            $traitName,
            /** @scrutinizer ignore-type */ $traitName,
            $traitNameSpace
            /** @scrutinizer ignore-type */ $traitNameSpace
        );

        $trait
            ->addUse(EntityManager::class)
            ->addUse(EntityRepository::class);

        $docBlock = DocBlockGenerator::fromArray(
            [
                'shortDescription' => $traitName,
                'longDescription' => 'Provides helper methods for accessing custom repositories. Provides type hints to allow for custom method auto-completion within IDEs',
                'tags' => [
                    [
                        'name' => 'package',
                        'description' => $traitNameSpace
                    ],
                    [
                        'name' => 'method',
                        'description' => sprintf(
                            'EntityManager %s',
                            $entityManagerGetter
                            /** @scrutinizer ignore-type */ $entityManagerGetter
                        )
                    ]
                ]
            ]
        );

        $trait->setDocBlock($docBlock);
        return $trait;
    }

    /**
     * @param ClassMetadata $metaData
     * @param InputInterface $input
     * @param OutputInterface $output
     * @return MethodGenerator
     * @throws \ReflectionException
     */
    private function generateMethod(InputInterface $input, OutputInterface $output, ClassMetadata $metaData): MethodGenerator
    private function generateMethod(InputInterface $input, /** @scrutinizer ignore-unused */ OutputInterface $output, ClassMetadata $metaData): MethodGenerator
    {
        $entityManagerGetter = $input->getOption('em-getter');

        $reflection = new \ReflectionClass($metaData->getName());
        $repoReflection = null;

        if ($metaData->customRepositoryClassName) {

            $repoReflection = new \ReflectionClass($metaData->customRepositoryClassName);
        }

        $method = new MethodGenerator(
            sprintf(
                'get%sRepository',
                $reflection->getShortName()
            ),
            [],
            MethodGenerator::FLAG_PUBLIC,
            sprintf(
                'return $this->%s->getRepository(\\%s::class);',
                $entityManagerGetter,
                /** @scrutinizer ignore-type */ $entityManagerGetter,
                $reflection->getName()
            )
        );


        $docBlock = DocBlockGenerator::fromArray(
            [
                'tags' => [
                    [
                        'name' => 'return',
                        'description' => sprintf(
                            '%s%s',
                            'EntityRepository',
                            $repoReflection ? '|\\' . $repoReflection->getName() : ''
                        )
                    ]
                ]
            ]
        );

        $method->setDocBlock($docBlock);
        return $method;
    }
}
curtiskelsey / doctrine-repo-helper

Push — master ( 463a83...b762ea )

GenerateTraitCommand::execute() A

Complexity

Size

Duplication

Importance

How to fix Long Method

Long Method

Duplication Side-by-Side

Filter issues like
