Conditions | 30 |
Paths | 108 |
Total Lines | 95 |
Code Lines | 76 |
Lines | 0 |
Ratio | 0 % |
Changes | 0 |
Small methods make your code easier to understand, in particular if combined with a good name. Besides, if your method is small, finding a good name is usually much easier.
For example, if you find yourself adding comments to a method's body, this is usually a good sign to extract the commented part to a new method, and use the comment as a starting point when coming up with a good name for this new method.
Commonly applied refactorings include:
If many parameters/temporary variables are present:
1 | <?php |
||
120 | private function buildFactoryData(ClassMetadata $metaData): array |
||
121 | { |
||
122 | $data = []; |
||
123 | |||
124 | foreach ($metaData->fieldMappings as $fieldMapping) { |
||
125 | switch ($fieldMapping['type']) { |
||
126 | case 'smallint': |
||
127 | case 'integer': |
||
128 | case 'bigint': |
||
129 | $data[] = sprintf( |
||
130 | " '%s' => random_int(0, 65000),\n", |
||
131 | $fieldMapping['fieldName'] |
||
132 | ); |
||
133 | break; |
||
134 | case 'decimal': |
||
135 | case 'float': |
||
136 | $data[] = sprintf( |
||
137 | " '%s' => Faker::randomFloat(2),\n", |
||
138 | $fieldMapping['fieldName'] |
||
139 | ); |
||
140 | break; |
||
141 | case 'string': |
||
142 | $data[] = sprintf( |
||
143 | " '%s' => Faker::sentence(),\n", |
||
144 | $fieldMapping['fieldName'] |
||
145 | ); |
||
146 | break; |
||
147 | case 'text': |
||
148 | $data[] = sprintf( |
||
149 | " '%s' => Faker::paragraph(),\n", |
||
150 | $fieldMapping['fieldName'] |
||
151 | ); |
||
152 | break; |
||
153 | case 'guid': |
||
154 | $data[] = sprintf( |
||
155 | " '%s' => uniqid('', true)", |
||
156 | $fieldMapping['fieldName'] |
||
157 | ); |
||
158 | break; |
||
159 | case 'binary': |
||
160 | case 'blob': |
||
161 | break; |
||
162 | case 'boolean': |
||
163 | $data[] = sprintf( |
||
164 | " '%s' => (bool)random_int(0, 1),\n", |
||
165 | $fieldMapping['fieldName'] |
||
166 | ); |
||
167 | break; |
||
168 | case 'date': |
||
169 | case 'date_immutable': |
||
170 | case 'datetime': |
||
171 | case 'datetime_immutable': |
||
172 | case 'datetimetz': |
||
173 | case 'datetimetz_immutable': |
||
174 | case 'time': |
||
175 | case 'time_immutable': |
||
176 | $data[] = sprintf( |
||
177 | " '%s' => Faker::dateTime(),\n", |
||
178 | $fieldMapping['fieldName'] |
||
179 | ); |
||
180 | break; |
||
181 | case 'dateinterval': |
||
182 | case 'array': |
||
183 | case 'simple_array': |
||
184 | case 'json': |
||
185 | case 'json_array': |
||
186 | case 'object': |
||
187 | break; |
||
188 | default: |
||
189 | $data[] = sprintf( |
||
190 | " '%s' => Faker::word(),\n", |
||
191 | $fieldMapping['fieldName'] |
||
192 | ); |
||
193 | break; |
||
194 | } |
||
195 | } |
||
196 | |||
197 | foreach ($metaData->associationMappings as $associationMapping) { |
||
198 | switch ($associationMapping['type']) { |
||
199 | case 1: |
||
200 | $data[] = sprintf( |
||
201 | " '%s' => 'entity|' . \\%s::class", |
||
202 | $associationMapping['fieldName'], |
||
203 | $associationMapping['targetEntity'] |
||
204 | ); |
||
205 | break; |
||
206 | case 2: |
||
207 | // TODO many to one? |
||
208 | break; |
||
209 | default: |
||
210 | break; |
||
211 | } |
||
212 | } |
||
213 | |||
214 | return $data; |
||
215 | } |
||
243 | } |