Issues in MediaObjectCreated.php (master) - Issues in master - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Issues (85)

Security Analysis no request data

Cross-Site Scripting

Cross-Site Scripting enables an attacker to inject code into the response of a web-request that is viewed by other users. It can for example be used to bypass access controls, or even to take over other users' accounts.

File Exposure

File Exposure allows an attacker to gain access to local files that he should not be able to access. These files can for example include database credentials, or other configuration files.

File Manipulation

File Manipulation enables an attacker to write custom data to files. This potentially leads to injection of arbitrary code on the server.

Object Injection

Object Injection enables an attacker to inject an object into PHP code, and can lead to arbitrary code execution, file exposure, or file manipulation attacks.

Code Injection

Code Injection enables an attacker to execute arbitrary code on the server.

Response Splitting

Response Splitting can be used to send arbitrary responses.

File Inclusion

File Inclusion enables an attacker to inject custom files into PHP's file loading mechanism, either explicitly passed to include, or for example via PHP's auto-loading mechanism.

Command Injection

Command Injection enables an attacker to inject a shell command that is execute with the privileges of the web-server. This can be used to expose sensitive data, or gain access of your server.

SQL Injection

SQL Injection enables an attacker to execute arbitrary SQL code on your database server gaining access to user data, or manipulating user data.

XPath Injection

XPath Injection enables an attacker to modify the parts of XML document that are read. If that XML document is for example used for authentication, this can lead to further vulnerabilities similar to SQL Injection.

LDAP Injection

LDAP Injection enables an attacker to inject LDAP statements potentially granting permission to run unauthorized queries, or modify content inside the LDAP tree.

Header Injection

Other Vulnerability

This category comprises other attack vectors such as manipulating the PHP runtime, loading custom extensions, freezing the runtime, or similar.

Regex Injection

Regex Injection enables an attacker to execute arbitrary code in your PHP process.

XML Injection

XML Injection enables an attacker to read files on your local filesystem including configuration files, or can be abused to freeze your web-server process.

Variable Injection

Variable Injection enables an attacker to overwrite program variables with custom data, and can lead to further vulnerabilities.

Unfortunately, the security analysis is currently not available for your project. If you are a non-commercial open-source project, please contact support to gain access.

src/Media/Events/MediaObjectCreated.php (4 issues)

Labels

Severity

Upgrade to new PHP Analysis Engine

These results are based on our legacy PHP analysis, consider migrating to our new PHP analysis engine instead. Learn more

<?php

namespace CultuurNet\UDB3\Media\Events;

use Broadway\Serializer\SerializableInterface;
use CultuurNet\UDB3\Language;
use CultuurNet\UDB3\Media\Properties\MIMEType;
use ValueObjects\Identity\UUID;
use ValueObjects\StringLiteral\StringLiteral;
use ValueObjects\Web\Url;

final class MediaObjectCreated implements SerializableInterface
{
    /**
     * @var UUID
     */
    protected $mediaObjectId;

    /**
     * @var MIMEType
     */
    protected $mimeType;

    /**
     * @var String
     */
    protected $description;

    /**
     * @var String
     */
    protected $copyrightHolder;

    /**
     * @var Url
     */
    protected $sourceLocation;

    /**
     * @var Language
     */
    protected $language;

    public function __construct(

        UUID $id,
        MIMEType $fileType,
        StringLiteral $description,
        StringLiteral $copyrightHolder,
        Url $sourceLocation,
        Language $language
    ) {
        $this->mediaObjectId = $id;
        $this->mimeType = $fileType;
        $this->description = $description;

        $this->copyrightHolder = $copyrightHolder;

        $this->sourceLocation = $sourceLocation;
        $this->language = $language;
    }

    public function getLanguage(): Language
    {
        return $this->language;
    }

    public function getMediaObjectId(): UUID
    {
        return $this->mediaObjectId;
    }

    public function getDescription(): StringLiteral
    {
        return $this->description;
    }

    public function getCopyrightHolder(): StringLiteral
    {
        return $this->copyrightHolder;
    }

    public function getMimeType(): MIMEType
    {
        return $this->mimeType;
    }

    public function getSourceLocation(): Url
    {
        return $this->sourceLocation;
    }

    public function serialize(): array
    {
        return array(
            'media_object_id' => $this->getMediaObjectId()->toNative(),
            'mime_type' => $this->getMimeType()->toNative(),
            'description' => $this->getDescription()->toNative(),
            'copyright_holder' => $this->getCopyrightHolder()->toNative(),
            'source_location' => (string) $this->getSourceLocation(),
            'language' => (string) $this->getLanguage(),
        );
    }

    public static function deserialize(array $data): MediaObjectCreated

    {
        return new self(
            new UUID($data['media_object_id']),
            new MIMEType($data['mime_type']),
            new StringLiteral($data['description']),
            new StringLiteral($data['copyright_holder']),
            Url::fromNative($data['source_location']),
            array_key_exists('language', $data) ? new Language($data['language']) : new Language('nl')
        );
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Media\Events;
4
5		use Broadway\Serializer\SerializableInterface;
6		use CultuurNet\UDB3\Language;
7		use CultuurNet\UDB3\Media\Properties\MIMEType;
8		use ValueObjects\Identity\UUID;
9		use ValueObjects\StringLiteral\StringLiteral;
10		use ValueObjects\Web\Url;
11
12		final class MediaObjectCreated implements SerializableInterface
13		{
14		/**
15		* @var UUID
16		*/
17		protected $mediaObjectId;
18
19		/**
20		* @var MIMEType
21		*/
22		protected $mimeType;
23
24		/**
25		* @var String
26		*/
27		protected $description;
28
29		/**
30		* @var String
31		*/
32		protected $copyrightHolder;
33
34		/**
35		* @var Url
36		*/
37		protected $sourceLocation;
38
39		/**
40		* @var Language
41		*/
42		protected $language;
43
44	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2020-09-11 15:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
45		UUID $id,
46		MIMEType $fileType,
47		StringLiteral $description,
48		StringLiteral $copyrightHolder,
49		Url $sourceLocation,
50		Language $language
51		) {
52		$this->mediaObjectId = $id;
53		$this->mimeType = $fileType;
54		$this->description = $description;
		0 ignored issues – show Documentation Bug introduced 2017-01-12 12:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$description` of type `object<ValueObjects\StringLiteral\StringLiteral>` is incompatible with the declared type `string` of property `$description`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
55		$this->copyrightHolder = $copyrightHolder;
		0 ignored issues – show Documentation Bug introduced 2017-01-12 12:53 UTC by Report Bug Copy Issue Report Show Similar Issues like this It seems like `$copyrightHolder` of type `object<ValueObjects\StringLiteral\StringLiteral>` is incompatible with the declared type `string` of property `$copyrightHolder`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
56		$this->sourceLocation = $sourceLocation;
57		$this->language = $language;
58		}
59
60		public function getLanguage(): Language
61		{
62		return $this->language;
63		}
64
65		public function getMediaObjectId(): UUID
66		{
67		return $this->mediaObjectId;
68		}
69
70		public function getDescription(): StringLiteral
71		{
72		return $this->description;
73		}
74
75		public function getCopyrightHolder(): StringLiteral
76		{
77		return $this->copyrightHolder;
78		}
79
80		public function getMimeType(): MIMEType
81		{
82		return $this->mimeType;
83		}
84
85		public function getSourceLocation(): Url
86		{
87		return $this->sourceLocation;
88		}
89
90		public function serialize(): array
91		{
92		return array(
93		'media_object_id' => $this->getMediaObjectId()->toNative(),
94		'mime_type' => $this->getMimeType()->toNative(),
95		'description' => $this->getDescription()->toNative(),
96		'copyright_holder' => $this->getCopyrightHolder()->toNative(),
97		'source_location' => (string) $this->getSourceLocation(),
98		'language' => (string) $this->getLanguage(),
99		);
100		}
101
102	View Code Duplication	public static function deserialize(array $data): MediaObjectCreated
		0 ignored issues – show Duplication introduced 2020-09-11 15:59 UTC by Report Bug Copy Issue Report Show Similar Issues like this This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
103		{
104		return new self(
105		new UUID($data['media_object_id']),
106		new MIMEType($data['mime_type']),
107		new StringLiteral($data['description']),
108		new StringLiteral($data['copyright_holder']),
109		Url::fromNative($data['source_location']),
110		array_key_exists('language', $data) ? new Language($data['language']) : new Language('nl')
111		);
112		}
113		}
114

cultuurnet / udb3-php

Issues (85)

Security Analysis no request data

src/Media/Events/MediaObjectCreated.php (4 issues)

Labels

Severity

Introduced By

Upgrade to new PHP Analysis Engine

Duplication Side-by-Side

Filter issues like