CultuurNet\UDB3\LabelCollection

Complexity

Total Complexity

20

Size/Duplication

Total Lines	192
Duplicated Lines	11.46 %

Coupling/Cohesion

Components	1
Dependencies	2

Importance

Changes

0

12 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	15	2
A	with()	0	10	2
A	without()	11	11	1
A	count()	0	4	1
A	contains()	11	11	1
A	asArray()	0	4	1
A	merge()	0	18	3
A	intersect()	0	11	1
A	filter()	0	6	1
A	fromStrings()	0	14	3
A	fromKeywords()	0	14	3
A	toStrings()	0	11	1

<?php

namespace CultuurNet\UDB3;

use CultureFeed_Cdb_Data_Keyword;

class LabelCollection implements \Countable
{
    /**
     * @var Label[]
     */
    private $labels;

    /**
     * @param Label[] $labels
     */
    public function __construct(array $labels = [])
    {
        array_walk(
            $labels,
            function ($item) {
                if (!$item instanceof Label) {
                    throw new \InvalidArgumentException(
                        'Argument $labels should only contain members of type Label'
                    );
                }
            }
        );

        $this->labels = array_values($labels);

It seems like array_values($labels) of type array<integer,?> is incompatible with the declared type array<integer,object<CultuurNet\UDB3\Label>> of property $labels.

    }

    /**
     * @param Label $label
     * @return LabelCollection
     */
    public function with(Label $label)
    {
        if (!$this->contains($label)) {
            $labels = array_merge($this->labels, [$label]);
        } else {
            $labels = $this->labels;
        }

        return new LabelCollection($labels);
    }

    /**
     * @param Label $label
     * @return LabelCollection
     */
    public function without(Label $label)

This method seems to be duplicated in your project.

    {
        $labels = array_filter(
            $this->labels,
            function (Label $existingLabel) use ($label) {
                return !$existingLabel->equals($label);
            }
        );

        return new LabelCollection($labels);
    }

    /**
     * @inheritdoc
     */
    public function count()
    {
        return count($this->labels);
    }

    /**
     * @param Label $label
     * @return bool
     */
    public function contains(Label $label)

This method seems to be duplicated in your project.

    {
        $equalLabels = array_filter(
            $this->labels,
            function (Label $existingLabel) use ($label) {
                return $label->equals($existingLabel);
            }
        );

        return !empty($equalLabels);
    }

    /**
     * @return Label[]
     */
    public function asArray()
    {
        return $this->labels;
    }

    /**
     * @param LabelCollection $labelCollectionToMerge
     * @return LabelCollection
     */
    public function merge(LabelCollection $labelCollectionToMerge)
    {
        $mergedLabels = [];

        // Keep labels from the original collection that are not in the
        // collection to merge.
        foreach ($this->labels as $label) {
            if (!$labelCollectionToMerge->contains($label)) {
                $mergedLabels[] = $label;
            }
        }

        // Add all labels from the collection to merge.
        $add = $labelCollectionToMerge->asArray();
        $mergedLabels = array_merge($mergedLabels, $add);

        return new LabelCollection($mergedLabels);
    }

    /**
     * @param LabelCollection $labelCollection
     * @return LabelCollection
     */
    public function intersect(LabelCollection $labelCollection)
    {
        $intersectLabels = array_filter(
            $this->labels,
            function ($label) use ($labelCollection) {
                return $labelCollection->contains($label);
            }
        );

        return new LabelCollection($intersectLabels);
    }

    /**
     * @param callable $filterFunction
     * @return LabelCollection
     */
    public function filter(callable $filterFunction)
    {
        return new LabelCollection(
            array_filter($this->labels, $filterFunction)
        );
    }

    /**
     * @param string[] $strings
     * @return LabelCollection
     */
    public static function fromStrings(array $strings)
    {
        $labelCollection = new LabelCollection();

        foreach ($strings as $string) {
            try {
                $label = new Label($string);
                $labelCollection = $labelCollection->with($label);
            } catch (\InvalidArgumentException $exception) {

Consider adding a comment why this CATCH block is empty.

            }
        }

        return $labelCollection;
    }

    /**
     * @param CultureFeed_Cdb_Data_Keyword[] $keywords
     * @return LabelCollection
     */
    public static function fromKeywords($keywords)
    {
        $labelCollection = new LabelCollection();

        foreach ($keywords as $keyword) {
            try {
                $label = new Label($keyword->getValue(), $keyword->isVisible());
                $labelCollection = $labelCollection->with($label);
            } catch (\InvalidArgumentException $exception) {

Consider adding a comment why this CATCH block is empty.

            }
        }

        return $labelCollection;
    }

    /**
     * @return string[]
     */
    public function toStrings()
    {
        $labels = array_map(
            function (Label $label) {
                return (string) $label;
            },
            $this->labels
        );

        return $labels;
    }
}