Completed
Pull Request — master (#384)
by Kristof
03:47
created
src/Offer/Events/AbstractLabelEvent.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -45,7 +45,7 @@
 block discarded – undo
45 45
 
46 46
     /**
47 47
      * @param array $data
48
-     * @return mixed The object instance
48
+     * @return AbstractLabelEvent The object instance
49 49
      */
50 50
     public static function deserialize(array $data)
51 51
     {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -38,7 +38,7 @@
 block discarded – undo
38 38
     public function serialize()
39 39
     {
40 40
         return parent::serialize() + array(
41
-            'label' => (string) $this->label,
41
+            'label' => (string)$this->label,
42 42
             'visibility' => $this->label->isVisible(),
43 43
         );
44 44
     }
Please login to merge, or discard this patch.
src/Event/ExternalEventService.php 2 patches
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -4,11 +4,9 @@
 block discarded – undo
4 4
 
5 5
 use Exception;
6 6
 use GuzzleHttp\Psr7\Request;
7
-use GuzzleHttp\Psr7\Response;
8 7
 use GuzzleHttp\Psr7\Uri;
9 8
 use Http\Client\Exception as HttpException;
10 9
 use Http\Client\HttpClient;
11
-use Psr\Http\Message\UriInterface;
12 10
 
13 11
 class ExternalEventService implements EventServiceInterface
14 12
 {
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -41,7 +41,7 @@
 block discarded – undo
41 41
             throw new EventNotFoundException();
42 42
         }
43 43
 
44
-        return (string) $response->getBody();
44
+        return (string)$response->getBody();
45 45
     }
46 46
 
47 47
     public function eventsOrganizedByOrganizer($organizerId)
Please login to merge, or discard this patch.
src/Event/LocalEventService.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -36,7 +36,7 @@
 block discarded – undo
36 36
      * @param string $id
37 37
      *   A string uniquely identifying an event.
38 38
      *
39
-     * @return array
39
+     * @return string
40 40
      *   An event array.
41 41
      *
42 42
      * @throws EventNotFoundException if an event can not be found for the given id
Please login to merge, or discard this patch.
src/Variations/VariationDecoratedEventService.php 2 patches
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -9,7 +9,6 @@
 block discarded – undo
9 9
 use CultuurNet\UDB3\Variations\Model\Properties\Url;
10 10
 use CultuurNet\UDB3\Variations\ReadModel\Search\Criteria;
11 11
 use CultuurNet\UDB3\Variations\ReadModel\Search\RepositoryInterface;
12
-use Doctrine\Instantiator\Exception\InvalidArgumentException;
13 12
 use ValueObjects\Exception\InvalidNativeArgumentException;
14 13
 
15 14
 class VariationDecoratedEventService implements EventServiceInterface
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -68,7 +68,7 @@
 block discarded – undo
68 68
         // If the id is not a valid url we assume it points to the local installation and generate one ourselves.
69 69
         try {
70 70
             $validUrl = \ValueObjects\Web\Url::fromNative($id);
71
-            $url = new Url((string) $validUrl);
71
+            $url = new Url((string)$validUrl);
72 72
         } catch (InvalidNativeArgumentException $e) {
73 73
             $url = new Url(
74 74
                 $this->eventIriGenerator->iri($id)
Please login to merge, or discard this patch.
src/EventSourcing/DBAL/UniqueConstraintException.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
      */
12 12
     public function __construct($uuid, $unique)
13 13
     {
14
-        $message = 'Not unique: uuid = ' . $uuid . ', unique value = ' . $unique;
14
+        $message = 'Not unique: uuid = '.$uuid.', unique value = '.$unique;
15 15
         parent::__construct($message);
16 16
     }
17 17
 }
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/Repository/SimilaritySorter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
      */
14 14
     public function sort(array &$entities, StringLiteral $value)
15 15
     {
16
-        return usort($entities, function ($entity1, $entity2) use ($value) {
16
+        return usort($entities, function($entity1, $entity2) use ($value) {
17 17
             /** @var Entity $entity1 */
18 18
             $weight1 = $this->getWeight($entity1, $value);
19 19
 
Please login to merge, or discard this patch.
src/SearchAPI2/ResultSetPullParser.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -79,7 +79,7 @@  discard block
 block discarded – undo
79 79
         $items = new OfferIdentifierCollection();
80 80
         $totalItems = $cdbId = $elementName = $offerType = $resultXmlString = null;
81 81
 
82
-        $resetCurrentResultValues = function () use (&$cdbId, &$elementName, &$offerType, &$resultXmlString) {
82
+        $resetCurrentResultValues = function() use (&$cdbId, &$elementName, &$offerType, &$resultXmlString) {
83 83
             $cdbId = null;
84 84
             $elementName = self::CDBXML_TYPE_UNKNOWN;
85 85
             $offerType = self::OFFER_TYPE_UNKNOWN;
@@ -93,13 +93,13 @@  discard block
 block discarded – undo
93 93
 
94 94
         while ($r->read()) {
95 95
             if ($this->xmlNodeIsNumberOfRecordsTag($r)) {
96
-                $totalItems = new Integer((int) $r->readString());
96
+                $totalItems = new Integer((int)$r->readString());
97 97
             }
98 98
 
99 99
             if ($this->xmlNodeIsResultOpeningTag($r)) {
100 100
                 $resultXmlString = $r->readOuterXml();
101 101
                 $cdbId = $r->getAttribute('cdbid');
102
-                $elementName = 'cdbxml.' . $r->localName;
102
+                $elementName = 'cdbxml.'.$r->localName;
103 103
 
104 104
                 if ($elementName == self::CDBXML_TYPE_EVENT) {
105 105
                     $offerType = self::OFFER_TYPE_EVENT;
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/Projector.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -142,7 +142,7 @@
 block discarded – undo
142 142
     {
143 143
         $uuid = null;
144 144
 
145
-        $name = new StringLiteral((string) $labelEvent->getLabel());
145
+        $name = new StringLiteral((string)$labelEvent->getLabel());
146 146
 
147 147
         $entity = $this->readRepository->getByName($name);
148 148
         if ($entity !== null) {
Please login to merge, or discard this patch.
src/Role/ReadModel/Search/Doctrine/DBALRepository.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -81,7 +81,7 @@  discard block
 block discarded – undo
81 81
 
82 82
         if (!empty($query)) {
83 83
             $q->where($expr->like('name', ':role_name'));
84
-            $q->setParameter('role_name', '%' . $query . '%');
84
+            $q->setParameter('role_name', '%'.$query.'%');
85 85
         }
86 86
 
87 87
         $results = $q->execute()->fetchAll(\PDO::FETCH_ASSOC);
@@ -96,7 +96,7 @@  discard block
 block discarded – undo
96 96
 
97 97
         if (!empty($query)) {
98 98
             $q->where($expr->like('name', ':role_name'));
99
-            $q->setParameter('role_name', '%' . $query . '%');
99
+            $q->setParameter('role_name', '%'.$query.'%');
100 100
         }
101 101
 
102 102
         $total = $q->execute()->fetchColumn();
Please login to merge, or discard this patch.