Completed
Pull Request — master (#414)
by Jonas
02:48
created
src/Address/Address.php 1 patch
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -81,10 +81,10 @@
 block discarded – undo
81 81
     public function serialize()
82 82
     {
83 83
         return [
84
-          'streetAddress' => $this->streetAddress->toNative(),
85
-          'postalCode' => $this->postalCode->toNative(),
86
-          'addressLocality' => $this->locality->toNative(),
87
-          'addressCountry' => $this->countryCode,
84
+            'streetAddress' => $this->streetAddress->toNative(),
85
+            'postalCode' => $this->postalCode->toNative(),
86
+            'addressLocality' => $this->locality->toNative(),
87
+            'addressCountry' => $this->countryCode,
88 88
         ];
89 89
     }
90 90
 
Please login to merge, or discard this patch.
src/Calendar.php 2 patches
Indentation   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -84,7 +84,7 @@  discard block
 block discarded – undo
84 84
         );
85 85
 
86 86
         $calendar = [
87
-          'type' => $this->type,
87
+            'type' => $this->type,
88 88
         ];
89 89
 
90 90
         empty($this->startDate) ?: $calendar['startDate'] = $this->startDate->format(DateTime::ATOM);
@@ -167,9 +167,9 @@  discard block
 block discarded – undo
167 167
             $jsonLd['subEvent'] = array();
168 168
             foreach ($timestamps as $timestamp) {
169 169
                 $jsonLd['subEvent'][] = array(
170
-                  '@type' => 'Event',
171
-                  'startDate' => $timestamp->getStartDate()->format(DateTime::ATOM),
172
-                  'endDate' => $timestamp->getEndDate()->format(DateTime::ATOM),
170
+                    '@type' => 'Event',
171
+                    'startDate' => $timestamp->getStartDate()->format(DateTime::ATOM),
172
+                    'endDate' => $timestamp->getEndDate()->format(DateTime::ATOM),
173 173
                 );
174 174
             }
175 175
         }
Please login to merge, or discard this patch.
Spacing   +7 added lines, -7 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@  discard block
 block discarded – undo
62 62
         array $openingHours = array()
63 63
     ) {
64 64
         if (($type->is(CalendarType::MULTIPLE()) || $type->is(CalendarType::SINGLE())) && empty($startDate)) {
65
-            throw new \UnexpectedValueException('Start date can not be empty for calendar type: ' . $type . '.');
65
+            throw new \UnexpectedValueException('Start date can not be empty for calendar type: '.$type.'.');
66 66
         }
67 67
 
68 68
         if ($type->is(CalendarType::PERIODIC()) && (empty($startDate) || empty($endDate))) {
@@ -102,14 +102,14 @@  discard block
 block discarded – undo
102 102
     public function serialize()
103 103
     {
104 104
         $serializedTimestamps = array_map(
105
-            function (Timestamp $timestamp) {
105
+            function(Timestamp $timestamp) {
106 106
                 return $timestamp->serialize();
107 107
             },
108 108
             $this->timestamps
109 109
         );
110 110
 
111 111
         $serializedOpeningHours = array_map(
112
-            function (OpeningHour $openingHour) {
112
+            function(OpeningHour $openingHour) {
113 113
                 return $openingHour->serialize();
114 114
             },
115 115
             $this->openingHours
@@ -137,13 +137,13 @@  discard block
 block discarded – undo
137 137
             !empty($data['startDate']) ? self::deserializeDateTime($data['startDate']) : null,
138 138
             !empty($data['endDate']) ? self::deserializeDateTime($data['endDate']) : null,
139 139
             !empty($data['timestamps']) ? array_map(
140
-                function ($timestamp) {
140
+                function($timestamp) {
141 141
                     return Timestamp::deserialize($timestamp);
142 142
                 },
143 143
                 $data['timestamps']
144 144
             ) : [],
145 145
             !empty($data['openingHours']) ? array_map(
146
-                function ($openingHour) {
146
+                function($openingHour) {
147 147
                     return OpeningHour::deserialize($openingHour);
148 148
                 },
149 149
                 $data['openingHours']
@@ -271,7 +271,7 @@  discard block
 block discarded – undo
271 271
 
272 272
         if ($calendar instanceof CalendarWithSubEvents) {
273 273
             $timestamps = array_map(
274
-                function (DateRange $dateRange) {
274
+                function(DateRange $dateRange) {
275 275
                     return Timestamp::fromUdb3ModelDateRange($dateRange);
276 276
                 },
277 277
                 $calendar->getSubEvents()->toArray()
@@ -280,7 +280,7 @@  discard block
 block discarded – undo
280 280
 
281 281
         if ($calendar instanceof CalendarWithOpeningHours) {
282 282
             $openingHours = array_map(
283
-                function (Udb3ModelOpeningHour $openingHour) {
283
+                function(Udb3ModelOpeningHour $openingHour) {
284 284
                     return OpeningHour::fromUdb3ModelOpeningHour($openingHour);
285 285
                 },
286 286
                 $calendar->getOpeningHours()->toArray()
Please login to merge, or discard this patch.
src/PriceInfo/Price.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -21,7 +21,7 @@
 block discarded – undo
21 21
         }
22 22
 
23 23
         $precision = 0;
24
-        return new Price((int) round($value * 100, $precision));
24
+        return new Price((int)round($value * 100, $precision));
25 25
     }
26 26
 
27 27
     /**
Please login to merge, or discard this patch.
src/Offer/Security/SearchQueryFactory.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -46,9 +46,9 @@
 block discarded – undo
46 46
         StringLiteral $constraint,
47 47
         StringLiteral $offerId
48 48
     ) {
49
-        $constraintStr = '(' . strtolower($constraint->toNative()) . ')';
49
+        $constraintStr = '('.strtolower($constraint->toNative()).')';
50 50
         $offerIdStr = $offerId->toNative();
51 51
 
52
-        return '(' . $constraintStr . ' AND cdbid:' . $offerIdStr . ')';
52
+        return '('.$constraintStr.' AND cdbid:'.$offerIdStr.')';
53 53
     }
54 54
 }
Please login to merge, or discard this patch.
src/Organizer/ReadModel/JSONLD/CdbXMLImporter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -62,7 +62,7 @@
 block discarded – undo
62 62
 
63 63
                 if ($address) {
64 64
                     $address = new Address(
65
-                        new Street($address->getStreet() . ' ' . $address->getHouseNumber()),
65
+                        new Street($address->getStreet().' '.$address->getHouseNumber()),
66 66
                         new PostalCode($address->getZip()),
67 67
                         new Locality($address->getCity()),
68 68
                         Country::fromNative($address->getCountry())
Please login to merge, or discard this patch.
src/Cdb/ExternalId/ArrayMappingService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
     public function getCdbId($externalId)
26 26
     {
27 27
         if (isset($this->externalIdMapping[$externalId])) {
28
-            return (string) $this->externalIdMapping[$externalId];
28
+            return (string)$this->externalIdMapping[$externalId];
29 29
         } else {
30 30
             return null;
31 31
         }
Please login to merge, or discard this patch.
src/LabelCollection.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
     {
17 17
         array_walk(
18 18
             $labels,
19
-            function ($item) {
19
+            function($item) {
20 20
                 if (!$item instanceof Label) {
21 21
                     throw new \InvalidArgumentException(
22 22
                         'Argument $labels should only contain members of type Label'
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
     {
52 52
         $labels = array_filter(
53 53
             $this->labels,
54
-            function (Label $existingLabel) use ($label) {
54
+            function(Label $existingLabel) use ($label) {
55 55
                 return !$existingLabel->equals($label);
56 56
             }
57 57
         );
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     {
76 76
         $equalLabels = array_filter(
77 77
             $this->labels,
78
-            function (Label $existingLabel) use ($label) {
78
+            function(Label $existingLabel) use ($label) {
79 79
                 return $label->equals($existingLabel);
80 80
             }
81 81
         );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     {
123 123
         $intersectLabels = array_filter(
124 124
             $this->labels,
125
-            function ($label) use ($labelCollection) {
125
+            function($label) use ($labelCollection) {
126 126
                 return $labelCollection->contains($label);
127 127
             }
128 128
         );
@@ -155,8 +155,8 @@  discard block
 block discarded – undo
155 155
     public function toStrings()
156 156
     {
157 157
         $labels = array_map(
158
-            function (Label $label) {
159
-                return (string) $label;
158
+            function(Label $label) {
159
+                return (string)$label;
160 160
             },
161 161
             $this->labels
162 162
         );
Please login to merge, or discard this patch.
src/Offer/DefaultOfferEditingService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@
 block discarded – undo
92 92
         $this->guardId($id);
93 93
 
94 94
         $this->labelService->createLabelAggregateIfNew(
95
-            new LabelName((string) $label),
95
+            new LabelName((string)$label),
96 96
             $label->isVisible()
97 97
         );
98 98
 
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/ItemVisibilityProjector.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -85,14 +85,14 @@  discard block
 block discarded – undo
85 85
         foreach ($items as $item) {
86 86
             $offerLd = $item->getBody();
87 87
 
88
-            $addToArray = isset($offerLd->{$addTo}) ? (array) $offerLd->{$addTo} : [];
88
+            $addToArray = isset($offerLd->{$addTo}) ? (array)$offerLd->{$addTo} : [];
89 89
 
90 90
             $addToArray[] = $labelName->toNative();
91 91
             $offerLd->{$addTo} = array_values(array_unique($addToArray));
92 92
 
93 93
             if (isset($offerLd->{$removeFrom})) {
94 94
                 $offerLd->{$removeFrom} = array_values(
95
-                    array_diff((array) $offerLd->{$removeFrom}, [$labelName])
95
+                    array_diff((array)$offerLd->{$removeFrom}, [$labelName])
96 96
                 );
97 97
 
98 98
                 if (count($offerLd->{$removeFrom}) === 0) {
@@ -121,8 +121,8 @@  discard block
 block discarded – undo
121 121
                 }
122 122
             } catch (DocumentGoneException $exception) {
123 123
                 $this->logger->alert(
124
-                    'Can not update visibility of label: "'. $labelRelation->getLabelName() . '"'
125
-                    . ' for the relation with id: "' . $labelRelation->getRelationId() . '"'
124
+                    'Can not update visibility of label: "'.$labelRelation->getLabelName().'"'
125
+                    . ' for the relation with id: "'.$labelRelation->getRelationId().'"'
126 126
                     . ' because the document could not be retrieved.'
127 127
                 );
128 128
             }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 
107 107
     /**
108 108
      * @param LabelName $labelName
109
-     * @return \CultuurNet\UDB3\ReadModel\JsonDocument[]|\Generator
109
+     * @return \Generator
110 110
      */
111 111
     private function getRelatedItems(LabelName $labelName)
112 112
     {
Please login to merge, or discard this patch.