Projector::applyLabelsImported() - Code Metrics - Inspection of "III-2563 Importer logic for labels." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#349)

by Luc

created 2018-03-23 13:58 UTC

Projector::applyLabelsImported() A

↳ Parent: Projector

Complexity

Conditions	2
Paths	2

Size

Total Lines	12
Code Lines	7

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	12
rs	9.4285
c	0
b	0
f	0
cc	2
eloc	7
nc	2
nop	2

<?php

namespace CultuurNet\UDB3\Label\ReadModels\Relations;

use Broadway\Domain\Metadata;
use CultuurNet\UDB3\Cdb\ActorItemFactory;
use CultuurNet\UDB3\Cdb\EventItemFactory;
use CultuurNet\UDB3\Event\Events\EventImportedFromUDB2;
use CultuurNet\UDB3\Event\Events\EventUpdatedFromUDB2;
use CultuurNet\UDB3\Label\LabelEventRelationTypeResolverInterface;
use CultuurNet\UDB3\Label\ReadModels\AbstractProjector;
use CultuurNet\UDB3\Label\ReadModels\Relations\Repository\LabelRelation;
use CultuurNet\UDB3\Label\ReadModels\Relations\Repository\ReadRepositoryInterface;
use CultuurNet\UDB3\Label\ReadModels\Relations\Repository\WriteRepositoryInterface;
use CultuurNet\UDB3\Label\ValueObjects\LabelName;
use CultuurNet\UDB3\Label\ValueObjects\RelationType;
use CultuurNet\UDB3\LabelCollection;
use CultuurNet\UDB3\LabelEventInterface;
use CultuurNet\UDB3\LabelsImportedEventInterface;
use CultuurNet\UDB3\Model\ValueObject\Taxonomy\Label\Label;
use CultuurNet\UDB3\Organizer\Events\OrganizerImportedFromUDB2;
use CultuurNet\UDB3\Organizer\Events\OrganizerUpdatedFromUDB2;
use CultuurNet\UDB3\Place\Events\PlaceImportedFromUDB2;
use CultuurNet\UDB3\Place\Events\PlaceUpdatedFromUDB2;
use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
use ValueObjects\StringLiteral\StringLiteral;

class Projector extends AbstractProjector
{
    /**
     * @var WriteRepositoryInterface
     */
    private $writeRepository;
    
    /**
     * @var ReadRepositoryInterface
     */
    private $readRepository;

    /**
     * @var LabelEventRelationTypeResolverInterface
     */
    private $offerTypeResolver;

    /**
     * Projector constructor.
     * @param WriteRepositoryInterface $writeRepository
     * @param ReadRepositoryInterface $readRepository
     * @param LabelEventRelationTypeResolverInterface $labelEventOfferTypeResolver
     */
    public function __construct(
        WriteRepositoryInterface $writeRepository,
        ReadRepositoryInterface $readRepository,
        LabelEventRelationTypeResolverInterface $labelEventOfferTypeResolver
    ) {
        $this->writeRepository = $writeRepository;
        $this->readRepository = $readRepository;
        $this->offerTypeResolver = $labelEventOfferTypeResolver;

    }

    /**
     * @inheritdoc
     */
    public function applyLabelAdded(LabelEventInterface $labelAdded, Metadata $metadata)

    {
        $LabelRelation = $this->createLabelRelation($labelAdded);

        try {
            if (!is_null($LabelRelation)) {
                $this->writeRepository->save(
                    $LabelRelation->getLabelName(),
                    $LabelRelation->getRelationType(),
                    $LabelRelation->getRelationId(),
                    false
                );
            }
        } catch (UniqueConstraintViolationException $exception) {
            // By design to catch unique exception.
        }
    }

    /**
     * @inheritdoc
     */
    public function applyLabelRemoved(LabelEventInterface $labelRemoved, Metadata $metadata)

    {
        $labelRelation = $this->createLabelRelation($labelRemoved);

        if (!is_null($labelRelation)) {
            $this->writeRepository->deleteByLabelNameAndRelationId(
                $labelRelation->getLabelName(),
                $labelRelation->getRelationId()
            );
        }
    }

    /**
     * @inheritdoc
     */
    public function applyLabelsImported(LabelsImportedEventInterface $labelsImported, Metadata $metadata)
    {
        foreach ($labelsImported->getLabels()->toArray() as $label) {
            /** @var Label $label */
            $this->writeRepository->save(
                new LabelName($label->getName()->toString()),
                $this->offerTypeResolver->getRelationTypeForImport($labelsImported),
                new StringLiteral($labelsImported->getItemId()),
                true
            );
        }
    }

    /**
     * @param EventImportedFromUDB2 $eventImportedFromUDB2
     */
    public function applyEventImportedFromUDB2(
        EventImportedFromUDB2 $eventImportedFromUDB2
    ) {
        $event = EventItemFactory::createEventFromCdbXml(
            $eventImportedFromUDB2->getCdbXmlNamespaceUri(),
            $eventImportedFromUDB2->getCdbXml()
        );

        $this->updateLabelRelationFromCdbItem($event, RelationType::EVENT());
    }

    /**
     * @param PlaceImportedFromUDB2 $placeImportedFromUDB2
     */
    public function applyPlaceImportedFromUDB2(
        PlaceImportedFromUDB2 $placeImportedFromUDB2
    ) {
        $place = ActorItemFactory::createActorFromCdbXml(
            $placeImportedFromUDB2->getCdbXmlNamespaceUri(),
            $placeImportedFromUDB2->getCdbXml()
        );

        $this->updateLabelRelationFromCdbItem($place, RelationType::PLACE());
    }

    /**
     * @param OrganizerImportedFromUDB2 $organizerImportedFromUDB2
     */
    public function applyOrganizerImportedFromUDB2(
        OrganizerImportedFromUDB2 $organizerImportedFromUDB2
    ) {
        $organizer = ActorItemFactory::createActorFromCdbXml(
            $organizerImportedFromUDB2->getCdbXmlNamespaceUri(),
            $organizerImportedFromUDB2->getCdbXml()
        );

        $this->updateLabelRelationFromCdbItem($organizer, RelationType::ORGANIZER());
    }

    /**
     * @param EventUpdatedFromUDB2 $eventUpdatedFromUDB2
     */
    public function applyEventUpdatedFromUDB2(
        EventUpdatedFromUDB2 $eventUpdatedFromUDB2
    ) {
        $event = EventItemFactory::createEventFromCdbXml(
            $eventUpdatedFromUDB2->getCdbXmlNamespaceUri(),
            $eventUpdatedFromUDB2->getCdbXml()
        );

        $this->updateLabelRelationFromCdbItem($event, RelationType::EVENT());
    }

    /**
     * @param PlaceUpdatedFromUDB2 $placeUpdatedFromUDB2
     */
    public function applyPlaceUpdatedFromUDB2(
        PlaceUpdatedFromUDB2 $placeUpdatedFromUDB2
    ) {
        $place = ActorItemFactory::createActorFromCdbXml(
            $placeUpdatedFromUDB2->getCdbXmlNamespaceUri(),
            $placeUpdatedFromUDB2->getCdbXml()
        );

        $this->updateLabelRelationFromCdbItem($place, RelationType::PLACE());
    }

    /**
     * @param OrganizerUpdatedFromUDB2 $organizerUpdatedFromUDB2
     */
    public function applyOrganizerUpdatedFromUDB2(
        OrganizerUpdatedFromUDB2 $organizerUpdatedFromUDB2
    ) {
        $organizer = ActorItemFactory::createActorFromCdbXml(
            $organizerUpdatedFromUDB2->getCdbXmlNamespaceUri(),
            $organizerUpdatedFromUDB2->getCdbXml()
        );

        $this->updateLabelRelationFromCdbItem($organizer, RelationType::ORGANIZER());
    }

    /**
     * @param \CultureFeed_Cdb_Item_Base $cdbItem
     * @param RelationType $relationType
     */
    private function updateLabelRelationFromCdbItem(
        \CultureFeed_Cdb_Item_Base $cdbItem,
        RelationType $relationType
    ) {
        $relationId = new StringLiteral($cdbItem->getCdbId());

        // Never delete the UDB3 labels on an update.
        $this->writeRepository->deleteImportedByRelationId($relationId);

        $keywords = $cdbItem->getKeywords();
        $labelCollection = LabelCollection::fromStrings($keywords);

        // Calculate the UDB2 imported labels.
        $udb3Labels = array_map(
            function (LabelRelation $labelRelation) {
                return $labelRelation->getLabelName()->toNative();
            },
            $this->readRepository->getLabelRelationsForItem($relationId)
        );
        $udb2Labels = array_udiff(
            $labelCollection->asArray(),
            $udb3Labels,
            'strcasecmp'
        );

        // Only save the UDB2 labels, because the UDB3 labels are still present.
        foreach ($udb2Labels as $label) {
            $this->writeRepository->save(
                new LabelName((string) $label),
                $relationType,
                $relationId,
                true
            );
        }
    }

    /**
     * @param LabelEventInterface $labelEvent
     * @return LabelRelation
     */
    private function createLabelRelation(LabelEventInterface $labelEvent)
    {
        $labelRelation = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

        $labelName = new LabelName((string) $labelEvent->getLabel());
        $relationType = $this->offerTypeResolver->getRelationType($labelEvent);
        $relationId = new StringLiteral($labelEvent->getItemId());

        $labelRelation = new LabelRelation(
            $labelName,
            $relationType,
            $relationId,
            false
        );

        return $labelRelation;
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Label\ReadModels\Relations;
4
5		use Broadway\Domain\Metadata;
6		use CultuurNet\UDB3\Cdb\ActorItemFactory;
7		use CultuurNet\UDB3\Cdb\EventItemFactory;
8		use CultuurNet\UDB3\Event\Events\EventImportedFromUDB2;
9		use CultuurNet\UDB3\Event\Events\EventUpdatedFromUDB2;
10		use CultuurNet\UDB3\Label\LabelEventRelationTypeResolverInterface;
11		use CultuurNet\UDB3\Label\ReadModels\AbstractProjector;
12		use CultuurNet\UDB3\Label\ReadModels\Relations\Repository\LabelRelation;
13		use CultuurNet\UDB3\Label\ReadModels\Relations\Repository\ReadRepositoryInterface;
14		use CultuurNet\UDB3\Label\ReadModels\Relations\Repository\WriteRepositoryInterface;
15		use CultuurNet\UDB3\Label\ValueObjects\LabelName;
16		use CultuurNet\UDB3\Label\ValueObjects\RelationType;
17		use CultuurNet\UDB3\LabelCollection;
18		use CultuurNet\UDB3\LabelEventInterface;
19		use CultuurNet\UDB3\LabelsImportedEventInterface;
20		use CultuurNet\UDB3\Model\ValueObject\Taxonomy\Label\Label;
21		use CultuurNet\UDB3\Organizer\Events\OrganizerImportedFromUDB2;
22		use CultuurNet\UDB3\Organizer\Events\OrganizerUpdatedFromUDB2;
23		use CultuurNet\UDB3\Place\Events\PlaceImportedFromUDB2;
24		use CultuurNet\UDB3\Place\Events\PlaceUpdatedFromUDB2;
25		use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
26		use ValueObjects\StringLiteral\StringLiteral;
27
28		class Projector extends AbstractProjector
29		{
30		/**
31		* @var WriteRepositoryInterface
32		*/
33		private $writeRepository;
34
35		/**
36		* @var ReadRepositoryInterface
37		*/
38		private $readRepository;
39
40		/**
41		* @var LabelEventRelationTypeResolverInterface
42		*/
43		private $offerTypeResolver;
44
45		/**
46		* Projector constructor.
47		* @param WriteRepositoryInterface $writeRepository
48		* @param ReadRepositoryInterface $readRepository
49		* @param LabelEventRelationTypeResolverInterface $labelEventOfferTypeResolver
50		*/
51		public function __construct(
52		WriteRepositoryInterface $writeRepository,
53		ReadRepositoryInterface $readRepository,
54		LabelEventRelationTypeResolverInterface $labelEventOfferTypeResolver
55		) {
56		$this->writeRepository = $writeRepository;
57		$this->readRepository = $readRepository;
58		$this->offerTypeResolver = $labelEventOfferTypeResolver;
59
60		}
61
62		/**
63		* @inheritdoc
64		*/
65	View Code Duplication	public function applyLabelAdded(LabelEventInterface $labelAdded, Metadata $metadata)
		0 ignored issues – show Duplication introduced 2017-07-31 14:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
66		{
67		$LabelRelation = $this->createLabelRelation($labelAdded);
68
69		try {
70		if (!is_null($LabelRelation)) {
71		$this->writeRepository->save(
72		$LabelRelation->getLabelName(),
73		$LabelRelation->getRelationType(),
74		$LabelRelation->getRelationId(),
75		false
76		);
77		}
78		} catch (UniqueConstraintViolationException $exception) {
79		// By design to catch unique exception.
80		}
81		}
82
83		/**
84		* @inheritdoc
85		*/
86	View Code Duplication	public function applyLabelRemoved(LabelEventInterface $labelRemoved, Metadata $metadata)
		0 ignored issues – show Duplication introduced 2017-07-31 14:18 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
87		{
88		$labelRelation = $this->createLabelRelation($labelRemoved);
89
90		if (!is_null($labelRelation)) {
91		$this->writeRepository->deleteByLabelNameAndRelationId(
92		$labelRelation->getLabelName(),
93		$labelRelation->getRelationId()
94		);
95		}
96		}
97
98		/**
99		* @inheritdoc
100		*/
101		public function applyLabelsImported(LabelsImportedEventInterface $labelsImported, Metadata $metadata)
102		{
103		foreach ($labelsImported->getLabels()->toArray() as $label) {
104		/** @var Label $label */
105		$this->writeRepository->save(
106		new LabelName($label->getName()->toString()),
107		$this->offerTypeResolver->getRelationTypeForImport($labelsImported),
108		new StringLiteral($labelsImported->getItemId()),
109		true
110		);
111		}
112		}
113
114		/**
115		* @param EventImportedFromUDB2 $eventImportedFromUDB2
116		*/
117		public function applyEventImportedFromUDB2(
118		EventImportedFromUDB2 $eventImportedFromUDB2
119		) {
120		$event = EventItemFactory::createEventFromCdbXml(
121		$eventImportedFromUDB2->getCdbXmlNamespaceUri(),
122		$eventImportedFromUDB2->getCdbXml()
123		);
124
125		$this->updateLabelRelationFromCdbItem($event, RelationType::EVENT());
126		}
127
128		/**
129		* @param PlaceImportedFromUDB2 $placeImportedFromUDB2
130		*/
131		public function applyPlaceImportedFromUDB2(
132		PlaceImportedFromUDB2 $placeImportedFromUDB2
133		) {
134		$place = ActorItemFactory::createActorFromCdbXml(
135		$placeImportedFromUDB2->getCdbXmlNamespaceUri(),
136		$placeImportedFromUDB2->getCdbXml()
137		);
138
139		$this->updateLabelRelationFromCdbItem($place, RelationType::PLACE());
140		}
141
142		/**
143		* @param OrganizerImportedFromUDB2 $organizerImportedFromUDB2
144		*/
145		public function applyOrganizerImportedFromUDB2(
146		OrganizerImportedFromUDB2 $organizerImportedFromUDB2
147		) {
148		$organizer = ActorItemFactory::createActorFromCdbXml(
149		$organizerImportedFromUDB2->getCdbXmlNamespaceUri(),
150		$organizerImportedFromUDB2->getCdbXml()
151		);
152
153		$this->updateLabelRelationFromCdbItem($organizer, RelationType::ORGANIZER());
154		}
155
156		/**
157		* @param EventUpdatedFromUDB2 $eventUpdatedFromUDB2
158		*/
159		public function applyEventUpdatedFromUDB2(
160		EventUpdatedFromUDB2 $eventUpdatedFromUDB2
161		) {
162		$event = EventItemFactory::createEventFromCdbXml(
163		$eventUpdatedFromUDB2->getCdbXmlNamespaceUri(),
164		$eventUpdatedFromUDB2->getCdbXml()
165		);
166
167		$this->updateLabelRelationFromCdbItem($event, RelationType::EVENT());
168		}
169
170		/**
171		* @param PlaceUpdatedFromUDB2 $placeUpdatedFromUDB2
172		*/
173		public function applyPlaceUpdatedFromUDB2(
174		PlaceUpdatedFromUDB2 $placeUpdatedFromUDB2
175		) {
176		$place = ActorItemFactory::createActorFromCdbXml(
177		$placeUpdatedFromUDB2->getCdbXmlNamespaceUri(),
178		$placeUpdatedFromUDB2->getCdbXml()
179		);
180
181		$this->updateLabelRelationFromCdbItem($place, RelationType::PLACE());
182		}
183
184		/**
185		* @param OrganizerUpdatedFromUDB2 $organizerUpdatedFromUDB2
186		*/
187		public function applyOrganizerUpdatedFromUDB2(
188		OrganizerUpdatedFromUDB2 $organizerUpdatedFromUDB2
189		) {
190		$organizer = ActorItemFactory::createActorFromCdbXml(
191		$organizerUpdatedFromUDB2->getCdbXmlNamespaceUri(),
192		$organizerUpdatedFromUDB2->getCdbXml()
193		);
194
195		$this->updateLabelRelationFromCdbItem($organizer, RelationType::ORGANIZER());
196		}
197
198		/**
199		* @param \CultureFeed_Cdb_Item_Base $cdbItem
200		* @param RelationType $relationType
201		*/
202		private function updateLabelRelationFromCdbItem(
203		\CultureFeed_Cdb_Item_Base $cdbItem,
204		RelationType $relationType
205		) {
206		$relationId = new StringLiteral($cdbItem->getCdbId());
207
208		// Never delete the UDB3 labels on an update.
209		$this->writeRepository->deleteImportedByRelationId($relationId);
210
211		$keywords = $cdbItem->getKeywords();
212		$labelCollection = LabelCollection::fromStrings($keywords);
213
214		// Calculate the UDB2 imported labels.
215		$udb3Labels = array_map(
216		function (LabelRelation $labelRelation) {
217		return $labelRelation->getLabelName()->toNative();
218		},
219		$this->readRepository->getLabelRelationsForItem($relationId)
220		);
221		$udb2Labels = array_udiff(
222		$labelCollection->asArray(),
223		$udb3Labels,
224		'strcasecmp'
225		);
226
227		// Only save the UDB2 labels, because the UDB3 labels are still present.
228		foreach ($udb2Labels as $label) {
229		$this->writeRepository->save(
230		new LabelName((string) $label),
231		$relationType,
232		$relationId,
233		true
234		);
235		}
236		}
237
238		/**
239		* @param LabelEventInterface $labelEvent
240		* @return LabelRelation
241		*/
242		private function createLabelRelation(LabelEventInterface $labelEvent)
243		{
244		$labelRelation = null;
		0 ignored issues – show Unused Code introduced 2016-11-18 13:35 UTC by Report Bug Copy Issue Report `$labelRelation` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
245
246		$labelName = new LabelName((string) $labelEvent->getLabel());
247		$relationType = $this->offerTypeResolver->getRelationType($labelEvent);
248		$relationId = new StringLiteral($labelEvent->getItemId());
249
250		$labelRelation = new LabelRelation(
251		$labelName,
252		$relationType,
253		$relationId,
254		false
255		);
256
257		return $labelRelation;
258		}
259		}
260

cultuurnet / udb3-php

Pull Request — master (#349)

Projector::applyLabelsImported() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like