Completed
Pull Request — master (#135)
by Kristof
09:22 queued 04:33
created
src/SearchAPI2/Filters/DoesNotHaveKeyword.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     public function __construct($keyword)
15 15
     {
16
-        $keyword = (string) $keyword;
16
+        $keyword = (string)$keyword;
17 17
 
18 18
         $this->filterQuery = new FilterQuery(
19 19
             sprintf(
Please login to merge, or discard this patch.
src/Place/Events/PlaceImportedFromUDB2Event.php 1 patch
Indentation   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -1,7 +1,7 @@
 block discarded – undo
1 1
 <?php
2 2
 /**
3
- * @file
4
- */
3
+     * @file
4
+     */
5 5
 
6 6
 namespace CultuurNet\UDB3\Variations;
7 7
 
Please login to merge, or discard this patch.
src/Media/Serialization/MediaObjectSerializer.php 2 patches
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -3,12 +3,9 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Media\Serialization;
4 4
 
5 5
 use CultuurNet\UDB3\Iri\IriGeneratorInterface;
6
-use CultuurNet\UDB3\Media\MediaObject;
7 6
 use CultuurNet\UDB3\Media\Properties\MIMEType;
8
-use Symfony\Component\HttpFoundation\File\MimeType\ExtensionGuesser;
9 7
 use Symfony\Component\Serializer\Exception\UnsupportedException;
10 8
 use Symfony\Component\Serializer\SerializerInterface;
11
-use ValueObjects\Web\Url;
12 9
 
13 10
 class MediaObjectSerializer implements SerializerInterface
14 11
 {
Please login to merge, or discard this patch.
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -36,10 +36,10 @@  discard block
 block discarded – undo
36 36
         $normalizedData = [
37 37
             '@id' => $this->iriGenerator->iri($mediaObject->getMediaObjectId()),
38 38
             '@type' => $this->serializeMimeType($mediaObject->getMimeType()),
39
-            'contentUrl' => (string) $mediaObject->getSourceLocation(),
40
-            'thumbnailUrl' => (string) $mediaObject->getSourceLocation(),
41
-            'description' => (string) $mediaObject->getDescription(),
42
-            'copyrightHolder' => (string) $mediaObject->getCopyrightHolder(),
39
+            'contentUrl' => (string)$mediaObject->getSourceLocation(),
40
+            'thumbnailUrl' => (string)$mediaObject->getSourceLocation(),
41
+            'description' => (string)$mediaObject->getDescription(),
42
+            'copyrightHolder' => (string)$mediaObject->getCopyrightHolder(),
43 43
         ];
44 44
 
45 45
         return $normalizedData;
@@ -47,7 +47,7 @@  discard block
 block discarded – undo
47 47
 
48 48
     public function serializeMimeType(MIMEType $mimeType)
49 49
     {
50
-        $typeParts = explode('/', (string) $mimeType);
50
+        $typeParts = explode('/', (string)$mimeType);
51 51
         $type = array_shift($typeParts);
52 52
 
53 53
         if ($type !== 'image') {
Please login to merge, or discard this patch.
src/Media/MediaManager.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -115,7 +115,7 @@  discard block
 block discarded – undo
115 115
             Url::fromNative($destinationIri)
116 116
         );
117 117
 
118
-        $jobInfo = ['file_id' => (string) $uploadImage->getFileId()];
118
+        $jobInfo = ['file_id' => (string)$uploadImage->getFileId()];
119 119
         $this->logger->info('job_info', $jobInfo);
120 120
     }
121 121
 
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     public function get(UUID $fileId)
126 126
     {
127 127
         try {
128
-            $mediaObject = $this->repository->load((string) $fileId);
128
+            $mediaObject = $this->repository->load((string)$fileId);
129 129
         } catch (AggregateNotFoundException $e) {
130 130
             throw new MediaObjectNotFoundException(
131 131
                 sprintf("Media object with id '%s' not found", $fileId),
Please login to merge, or discard this patch.
src/Media/Image.php 1 patch
Spacing   +5 added lines, -5 removed lines patch added patch discarded remove patch
@@ -109,11 +109,11 @@
 block discarded – undo
109 109
     public function serialize()
110 110
     {
111 111
         return [
112
-            'media_object_id' => (string) $this->getMediaObjectId(),
113
-            'mime_type' => (string) $this->getMimeType(),
114
-            'description' => (string) $this->getDescription(),
115
-            'copyright_holder' => (string) $this->getCopyrightHolder(),
116
-            'source_location' => (string) $this->getSourceLocation()
112
+            'media_object_id' => (string)$this->getMediaObjectId(),
113
+            'mime_type' => (string)$this->getMimeType(),
114
+            'description' => (string)$this->getDescription(),
115
+            'copyright_holder' => (string)$this->getCopyrightHolder(),
116
+            'source_location' => (string)$this->getSourceLocation()
117 117
         ];
118 118
     }
119 119
 }
Please login to merge, or discard this patch.
src/Media/Events/MediaObjectCreated.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -107,7 +107,7 @@
 block discarded – undo
107 107
             'mime_type' => $this->getMimeType()->toNative(),
108 108
             'description' => $this->getDescription()->toNative(),
109 109
             'copyright_holder' => $this->getCopyrightHolder()->toNative(),
110
-            'source_location' => (string) $this->getSourceLocation()
110
+            'source_location' => (string)$this->getSourceLocation()
111 111
         );
112 112
     }
113 113
 
Please login to merge, or discard this patch.
src/Event/EventCommandHandler.php 1 patch
Unused Use Statements   -3 removed lines patch added patch discarded remove patch
@@ -4,7 +4,6 @@  discard block
 block discarded – undo
4 4
 namespace CultuurNet\UDB3\Event;
5 5
 
6 6
 use Broadway\Repository\RepositoryInterface;
7
-use CultuurNet\UDB3\CommandHandling\Udb3CommandHandler;
8 7
 use CultuurNet\UDB3\Event\Commands\AddImage;
9 8
 use CultuurNet\UDB3\Event\Commands\AddLabel;
10 9
 use CultuurNet\UDB3\Event\Commands\DeleteEvent;
@@ -23,9 +22,7 @@  discard block
 block discarded – undo
23 22
 use CultuurNet\UDB3\Event\Commands\UpdateTypicalAgeRange;
24 23
 use CultuurNet\UDB3\Label as Label;
25 24
 use CultuurNet\UDB3\Offer\OfferCommandHandler;
26
-use CultuurNet\UDB3\Search\Results;
27 25
 use CultuurNet\UDB3\Search\SearchServiceInterface;
28
-use Guzzle\Http\Exception\ClientErrorResponseException;
29 26
 use Psr\Log\LoggerAwareInterface;
30 27
 use Psr\Log\LoggerAwareTrait;
31 28
 
Please login to merge, or discard this patch.
src/LocalEntityService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -78,6 +78,9 @@
 block discarded – undo
78 78
         return $document->getRawBody();
79 79
     }
80 80
 
81
+    /**
82
+     * @param string $id
83
+     */
81 84
     public function iri($id)
82 85
     {
83 86
         return $this->iriGenerator->iri($id);
Please login to merge, or discard this patch.
src/Offer/ReadModel/History/OfferHistoryProjector.php 1 patch
Doc Comments   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -125,7 +125,7 @@  discard block
 block discarded – undo
125 125
     }
126 126
 
127 127
     /**
128
-     * @param $dateString
128
+     * @param string $dateString
129 129
      * @return \DateTime
130 130
      */
131 131
     private function dateFromUdb2DateString($dateString)
@@ -351,7 +351,7 @@  discard block
 block discarded – undo
351 351
 
352 352
     /**
353 353
      * @param string $eventId
354
-     * @param Log[]|Log $logs
354
+     * @param Log $logs
355 355
      */
356 356
     protected function writeHistory($eventId, $logs)
357 357
     {
Please login to merge, or discard this patch.