Completed
Pull Request — master (#246)
by Luc
08:25 queued 03:29
created
src/StringFilter/StripLeadingSpaceStringFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
     public function filter($string)
12 12
     {
13 13
         if (!is_string($string)) {
14
-            throw new \InvalidArgumentException('Argument should be string, got ' . gettype($string) . ' instead.');
14
+            throw new \InvalidArgumentException('Argument should be string, got '.gettype($string).' instead.');
15 15
         }
16 16
 
17 17
         return preg_replace("/(\\n)+/", " ", $string);
Please login to merge, or discard this patch.
src/OpeningHours.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     /**
15 15
      * OpeningHours constructor.
16
-     * @param OpeningHour[]|null $openingHours
16
+     * @param OpeningHour[] $openingHours
17 17
      */
18 18
     public function __construct(array $openingHours = null)
19 19
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace CultuurNet\UDB3;
4 4
 
5
-use ValueObjects\DateTime\WeekDay;
6
-
7 5
 class OpeningHours
8 6
 {
9 7
     /**
Please login to merge, or discard this patch.
src/CalendarFactory.php 1 patch
Spacing   +10 added lines, -10 removed lines patch added patch discarded remove patch
@@ -36,14 +36,14 @@  discard block
 block discarded – undo
36 36
         if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
37 37
             /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
38 38
             $period = $cdbCalendar->current();
39
-            $startDateString = $period->getDateFrom() . 'T00:00:00';
39
+            $startDateString = $period->getDateFrom().'T00:00:00';
40 40
         } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
41 41
             /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
42 42
             $timestamp = $cdbCalendar->current();
43 43
             if ($timestamp->getStartTime()) {
44
-                $startDateString = $timestamp->getDate() . 'T' . $timestamp->getStartTime();
44
+                $startDateString = $timestamp->getDate().'T'.$timestamp->getStartTime();
45 45
             } else {
46
-                $startDateString = $timestamp->getDate() . 'T00:00:00';
46
+                $startDateString = $timestamp->getDate().'T00:00:00';
47 47
             }
48 48
         }
49 49
         $startDate = !empty($startDateString) ? DateTimeFactory::dateTimeFromDateString($startDateString) : null;
@@ -56,17 +56,17 @@  discard block
 block discarded – undo
56 56
         if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_PeriodList) {
57 57
             /** @var \CultureFeed_Cdb_Data_Calendar_Period $period */
58 58
             $period = $cdbCalendar->current();
59
-            $endDateString = $period->getDateTo() . 'T00:00:00';
59
+            $endDateString = $period->getDateTo().'T00:00:00';
60 60
         } else if ($cdbCalendar instanceof \CultureFeed_Cdb_Data_Calendar_TimestampList) {
61 61
             $firstTimestamp = $cdbCalendar->current();
62 62
             /** @var \CultureFeed_Cdb_Data_Calendar_Timestamp $timestamp */
63 63
             $cdbCalendarAsArray = iterator_to_array($cdbCalendar);
64 64
             $timestamp = iterator_count($cdbCalendar) > 1 ? end($cdbCalendarAsArray) : $firstTimestamp;
65 65
             if ($timestamp->getEndTime()) {
66
-                $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
66
+                $endDateString = $timestamp->getDate().'T'.$timestamp->getEndTime();
67 67
             } else {
68 68
                 $endTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
69
-                $endDateString = $timestamp->getDate() . 'T' . $endTime;
69
+                $endDateString = $timestamp->getDate().'T'.$endTime;
70 70
             }
71 71
         }
72 72
         $endDate = !empty($endDateString) ? DateTimeFactory::dateTimeFromDateString($endDateString) : null;
@@ -83,13 +83,13 @@  discard block
 block discarded – undo
83 83
                 $cdbCalendar->next();
84 84
 
85 85
                 if ($timestamp->getStartTime()) {
86
-                    $startDateString = $timestamp->getDate() . 'T' . $timestamp->getStartTime();
86
+                    $startDateString = $timestamp->getDate().'T'.$timestamp->getStartTime();
87 87
 
88 88
                     if ($timestamp->getEndTime()) {
89
-                        $endDateString = $timestamp->getDate() . 'T' . $timestamp->getEndTime();
89
+                        $endDateString = $timestamp->getDate().'T'.$timestamp->getEndTime();
90 90
                     } else {
91 91
                         $endTime = $timestamp->getStartTime() ? $timestamp->getStartTime() : '00:00:00';
92
-                        $endDateString = $timestamp->getDate() . 'T' . $endTime;
92
+                        $endDateString = $timestamp->getDate().'T'.$endTime;
93 93
                     }
94 94
                 }
95 95
 
@@ -204,7 +204,7 @@  discard block
 block discarded – undo
204 204
             $openingHour = $mergedOpeningHour->getOpeningHours()[0];
205 205
             $openingHoursAsArray[] = [
206 206
                 'dayOfWeek' => array_map(
207
-                    function (WeekDay $weekDay) {
207
+                    function(WeekDay $weekDay) {
208 208
                         return strtolower($weekDay->toNative());
209 209
                     },
210 210
                     $mergedOpeningHour->getWeekDays()
Please login to merge, or discard this patch.
src/StringFilter/StripSourceStringFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -11,7 +11,7 @@
 block discarded – undo
11 11
     public function filter($string)
12 12
     {
13 13
         if (!is_string($string)) {
14
-            throw new \InvalidArgumentException('Argument should be string, got ' . gettype($string) . ' instead.');
14
+            throw new \InvalidArgumentException('Argument should be string, got '.gettype($string).' instead.');
15 15
         }
16 16
 
17 17
         return preg_replace("/(\\n)+/", " ", $string);
Please login to merge, or discard this patch.