CultuurNet\UDB3\Place\ReadModel\Permission\Doctrine\DBALRepository

Complexity

Total Complexity

5

Size/Duplication

Total Lines	57
Duplicated Lines	56.14 %

Coupling/Cohesion

Components	1
Dependencies	3

Importance

Changes	1
Bugs	0	Features	0

3 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	0	5	1
A	getEditablePlaces()	17	17	2
A	markPlaceEditableByUser()	15	15	2

<?php
/**
 * Created by PhpStorm.
 * User: jonas
 * Date: 27.10.15
 * Time: 14:04
 */

namespace CultuurNet\UDB3\Place\ReadModel\Permission\Doctrine;

use CultuurNet\UDB3\Place\ReadModel\Permission\PermissionQueryInterface;
use Doctrine\DBAL\Connection;
use Doctrine\DBAL\Exception\UniqueConstraintViolationException;
use Doctrine\DBAL\Schema\Schema;
use CultuurNet\UDB3\Place\ReadModel\Permission\PermissionRepositoryInterface;
use ValueObjects\String\String;

class DBALRepository implements PermissionRepositoryInterface, PermissionQueryInterface
{
    /**
     * @var Connection
     */
    protected $connection;

    /**
     * @param String $tableName
     * @param Connection $connection
     */
    public function __construct(String $tableName, Connection $connection)
    {
        $this->tableName = $tableName;

The property tableName does not exist. Did you maybe forget to declare it?

        $this->connection = $connection;
    }

    /**
     * @inheritdoc
     */
    public function getEditablePlaces(String $uitId)

This method seems to be duplicated in your project.

    {
        $q = $this->connection->createQueryBuilder();
        $q->select('place_id')
            ->from($this->tableName->toNative())
            ->where('user_id = :userId')
            ->setParameter(':userId', $uitId->toNative());

The method toNative cannot be called on $uitId (of type string).

        $results = $q->execute();

        $places = array();
        while ($id = $results->fetchColumn(0)) {
            $places[] = new String($id);
        }

        return $places;
    }

    /**
     * @inheritdoc
     */
    public function markPlaceEditableByUser(String $placeId, String $uitId)

This method seems to be duplicated in your project.

    {
        try {
            $this->connection->insert(
                $this->tableName->toNative(),
                [
                    'place_id' => $placeId->toNative(),

The method toNative cannot be called on $placeId (of type string).

                    'user_id' => $uitId->toNative()

The method toNative cannot be called on $uitId (of type string).

                ]
            );
        } catch (UniqueConstraintViolationException $e) {
            // Intentionally catching database exception occurring when the
            // permission record is already in place.
        }
    }
}