PayloadIsInstanceOf::isSatisfiedBy() - Code Metrics - Inspection of "Feature/iii 536" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#143)

by Kristof

created 2016-03-23 10:50 UTC

PayloadIsInstanceOf::isSatisfiedBy() A

↳ Parent: PayloadIsInstanceOf

Complexity

Conditions	3
Paths	2

Size

Total Lines	17
Code Lines	10

Duplication

Lines	0
Ratio	0 %

Metric	Value
dl	0
loc	17
rs	9.4285
cc	3
eloc	10
nc	2
nop	1

<?php
/**
 * @file
 */

namespace CultuurNet\UDB3\EventHandling\DomainMessage;

use Broadway\Domain\DomainMessage;
use Psr\Log\LoggerAwareInterface;
use Psr\Log\LoggerAwareTrait;
use Psr\Log\NullLogger;

class PayloadIsInstanceOf implements SpecificationInterface, LoggerAwareInterface
{
    use LoggerAwareTrait;

    /**
     * @var string
     */
    private $typeName;

    /**
     * @param string $typeName
     */
    public function __construct($typeName)
    {
        if (!is_string($typeName)) {
            throw new \InvalidArgumentException('Value for argument typeName should be a string');
        }
        $this->typeName = $typeName;
        $this->logger = new NullLogger();
    }

    /**
     * @inheritdoc
     */
    public function isSatisfiedBy(DomainMessage $domainMessage)
    {
        $payload = $domainMessage->getPayload();

        $payloadClass = get_class($payload);
        $this->logger->info(
            "expected: {$this->typeName}, actual: {$payloadClass}"
        );

        $satisfied =
            is_a($payload, $this->typeName) ||
            is_subclass_of($payload, $this->typeName);


        $this->logger->info('satisfied: ' . ($satisfied ? 'yes' : 'no'));

        return $satisfied;
    }
}


1			<?php
2			/**
3			* @file
4			*/
5
6			namespace CultuurNet\UDB3\EventHandling\DomainMessage;
7
8			use Broadway\Domain\DomainMessage;
9			use Psr\Log\LoggerAwareInterface;
10			use Psr\Log\LoggerAwareTrait;
11			use Psr\Log\NullLogger;
12
13			class PayloadIsInstanceOf implements SpecificationInterface, LoggerAwareInterface
14			{
15			use LoggerAwareTrait;
16
17			/**
18			* @var string
19			*/
20			private $typeName;
21
22			/**
23			* @param string $typeName
24			*/
25			public function __construct($typeName)
26			{
27			if (!is_string($typeName)) {
28			throw new \InvalidArgumentException('Value for argument typeName should be a string');
29			}
30			$this->typeName = $typeName;
31			$this->logger = new NullLogger();
32			}
33
34			/**
35			* @inheritdoc
36			*/
37			public function isSatisfiedBy(DomainMessage $domainMessage)
38			{
39			$payload = $domainMessage->getPayload();
40
41			$payloadClass = get_class($payload);
42			$this->logger->info(
43			"expected: {$this->typeName}, actual: {$payloadClass}"
44			);
45
46			$satisfied =
47			is_a($payload, $this->typeName) \|\|
48			is_subclass_of($payload, $this->typeName);
			0 ignored issues – show Bug introduced 2016-03-23 10:56 UTC by Report Bug Copy Issue Report Due to PHP Bug #53727, `is_subclass_of` might return inconsistent results on some PHP versions if `$this->typeName` can be an interface. If so, you could instead use `ReflectionClass::implementsInterface`. Loading history...
49
50			$this->logger->info('satisfied: ' . ($satisfied ? 'yes' : 'no'));
51
52			return $satisfied;
53			}
54			}
55

cultuurnet / udb3-php

Pull Request — master (#143)

PayloadIsInstanceOf::isSatisfiedBy() A

Complexity

Size

Duplication

Duplication Side-by-Side

Filter issues like