AbstractLabelsImported - Code Metrics - Inspection of "III-2563 Importer logic for labels." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#349)

by Luc

created 2018-03-28 13:54 UTC

AbstractLabelsImported A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	65
Duplicated Lines	100 %

Coupling/Cohesion

Components	1
Dependencies	4

Importance

Changes

Metric	Value
wmc	6
lcom	1
cbo	4
dl	65
loc	65
c	0
b	0
f	0
rs	10

4 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	7	7	1
A	getLabels()	4	4	1
A	deserialize()	15	15	2
A	serialize()	15	15	2

How to fix Duplicated Code

<?php

namespace CultuurNet\UDB3\Offer\Events;

use CultuurNet\UDB3\LabelsImportedEventInterface;
use CultuurNet\UDB3\Model\ValueObject\Taxonomy\Label\Label;
use CultuurNet\UDB3\Model\ValueObject\Taxonomy\Label\LabelName;
use CultuurNet\UDB3\Model\ValueObject\Taxonomy\Label\Labels;

abstract class AbstractLabelsImported extends AbstractEvent implements LabelsImportedEventInterface

{
    /**
     * @var Labels
     */
    private $labels;

    /**
     * @param string $organizerId
     * @param Labels $labels
     */
    public function __construct(
        $organizerId,
        Labels $labels
    ) {
        parent::__construct($organizerId);
        $this->labels = $labels;
    }

    /**
     * @return Labels
     */
    public function getLabels()
    {
        return $this->labels;
    }

    /**
     * {@inheritdoc}
     */
    public static function deserialize(array $data)
    {
        $labels = new Labels();
        foreach ($data['labels'] as $label) {
            $labels = $labels->with(new Label(
                new LabelName($label['label']),
                $label['visibility']
            ));
        }

        return new static(
            $data['item_id'],
            $labels
        );
    }

    /**
     * {@inheritdoc}
     */
    public function serialize()
    {
        $labels = [];
        foreach ($this->getLabels() as $label) {
            /** @var Label $label */
            $labels[] = [
                'label' => $label->getName()->toString(),
                'visibility' => $label->isVisible(),
            ];
        }

        return parent::serialize() + [
class Author {
    private $name;

    public function __construct($name) {
        $this->name = $name;
    }

    public function getName() {
        return $this->name;
    }
}

abstract class Post {
    public function getAuthor() {
        return new Author('Johannes');
    }
}

class BlogPost extends Post {
    public function getAuthor() {
        return 'Johannes';
    }
}

class ForumPost extends Post { /* ... */ }

function my_function(Post $post) {
    echo strtoupper($post->getAuthor());
}
                'labels' => $labels,
            ];
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Offer\Events;
4
5		use CultuurNet\UDB3\LabelsImportedEventInterface;
6		use CultuurNet\UDB3\Model\ValueObject\Taxonomy\Label\Label;
7		use CultuurNet\UDB3\Model\ValueObject\Taxonomy\Label\LabelName;
8		use CultuurNet\UDB3\Model\ValueObject\Taxonomy\Label\Labels;
9
10	View Code Duplication	abstract class AbstractLabelsImported extends AbstractEvent implements LabelsImportedEventInterface
		0 ignored issues – show Duplication introduced 2018-03-23 14:03 UTC by Report Bug Copy Issue Report This class seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
11		{
12		/**
13		* @var Labels
14		*/
15		private $labels;
16
17		/**
18		* @param string $organizerId
19		* @param Labels $labels
20		*/
21		public function __construct(
22		$organizerId,
23		Labels $labels
24		) {
25		parent::__construct($organizerId);
26		$this->labels = $labels;
27		}
28
29		/**
30		* @return Labels
31		*/
32		public function getLabels()
33		{
34		return $this->labels;
35		}
36
37		/**
38		* {@inheritdoc}
39		*/
40		public static function deserialize(array $data)
41		{
42		$labels = new Labels();
43		foreach ($data['labels'] as $label) {
44		$labels = $labels->with(new Label(
45		new LabelName($label['label']),
46		$label['visibility']
47		));
48		}
49
50		return new static(
51		$data['item_id'],
52		$labels
53		);
54		}
55
56		/**
57		* {@inheritdoc}
58		*/
59		public function serialize()
60		{
61		$labels = [];
62		foreach ($this->getLabels() as $label) {
63		/** @var Label $label */
64		$labels[] = [
65		'label' => $label->getName()->toString(),
66		'visibility' => $label->isVisible(),
67		];
68		}
69
70		return parent::serialize() + [
		0 ignored issues – show Best Practice introduced 2018-03-23 11:46 UTC by Report Bug Copy Issue Report The expression `return parent::serialize...y('labels' => $labels);` seems to be an `array`, but some of its elements' types (`array`) are incompatible with the return type of the parent method `CultuurNet\UDB3\Offer\Ev...bstractEvent::serialize` of type `array<string,string>`. If you return a value from a function or method, it should be a sub-type of the type that is given by the parent type f.e. an interface, or abstract method. This is more formally defined by the Lizkov substitution principle, and guarantees that classes that depend on the parent type can use any instance of a child type interchangably. This principle also belongs to the SOLID principles for object oriented design. Let’s take a look at an example: class Author { private $name; public function __construct($name) { $this->name = $name; } public function getName() { return $this->name; } } abstract class Post { public function getAuthor() { return new Author('Johannes'); } } class BlogPost extends Post { public function getAuthor() { return 'Johannes'; } } class ForumPost extends Post { /* ... */ } function my_function(Post $post) { echo strtoupper($post->getAuthor()); } Our function `my_function` expects a `Post` object, and outputs the author of the post. The base class `Post` returns a simple string and outputting a simple string will work just fine. However, the child class `BlogPost` which is a sub-type of `Post` instead decided to return an `object`, and is therefore violating the SOLID principles. If a `BlogPost` were passed to `my_function`, PHP would not complain, but ultimately fail when executing the `strtoupper` call in its body. Loading history...
71		'labels' => $labels,
72		];
73		}
74		}
75

cultuurnet / udb3-php

Pull Request — master (#349)

AbstractLabelsImported A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

4 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like