CdbXMLItemBaseImporter::importPriceInfo() - Code Metrics - Inspection of "Feature/iii 2454" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#359)

unknown

created 2018-04-11 11:16 UTC

CdbXMLItemBaseImporter::importPriceInfo() D

↳ Parent: CdbXMLItemBaseImporter

Complexity

Conditions	13
Paths	64

Size

Total Lines	116
Code Lines	71

Duplication

Lines	8
Ratio	6.9 %

Importance

Changes

Metric	Value
dl	8
loc	116
rs	4.9922
c	0
b	0
f	0
cc	13
eloc	71
nc	64
nop	2

How to fix Long Method Complexity

<?php

namespace CultuurNet\UDB3\Offer\ReadModel\JSONLD;

use CultureFeed_Cdb_Item_Base;
use CultuurNet\UDB3\Cdb\DateTimeFactory;
use CultuurNet\UDB3\Cdb\PriceDescriptionParser;
use CultuurNet\UDB3\Language;
use CultuurNet\UDB3\Offer\WorkflowStatus;
use CultuurNet\UDB3\PriceInfo\BasePrice;
use CultuurNet\UDB3\PriceInfo\Price;
use CultuurNet\UDB3\PriceInfo\Tariff;
use CultuurNet\UDB3\ReadModel\MultilingualJsonLDProjectorTrait;
use CultuurNet\UDB3\ValueObject\MultilingualString;
use ValueObjects\Money\Currency;
use ValueObjects\StringLiteral\StringLiteral;

class CdbXMLItemBaseImporter
{
    use MultilingualJsonLDProjectorTrait;

    /**
     * @var PriceDescriptionParser
     */
    private $priceDescriptionParser;

    /**
     * @param PriceDescriptionParser $priceDescriptionParser
     */
    public function __construct(PriceDescriptionParser $priceDescriptionParser)
    {
        $this->priceDescriptionParser = $priceDescriptionParser;
    }

    /**
     * @param CultureFeed_Cdb_Item_Base $item
     * @param \stdClass $jsonLD
     */
    public function importPublicationInfo(
        CultureFeed_Cdb_Item_Base $item,
        \stdClass $jsonLD
    ) {
        $jsonLD->creator = $item->getCreatedBy();

        $itemCreationDate = $item->getCreationDate();

        if (!empty($itemCreationDate)) {
            // format using ISO-8601 with time zone designator
            $creationDate = DateTimeFactory::dateTimeFromDateString(
                $itemCreationDate
            );

            $jsonLD->created = $creationDate->format('c');
        }

        $itemLastUpdatedDate = $item->getLastUpdated();

        if (!empty($itemLastUpdatedDate)) {
            $lastUpdatedDate = DateTimeFactory::dateTimeFromDateString(
                $itemLastUpdatedDate
            );

            $jsonLD->modified = $lastUpdatedDate->format('c');
        }

        $jsonLD->publisher = $item->getOwner();
    }

    /**
     * @param CultureFeed_Cdb_Item_Base $item
     * @param \stdClass $jsonLD
     */
    public function importAvailable(
        \CultureFeed_Cdb_Item_Base $item,
        \stdClass $jsonLD
    ) {
        $availableFromString = $item->getAvailableFrom();
        if ($availableFromString) {
            $jsonLD->availableFrom = $this->formatAvailableString(
                $availableFromString
            );
        }

        $availableToString = $item->getAvailableTo();
        if ($availableToString) {
            $jsonLD->availableTo = $this->formatAvailableString(
                $availableToString
            );
        }
    }

    /**
     * @param string $availableString
     * @return string
     */
    private function formatAvailableString($availableString)
    {
        $available = DateTimeFactory::dateTimeFromDateString(
            $availableString
        );

        return $available->format('c');
    }

    /**
     * @param CultureFeed_Cdb_Item_Base $item
     * @param \stdClass $jsonLD
     */
    public function importExternalId(
        \CultureFeed_Cdb_Item_Base $item,
        \stdClass $jsonLD
    ) {
        $externalId = $item->getExternalId();
        if (empty($externalId)) {
            return;
        }

        $externalIdIsCDB = (strpos($externalId, 'CDB:') === 0);

        if (!property_exists($jsonLD, 'sameAs')) {
            $jsonLD->sameAs = [];
        }

        if (!$externalIdIsCDB) {
            if (!in_array($externalId, $jsonLD->sameAs)) {
                array_push($jsonLD->sameAs, $externalId);
            }
        }
    }

    /**
     * @param CultureFeed_Cdb_Item_Base $item
     * @param \stdClass $jsonLD
     */
    public function importWorkflowStatus(
        CultureFeed_Cdb_Item_Base $item,
        \stdClass $jsonLD
    ) {
        $wfStatus = $item->getWfStatus();

        $workflowStatus = $wfStatus ? WorkflowStatus::fromNative($wfStatus) : WorkflowStatus::READY_FOR_VALIDATION();

        $jsonLD->workflowStatus = $workflowStatus->getName();
    }

    /**
     * @param \CultureFeed_Cdb_Data_DetailList $details
     * @param \stdClass $jsonLD
     */
    public function importPriceInfo(
        \CultureFeed_Cdb_Data_DetailList $details,
        $jsonLD
    ) {
        $mainLanguage = $this->getMainLanguage($jsonLD);

        $detailsArray = [];
        foreach ($details as $detail) {
            $detailsArray[] = $detail;
        }
        $details = $detailsArray;

        $mainLanguageDetails = array_filter(
            $details,
            function (\CultureFeed_Cdb_Data_Detail $detail) use ($mainLanguage) {
                return $detail->getLanguage() === $mainLanguage->getCode();
            }
        );

        /* @var \CultureFeed_Cdb_Data_EventDetail $mainLanguageDetail */
        $mainLanguageDetail = reset($mainLanguageDetails);
        if (!$mainLanguageDetail) {
            return;
        }

        $mainLanguagePrice = $mainLanguageDetail->getPrice();

        if (!$mainLanguagePrice) {
            return;
        }

        $basePrice = $mainLanguagePrice->getValue();
        if ($basePrice !== null) {
            $basePrice = floatval($basePrice);
        }

        if (!$basePrice) {
            return;
        }

        $basePrice = new BasePrice(
            Price::fromFloat($basePrice),
            Currency::fromNative('EUR')
        );

        /* @var Tariff[] $tariffs */
        $tariffs = [];
        foreach ($details as $detail) {
            $language = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $price = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}
            $description = null;
$myVar = 'Value';
$higher = false;

if (rand(1, 6) > 3) {
    $higher = true;
} else {
    $higher = false;
}

            $language = $detail->getLanguage();

            $price = $detail->getPrice();
            if (!$price) {
                continue;
            }

            $description = $price->getDescription();
            if (!$description) {
                continue;
            }

            $translatedTariffs = $this->priceDescriptionParser->parse($description);
            if (empty($translatedTariffs)) {
                continue;
            }

            // Skip the base price.
            array_shift($translatedTariffs);

            $tariffIndex = 0;
            foreach ($translatedTariffs as $tariffName => $tariffPrice) {
                if (!isset($tariffs[$tariffIndex])) {
                    $tariff = new Tariff(
                        new MultilingualString(new Language($language), new StringLiteral($tariffName)),
                        Price::fromFloat($tariffPrice),
                        Currency::fromNative('EUR')
                    );
                } else {
                    $tariff = $tariffs[$tariffIndex];
                    $name = $tariff->getName();
                    $name = $name->withTranslation(new Language($language), new StringLiteral($tariffName));
                    $tariff = new Tariff(
                        $name,
                        $tariff->getPrice(),
                        $tariff->getCurrency()
                    );
                }

                $tariffs[$tariffIndex] = $tariff;
                $tariffIndex++;
            }
        }

        $jsonLD->priceInfo = [
            [
                'category' => 'base',
                'name' => [
                    'nl' => 'Basistarief',
                ],
                'price' => $basePrice->getPrice()->toFloat(),
                'priceCurrency' => $basePrice->getCurrency()->getCode()->toNative(),
            ]
        ];

        foreach ($tariffs as $tariff) {

            $jsonLD->priceInfo[] = [
                'category' => 'tariff',
                'name' => $tariff->getName()->serialize(),
                'price' => $tariff->getPrice()->toFloat(),
                'priceCurrency' => $tariff->getCurrency()->getCode()->toNative(),
            ];
        }
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Offer\ReadModel\JSONLD;
4
5		use CultureFeed_Cdb_Item_Base;
6		use CultuurNet\UDB3\Cdb\DateTimeFactory;
7		use CultuurNet\UDB3\Cdb\PriceDescriptionParser;
8		use CultuurNet\UDB3\Language;
9		use CultuurNet\UDB3\Offer\WorkflowStatus;
10		use CultuurNet\UDB3\PriceInfo\BasePrice;
11		use CultuurNet\UDB3\PriceInfo\Price;
12		use CultuurNet\UDB3\PriceInfo\Tariff;
13		use CultuurNet\UDB3\ReadModel\MultilingualJsonLDProjectorTrait;
14		use CultuurNet\UDB3\ValueObject\MultilingualString;
15		use ValueObjects\Money\Currency;
16		use ValueObjects\StringLiteral\StringLiteral;
17
18		class CdbXMLItemBaseImporter
19		{
20		use MultilingualJsonLDProjectorTrait;
21
22		/**
23		* @var PriceDescriptionParser
24		*/
25		private $priceDescriptionParser;
26
27		/**
28		* @param PriceDescriptionParser $priceDescriptionParser
29		*/
30		public function __construct(PriceDescriptionParser $priceDescriptionParser)
31		{
32		$this->priceDescriptionParser = $priceDescriptionParser;
33		}
34
35		/**
36		* @param CultureFeed_Cdb_Item_Base $item
37		* @param \stdClass $jsonLD
38		*/
39		public function importPublicationInfo(
40		CultureFeed_Cdb_Item_Base $item,
41		\stdClass $jsonLD
42		) {
43		$jsonLD->creator = $item->getCreatedBy();
44
45		$itemCreationDate = $item->getCreationDate();
46
47		if (!empty($itemCreationDate)) {
48		// format using ISO-8601 with time zone designator
49		$creationDate = DateTimeFactory::dateTimeFromDateString(
50		$itemCreationDate
51		);
52
53		$jsonLD->created = $creationDate->format('c');
54		}
55
56		$itemLastUpdatedDate = $item->getLastUpdated();
57
58		if (!empty($itemLastUpdatedDate)) {
59		$lastUpdatedDate = DateTimeFactory::dateTimeFromDateString(
60		$itemLastUpdatedDate
61		);
62
63		$jsonLD->modified = $lastUpdatedDate->format('c');
64		}
65
66		$jsonLD->publisher = $item->getOwner();
67		}
68
69		/**
70		* @param CultureFeed_Cdb_Item_Base $item
71		* @param \stdClass $jsonLD
72		*/
73		public function importAvailable(
74		\CultureFeed_Cdb_Item_Base $item,
75		\stdClass $jsonLD
76		) {
77		$availableFromString = $item->getAvailableFrom();
78		if ($availableFromString) {
79		$jsonLD->availableFrom = $this->formatAvailableString(
80		$availableFromString
81		);
82		}
83
84		$availableToString = $item->getAvailableTo();
85		if ($availableToString) {
86		$jsonLD->availableTo = $this->formatAvailableString(
87		$availableToString
88		);
89		}
90		}
91
92		/**
93		* @param string $availableString
94		* @return string
95		*/
96		private function formatAvailableString($availableString)
97		{
98		$available = DateTimeFactory::dateTimeFromDateString(
99		$availableString
100		);
101
102		return $available->format('c');
103		}
104
105		/**
106		* @param CultureFeed_Cdb_Item_Base $item
107		* @param \stdClass $jsonLD
108		*/
109		public function importExternalId(
110		\CultureFeed_Cdb_Item_Base $item,
111		\stdClass $jsonLD
112		) {
113		$externalId = $item->getExternalId();
114		if (empty($externalId)) {
115		return;
116		}
117
118		$externalIdIsCDB = (strpos($externalId, 'CDB:') === 0);
119
120		if (!property_exists($jsonLD, 'sameAs')) {
121		$jsonLD->sameAs = [];
122		}
123
124		if (!$externalIdIsCDB) {
125		if (!in_array($externalId, $jsonLD->sameAs)) {
126		array_push($jsonLD->sameAs, $externalId);
127		}
128		}
129		}
130
131		/**
132		* @param CultureFeed_Cdb_Item_Base $item
133		* @param \stdClass $jsonLD
134		*/
135		public function importWorkflowStatus(
136		CultureFeed_Cdb_Item_Base $item,
137		\stdClass $jsonLD
138		) {
139		$wfStatus = $item->getWfStatus();
140
141		$workflowStatus = $wfStatus ? WorkflowStatus::fromNative($wfStatus) : WorkflowStatus::READY_FOR_VALIDATION();
142
143		$jsonLD->workflowStatus = $workflowStatus->getName();
144		}
145
146		/**
147		* @param \CultureFeed_Cdb_Data_DetailList $details
148		* @param \stdClass $jsonLD
149		*/
150		public function importPriceInfo(
151		\CultureFeed_Cdb_Data_DetailList $details,
152		$jsonLD
153		) {
154		$mainLanguage = $this->getMainLanguage($jsonLD);
155
156		$detailsArray = [];
157		foreach ($details as $detail) {
158		$detailsArray[] = $detail;
159		}
160		$details = $detailsArray;
161
162		$mainLanguageDetails = array_filter(
163		$details,
164		function (\CultureFeed_Cdb_Data_Detail $detail) use ($mainLanguage) {
165		return $detail->getLanguage() === $mainLanguage->getCode();
166		}
167		);
168
169		/* @var \CultureFeed_Cdb_Data_EventDetail $mainLanguageDetail */
170		$mainLanguageDetail = reset($mainLanguageDetails);
171		if (!$mainLanguageDetail) {
172		return;
173		}
174
175		$mainLanguagePrice = $mainLanguageDetail->getPrice();
176
177		if (!$mainLanguagePrice) {
178		return;
179		}
180
181		$basePrice = $mainLanguagePrice->getValue();
182		if ($basePrice !== null) {
183		$basePrice = floatval($basePrice);
184		}
185
186		if (!$basePrice) {
187		return;
188		}
189
190		$basePrice = new BasePrice(
191		Price::fromFloat($basePrice),
192		Currency::fromNative('EUR')
193		);
194
195		/* @var Tariff[] $tariffs */
196		$tariffs = [];
197		foreach ($details as $detail) {
198		$language = null;
		0 ignored issues – show Unused Code introduced 2018-04-11 11:25 UTC by Report Bug Copy Issue Report `$language` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
199		$price = null;
		0 ignored issues – show Unused Code introduced 2018-04-11 11:25 UTC by Report Bug Copy Issue Report `$price` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
200		$description = null;
		0 ignored issues – show Unused Code introduced 2018-04-11 11:25 UTC by Report Bug Copy Issue Report `$description` is not used, you could remove the assignment. This check looks for variable assignements that are either overwritten by other assignments or where the variable is not used subsequently. $myVar = 'Value'; $higher = false; if (rand(1, 6) > 3) { $higher = true; } else { $higher = false; } Both the `$myVar` assignment in line 1 and the `$higher` assignment in line 2 are dead. The first because `$myVar` is never used and the second because `$higher` is always overwritten for every possible time line. Loading history...
201
202		$language = $detail->getLanguage();
203
204		$price = $detail->getPrice();
205		if (!$price) {
206		continue;
207		}
208
209		$description = $price->getDescription();
210		if (!$description) {
211		continue;
212		}
213
214		$translatedTariffs = $this->priceDescriptionParser->parse($description);
215		if (empty($translatedTariffs)) {
216		continue;
217		}
218
219		// Skip the base price.
220		array_shift($translatedTariffs);
221
222		$tariffIndex = 0;
223		foreach ($translatedTariffs as $tariffName => $tariffPrice) {
224		if (!isset($tariffs[$tariffIndex])) {
225		$tariff = new Tariff(
226		new MultilingualString(new Language($language), new StringLiteral($tariffName)),
227		Price::fromFloat($tariffPrice),
228		Currency::fromNative('EUR')
229		);
230		} else {
231		$tariff = $tariffs[$tariffIndex];
232		$name = $tariff->getName();
233		$name = $name->withTranslation(new Language($language), new StringLiteral($tariffName));
234		$tariff = new Tariff(
235		$name,
236		$tariff->getPrice(),
237		$tariff->getCurrency()
238		);
239		}
240
241		$tariffs[$tariffIndex] = $tariff;
242		$tariffIndex++;
243		}
244		}
245
246		$jsonLD->priceInfo = [
247		[
248		'category' => 'base',
249		'name' => [
250		'nl' => 'Basistarief',
251		],
252		'price' => $basePrice->getPrice()->toFloat(),
253		'priceCurrency' => $basePrice->getCurrency()->getCode()->toNative(),
254		]
255		];
256
257	View Code Duplication	foreach ($tariffs as $tariff) {
		0 ignored issues – show Duplication introduced 2018-04-10 15:08 UTC by Report Bug Copy Issue Report This code seems to be duplicated across your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
258		$jsonLD->priceInfo[] = [
259		'category' => 'tariff',
260		'name' => $tariff->getName()->serialize(),
261		'price' => $tariff->getPrice()->toFloat(),
262		'priceCurrency' => $tariff->getCurrency()->getCode()->toNative(),
263		];
264		}
265		}
266		}
267

cultuurnet / udb3-php

Pull Request — master (#359)

CdbXMLItemBaseImporter::importPriceInfo() D

Complexity

Size

Duplication

Importance

How to fix Long Method Complexity

Long Method

Duplication Side-by-Side

Filter issues like