DelegateEventHandlingToSpecificMethodTrait::getHandleMethodName() - Code Metrics - Inspection of "Merge pull request #313 from cultuurnet/feature/II..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Push — master ( d7130a...41d031 )

by Luc

created 2017-06-27 12:54 UTC

getHandleMethodName() B

↳ Parent: DelegateEventHandlingToSpecificMethodTrait

Complexity

Conditions	4
Paths	4

Size

Total Lines	24
Code Lines	13

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	24
rs	8.6845
c	0
b	0
f	0
cc	4
eloc	13
nc	4
nop	1

<?php
/**
 * @file
 */

namespace CultuurNet\UDB3\EventHandling;

use Broadway\Domain\DomainMessage;

trait DelegateEventHandlingToSpecificMethodTrait
{
    /**
     * {@inheritDoc}
     */
    public function handle(DomainMessage $domainMessage)
    {
        $event  = $domainMessage->getPayload();
        $method = $this->getHandleMethodName($event);

        if ($method) {
''   == false // true
''   == null  // true
'ab' == false // false
'ab' == null  // false

// It is often better to use strict comparison
'' === false // false
'' === null  // false
            $this->$method($event, $domainMessage);
        }
    }

    private function getHandleMethodName($event)
    {
        $classParts = explode('\\', get_class($event));
        $methodName = 'apply' . end($classParts);

        if (!method_exists($this, $methodName)) {
            return null;
        }

        try {
            $parameter = new \ReflectionParameter(array($this, $methodName), 0);
        } catch (\ReflectionException $e) {
            // No parameter for the method, so we ignore it.
            return null;
        }

        $expectedClass = $parameter->getClass();

        if ($expectedClass->getName() !== get_class($event)) {

            return null;
        }

        return $methodName;
    }
}


1			<?php
2			/**
3			* @file
4			*/
5
6			namespace CultuurNet\UDB3\EventHandling;
7
8			use Broadway\Domain\DomainMessage;
9
10			trait DelegateEventHandlingToSpecificMethodTrait
11			{
12			/**
13			* {@inheritDoc}
14			*/
15			public function handle(DomainMessage $domainMessage)
16			{
17			$event = $domainMessage->getPayload();
18			$method = $this->getHandleMethodName($event);
19
20			if ($method) {
			0 ignored issues – show Bug Best Practice introduced 2017-06-23 13:34 UTC by Report Bug Copy Issue Report The expression `$method` of type `null\|string` is loosely compared to `true`; this is ambiguous if the string can be empty. You might want to explicitly use `!== null` instead. In PHP, under loose comparison (like `==`, or `!=`, or `switch` conditions), values of different types might be equal. For `string` values, the empty string `''` is a special case, in particular the following results might be unexpected: '' == false // true '' == null // true 'ab' == false // false 'ab' == null // false // It is often better to use strict comparison '' === false // false '' === null // false Loading history...
21			$this->$method($event, $domainMessage);
22			}
23			}
24
25			private function getHandleMethodName($event)
26			{
27			$classParts = explode('\\', get_class($event));
28			$methodName = 'apply' . end($classParts);
29
30			if (!method_exists($this, $methodName)) {
31			return null;
32			}
33
34			try {
35			$parameter = new \ReflectionParameter(array($this, $methodName), 0);
36			} catch (\ReflectionException $e) {
37			// No parameter for the method, so we ignore it.
38			return null;
39			}
40
41			$expectedClass = $parameter->getClass();
42
43			if ($expectedClass->getName() !== get_class($event)) {
			0 ignored issues – show Bug introduced 2017-04-21 12:54 UTC by Report Bug Copy Issue Report Consider using `$expectedClass->name`. There is an issue with `getName()` and APC-enabled PHP versions. Loading history...
44			return null;
45			}
46
47			return $methodName;
48			}
49			}
50

cultuurnet / udb3-php

Push — master ( d7130a...41d031 )

getHandleMethodName() B

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like