Completed
Pull Request — master (#296)
by Luc
05:04
created
src/Organizer/DefaultOrganizerEditingService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -85,7 +85,7 @@
 block discarded – undo
85 85
     public function addLabel($organizerId, Label $label)
86 86
     {
87 87
         $this->labelService->createLabelAggregateIfNew(
88
-            new LabelName((string) $label),
88
+            new LabelName((string)$label),
89 89
             $label->isVisible()
90 90
         );
91 91
 
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/ItemVisibilityProjector.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -85,14 +85,14 @@  discard block
 block discarded – undo
85 85
         foreach ($items as $item) {
86 86
             $offerLd = $item->getBody();
87 87
 
88
-            $addToArray = isset($offerLd->{$addTo}) ? (array) $offerLd->{$addTo} : [];
88
+            $addToArray = isset($offerLd->{$addTo}) ? (array)$offerLd->{$addTo} : [];
89 89
 
90 90
             $addToArray[] = $labelName->toNative();
91 91
             $offerLd->{$addTo} = array_values(array_unique($addToArray));
92 92
 
93 93
             if (isset($offerLd->{$removeFrom})) {
94 94
                 $offerLd->{$removeFrom} = array_values(
95
-                    array_diff((array) $offerLd->{$removeFrom}, [$labelName])
95
+                    array_diff((array)$offerLd->{$removeFrom}, [$labelName])
96 96
                 );
97 97
 
98 98
                 if (count($offerLd->{$removeFrom}) === 0) {
@@ -121,8 +121,8 @@  discard block
 block discarded – undo
121 121
                 }
122 122
             } catch (DocumentGoneException $exception) {
123 123
                 $this->logger->alert(
124
-                    'Can not update visibility of label: "'. $labelRelation->getLabelName() . '"'
125
-                    . ' for the relation with id: "' . $labelRelation->getRelationId() . '"'
124
+                    'Can not update visibility of label: "'.$labelRelation->getLabelName().'"'
125
+                    . ' for the relation with id: "'.$labelRelation->getRelationId().'"'
126 126
                     . ' because the document could not be retrieved.'
127 127
                 );
128 128
             }
Please login to merge, or discard this patch.
src/ContactPoint.php 1 patch
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,9 +67,9 @@
 block discarded – undo
67 67
     public function serialize()
68 68
     {
69 69
         return [
70
-          'phone' => $this->phones,
71
-          'email' => $this->emails,
72
-          'url' => $this->urls,
70
+            'phone' => $this->phones,
71
+            'email' => $this->emails,
72
+            'url' => $this->urls,
73 73
         ];
74 74
     }
75 75
 
Please login to merge, or discard this patch.
src/StringFilter/BreakTagToNewlineStringFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     {
13 13
         if (!is_string($string)) {
14 14
             throw new \InvalidArgumentException(
15
-                'Argument should be string, got ' . gettype($string) . ' instead.'
15
+                'Argument should be string, got '.gettype($string).' instead.'
16 16
             );
17 17
         }
18 18
 
Please login to merge, or discard this patch.
src/Organizer/OrganizerCommandHandler.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -110,7 +110,7 @@
 block discarded – undo
110 110
      */
111 111
     private function createLabel(AbstractLabelCommand $labelCommand)
112 112
     {
113
-        $labelName = new StringLiteral((string) $labelCommand->getLabel());
113
+        $labelName = new StringLiteral((string)$labelCommand->getLabel());
114 114
         $label = $this->labelRepository->getByName($labelName);
115 115
 
116 116
         return new Label(
Please login to merge, or discard this patch.
src/Offer/OfferCommandHandler.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -93,7 +93,7 @@  discard block
 block discarded – undo
93 93
             $matches = [];
94 94
             if (preg_match('/^handle(.+)$/', $method, $matches)) {
95 95
                 $command = $matches[1];
96
-                $classNameMethod = 'get' . $command . 'ClassName';
96
+                $classNameMethod = 'get'.$command.'ClassName';
97 97
 
98 98
                 if (method_exists($this, $classNameMethod)) {
99 99
                     $commandFullClassName = call_user_func(array($this, $classNameMethod));
@@ -245,7 +245,7 @@  discard block
 block discarded – undo
245 245
      */
246 246
     private function createLabel(AbstractLabelCommand $labelCommand)
247 247
     {
248
-        $labelName = new StringLiteral((string) $labelCommand->getLabel());
248
+        $labelName = new StringLiteral((string)$labelCommand->getLabel());
249 249
         $label = $this->labelRepository->getByName($labelName);
250 250
 
251 251
         return new Label(
Please login to merge, or discard this patch.
src/OpeningHours.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -13,7 +13,7 @@
 block discarded – undo
13 13
 
14 14
     /**
15 15
      * OpeningHours constructor.
16
-     * @param OpeningHour[]|null $openingHours
16
+     * @param OpeningHour[] $openingHours
17 17
      */
18 18
     public function __construct(array $openingHours = null)
19 19
     {
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -2,8 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace CultuurNet\UDB3;
4 4
 
5
-use ValueObjects\DateTime\WeekDay;
6
-
7 5
 class OpeningHours
8 6
 {
9 7
     /**
Please login to merge, or discard this patch.
src/LabelImporter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,13 +15,13 @@
 block discarded – undo
15 15
         );
16 16
 
17 17
         $visibleLabels = $labelCollection->filter(
18
-            function (Label $label) {
18
+            function(Label $label) {
19 19
                 return $label->isVisible();
20 20
             }
21 21
         )->toStrings();
22 22
 
23 23
         $hiddenLabels = $labelCollection->filter(
24
-            function (Label $label) {
24
+            function(Label $label) {
25 25
                 return !$label->isVisible();
26 26
             }
27 27
         )->toStrings();
Please login to merge, or discard this patch.
src/Offer/Offer.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -269,7 +269,7 @@  discard block
 block discarded – undo
269 269
     {
270 270
         $equalImages = array_filter(
271 271
             $this->mediaObjects,
272
-            function ($existingMediaObjectId) use ($image) {
272
+            function($existingMediaObjectId) use ($image) {
273 273
                 return $image
274 274
                     ->getMediaObjectId()
275 275
                     ->sameValueAs($existingMediaObjectId);
@@ -444,7 +444,7 @@  discard block
 block discarded – undo
444 444
             if ($this->rejectedReason && $reason->sameValueAs($this->rejectedReason)) {
445 445
                 return true; // nothing left to do if the offer has already been rejected for the same reason
446 446
             } else {
447
-                throw new Exception('The offer has already been rejected for another reason: ' . $this->rejectedReason);
447
+                throw new Exception('The offer has already been rejected for another reason: '.$this->rejectedReason);
448 448
             }
449 449
         }
450 450
 
@@ -586,7 +586,7 @@  discard block
 block discarded – undo
586 586
         $this->mainImageId = $mainImage ? $mainImage->getMediaObjectId() : null;
587 587
 
588 588
         $this->mediaObjects = array_map(
589
-            function (Image $image) {
589
+            function(Image $image) {
590 590
                 return $image->getMediaObjectId();
591 591
             },
592 592
             $imagesEvent->getImages()->toArray()
Please login to merge, or discard this patch.