OpeningHour::deserialize() - Code Metrics - Inspection of "III-2074 Add value object OpeningHour." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#296)

by Luc

created 2017-04-26 07:25 UTC

OpeningHour::deserialize() A

↳ Parent: OpeningHour

Complexity

Conditions	1
Paths	1

Size

Total Lines	19
Code Lines	11

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	19
rs	9.4285
c	0
b	0
f	0
cc	1
eloc	11
nc	1
nop	1

<?php

namespace CultuurNet\UDB3\Calendar;

use Broadway\Serializer\SerializableInterface;
use ValueObjects\DateTime\Time;
use ValueObjects\DateTime\WeekDay;

class OpeningHour implements SerializableInterface
{
    const FORMAT = 'H:i:s';

    /**
     * @var Time
     */
    private $opens;

    /**
     * @var Time
     */
    private $closes;

    /**
     * @var WeekDay[]
     */
    private $weekDays;

    /**
     * OpeningHour constructor.
     * @param Time $opens
     * @param Time $closes
     * @param WeekDay[] $weekDays
     */
    public function __construct(
        Time $opens,
        Time $closes,
        WeekDay ...$weekDays
    ) {
        $this->weekDays = $weekDays;

        $this->opens = $opens;
        $this->closes = $closes;
    }

    /**
     * @return Time
     */
    public function getOpens()
    {
        return $this->opens;
    }

    /**
     * @return Time
     */
    public function getCloses()
    {
        return $this->closes;
    }

    /**
     * @return WeekDay[]
     */
    public function getWeekDays()
    {
        return $this->weekDays;
    }

    /**
     * @inheritdoc
     */
    public static function deserialize(array $data)
    {
        $weekDays = array_map(
            function ($dayOfWeek) {
                return WeekDay::fromNative($dayOfWeek);
            },
            $data['dayOfWeek']
        );

        return new static(
            Time::fromNativeDateTime(
                \DateTime::createFromFormat(self::FORMAT, $data['opens'])

            ),
            Time::fromNativeDateTime(
                \DateTime::createFromFormat(self::FORMAT, $data['closes'])

            ),
            ...$weekDays
        );
    }

    /**
     * @inheritdoc
     */
    public function serialize()
    {
        $serializedWeekDays = array_map(
            function (WeekDay $weekDay) {
                return $weekDay->getValue();
            },
            $this->weekDays
        ) ;

        return [
            'opens' => $this->opens->toNativeDateTime()->format(self::FORMAT),
            'closes' => $this->closes->toNativeDateTime()->format(self::FORMAT),
            'dayOfWeek' => $serializedWeekDays
        ];
    }
}


1			<?php
2
3			namespace CultuurNet\UDB3\Calendar;
4
5			use Broadway\Serializer\SerializableInterface;
6			use ValueObjects\DateTime\Time;
7			use ValueObjects\DateTime\WeekDay;
8
9			class OpeningHour implements SerializableInterface
10			{
11			const FORMAT = 'H:i:s';
12
13			/**
14			* @var Time
15			*/
16			private $opens;
17
18			/**
19			* @var Time
20			*/
21			private $closes;
22
23			/**
24			* @var WeekDay[]
25			*/
26			private $weekDays;
27
28			/**
29			* OpeningHour constructor.
30			* @param Time $opens
31			* @param Time $closes
32			* @param WeekDay[] $weekDays
33			*/
34			public function __construct(
35			Time $opens,
36			Time $closes,
37			WeekDay ...$weekDays
38			) {
39			$this->weekDays = $weekDays;
			0 ignored issues – show Documentation Bug introduced 2017-04-25 18:43 UTC by Report Bug Copy Issue Report It seems like `$weekDays` of type `array<integer,array<inte...cts\DateTime\WeekDay>>>` is incompatible with the declared type `array<integer,object<Val...ects\DateTime\WeekDay>>` of property `$weekDays`. Our type inference engine has found an assignment to a property that is incompatible with the declared type of that property. Either this assignment is in error or the assigned type should be added to the documentation/type hint for that property.. Loading history...
40			$this->opens = $opens;
41			$this->closes = $closes;
42			}
43
44			/**
45			* @return Time
46			*/
47			public function getOpens()
48			{
49			return $this->opens;
50			}
51
52			/**
53			* @return Time
54			*/
55			public function getCloses()
56			{
57			return $this->closes;
58			}
59
60			/**
61			* @return WeekDay[]
62			*/
63			public function getWeekDays()
64			{
65			return $this->weekDays;
66			}
67
68			/**
69			* @inheritdoc
70			*/
71			public static function deserialize(array $data)
72			{
73			$weekDays = array_map(
74			function ($dayOfWeek) {
75			return WeekDay::fromNative($dayOfWeek);
76			},
77			$data['dayOfWeek']
78			);
79
80			return new static(
81			Time::fromNativeDateTime(
82			\DateTime::createFromFormat(self::FORMAT, $data['opens'])
			0 ignored issues – show Security Bug introduced 2017-04-25 18:43 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFor...FORMAT, $data['opens'])` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `ValueObjects\DateTime\Time::fromNativeDateTime()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
83			),
84			Time::fromNativeDateTime(
85			\DateTime::createFromFormat(self::FORMAT, $data['closes'])
			0 ignored issues – show Security Bug introduced 2017-04-25 18:43 UTC by Report Bug Copy Issue Report It seems like `\DateTime::createFromFor...ORMAT, $data['closes'])` targeting `DateTime::createFromFormat()` can also be of type `false`; however, `ValueObjects\DateTime\Time::fromNativeDateTime()` does only seem to accept `object<DateTime>`, did you maybe forget to handle an error condition? Loading history...
86			),
87			...$weekDays
88			);
89			}
90
91			/**
92			* @inheritdoc
93			*/
94			public function serialize()
95			{
96			$serializedWeekDays = array_map(
97			function (WeekDay $weekDay) {
98			return $weekDay->getValue();
99			},
100			$this->weekDays
101			) ;
102
103			return [
104			'opens' => $this->opens->toNativeDateTime()->format(self::FORMAT),
105			'closes' => $this->closes->toNativeDateTime()->format(self::FORMAT),
106			'dayOfWeek' => $serializedWeekDays
107			];
108			}
109			}
110

cultuurnet / udb3-php

Pull Request — master (#296)

OpeningHour::deserialize() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like