SchemaConfigurator::configure() - Code Metrics - Inspection of "III-2290 Store saved searches in UDB3 instead of U..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#392)

by Luc

created 2018-10-23 11:30 UTC

SchemaConfigurator::configure() A

↳ Parent: SchemaConfigurator

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	10
Ratio	100 %

Importance

Changes

Metric	Value
dl	10
loc	10
rs	9.9332
c	0
b	0
f	0
cc	2
nc	2
nop	1

<?php

namespace CultuurNet\UDB3\SavedSearches\Doctrine;

use CultuurNet\UDB3\Doctrine\DBAL\SchemaConfiguratorInterface;
use Doctrine\DBAL\Schema\AbstractSchemaManager;
use Doctrine\DBAL\Schema\Schema;
use Doctrine\DBAL\Schema\Table;
use Doctrine\DBAL\Types\Type;
use ValueObjects\StringLiteral\StringLiteral;

class SchemaConfigurator implements SchemaConfiguratorInterface
{
    const ID = 'id';
    const USER = 'user_id';
    const NAME = 'name';
    const QUERY = 'query';

    /**
     * @var StringLiteral
     */
    private $tableName;

    /**
     * SchemaConfigurator constructor.
     * @param StringLiteral $tableName
     */
    public function __construct(StringLiteral $tableName)
    {
        $this->tableName = $tableName;
    }

    /**
     * @inheritdoc
     */
    public function configure(AbstractSchemaManager $schemaManager)

    {
        $schema = $schemaManager->createSchema();

        if (!$schema->hasTable($this->tableName->toNative())) {
            $table = $this->createTable($schema, $this->tableName);

            $schemaManager->createTable($table);
        }
    }

    /**
     * @param Schema $schema
     * @param StringLiteral $tableName
     * @return Table
     */
    private function createTable(Schema $schema, StringLiteral $tableName)
    {
        $table = $schema->createTable($tableName->toNative());

        $table->addColumn(self::ID, Type::GUID)
            ->setLength(36)
            ->setNotnull(true);

        $table->addColumn(self::USER, Type::GUID)
            ->setLength(36)
            ->setNotnull(true);

        $table->addColumn(self::NAME, Type::STRING)
            ->setLength(255)
            ->setNotnull(true);

        $table->addColumn(self::QUERY, Type::TEXT)
            ->setNotnull(true);

        $table->addIndex([self::ID]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);
        $table->addIndex([self::USER]);
function acceptsInteger($int) { }

$x = '123'; // string "123"

// Instead of
acceptsInteger($x);

// we recommend to use
acceptsInteger((integer) $x);

        return $table;
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\SavedSearches\Doctrine;
4
5		use CultuurNet\UDB3\Doctrine\DBAL\SchemaConfiguratorInterface;
6		use Doctrine\DBAL\Schema\AbstractSchemaManager;
7		use Doctrine\DBAL\Schema\Schema;
8		use Doctrine\DBAL\Schema\Table;
9		use Doctrine\DBAL\Types\Type;
10		use ValueObjects\StringLiteral\StringLiteral;
11
12		class SchemaConfigurator implements SchemaConfiguratorInterface
13		{
14		const ID = 'id';
15		const USER = 'user_id';
16		const NAME = 'name';
17		const QUERY = 'query';
18
19		/**
20		* @var StringLiteral
21		*/
22		private $tableName;
23
24		/**
25		* SchemaConfigurator constructor.
26		* @param StringLiteral $tableName
27		*/
28		public function __construct(StringLiteral $tableName)
29		{
30		$this->tableName = $tableName;
31		}
32
33		/**
34		* @inheritdoc
35		*/
36	View Code Duplication	public function configure(AbstractSchemaManager $schemaManager)
		0 ignored issues – show Duplication introduced 2018-10-23 11:45 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
37		{
38		$schema = $schemaManager->createSchema();
39
40		if (!$schema->hasTable($this->tableName->toNative())) {
41		$table = $this->createTable($schema, $this->tableName);
42
43		$schemaManager->createTable($table);
44		}
45		}
46
47		/**
48		* @param Schema $schema
49		* @param StringLiteral $tableName
50		* @return Table
51		*/
52		private function createTable(Schema $schema, StringLiteral $tableName)
53		{
54		$table = $schema->createTable($tableName->toNative());
55
56		$table->addColumn(self::ID, Type::GUID)
57		->setLength(36)
58		->setNotnull(true);
59
60		$table->addColumn(self::USER, Type::GUID)
61		->setLength(36)
62		->setNotnull(true);
63
64		$table->addColumn(self::NAME, Type::STRING)
65		->setLength(255)
66		->setNotnull(true);
67
68		$table->addColumn(self::QUERY, Type::TEXT)
69		->setNotnull(true);
70
71		$table->addIndex([self::ID]);
		0 ignored issues – show Documentation introduced 2018-10-23 11:45 UTC by Report Bug Copy Issue Report `array(self::ID)` is of type `array<integer,string,{"0":"string"}>`, but the function expects a `array<integer,array<integer,*>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
72		$table->addIndex([self::USER]);
		0 ignored issues – show Documentation introduced 2018-10-23 11:45 UTC by Report Bug Copy Issue Report `array(self::USER)` is of type `array<integer,string,{"0":"string"}>`, but the function expects a `array<integer,array<integer,*>>`. It seems like the type of the argument is not accepted by the function/method which you are calling. In some cases, in particular if PHP’s automatic type-juggling kicks in this might be fine. In other cases, however this might be a bug. We suggest to add an explicit type cast like in the following example: function acceptsInteger($int) { } $x = '123'; // string "123" // Instead of acceptsInteger($x); // we recommend to use acceptsInteger((integer) $x); Loading history...
73
74		return $table;
75		}
76		}
77

cultuurnet / udb3-php

Pull Request — master (#392)

SchemaConfigurator::configure() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like