UploadImage - Code Metrics - Inspection of "III-608: Event sourced Media Object" - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#105)

by Kristof

created 2015-12-18 11:34 UTC

UploadImage A

↳ Parent: Project

Complexity

Total Complexity

Size/Duplication

Total Lines	72
Duplicated Lines	15.28 %

Coupling/Cohesion

Components	0
Dependencies	0

Importance

Changes	2
Bugs	0	Features	0

Metric	Value
wmc	5
c	2
b	0
f	0
lcom	0
cbo	0
dl	11
loc	72
rs	10

5 Methods

Rating	Name	Duplication	Size	Complexity
A	__construct()	11	11	1
A	getFileId()	0	4	1
A	getDescription()	0	4	1
A	getCopyrightHolder()	0	4	1
A	getMimeType()	0	4	1

How to fix Duplicated Code

<?php

namespace CultuurNet\UDB3\Media\Commands;

use CultuurNet\UDB3\Media\Properties\MIMEType;
use ValueObjects\Identity\UUID;
use ValueObjects\String\String;

class UploadImage
{
    /**
     * @var UUID
     */
    protected $fileId;

    /**
     * @var String
     */
    protected $description;

    /**
     * @var String
     */
    protected $copyrightHolder;

    /**
     * @var MIMEType
     */
    protected $mimeType;

    /**
     * @param UUID $fileId
     * @param MIMEType $mimeType
     * @param String $description
     * @param String $copyrightHolder
     */
    public function __construct(

        UUID $fileId,
        MIMEType $mimeType,
        String $description,
        String $copyrightHolder
    ) {
        $this->fileId = $fileId;
        $this->description = $description;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->copyrightHolder = $copyrightHolder;
class Id
{
    public $id;

    public function __construct($id)
    {
        $this->id = $id;
    }

}

class Account
{
    /** @var  Id $id */
    public $id;
}

$account_id = false;

if (starsAreRight()) {
    $account_id = new Id(42);
}

$account = new Account();
if ($account instanceof Id)
{
    $account->id = $account_id;
}
        $this->mimeType = $mimeType;
    }

    /**
     * @return UUID
     */
    public function getFileId()
    {
        return $this->fileId;
    }

    /**
     * @return String
     */
    public function getDescription()
    {
        return $this->description;
    }

    /**
     * @return String
     */
    public function getCopyrightHolder()
    {
        return $this->copyrightHolder;
    }

    /**
     * @return MIMEType
     */
    public function getMimeType()
    {
        return $this->mimeType;
    }
}


1		<?php
2
3		namespace CultuurNet\UDB3\Media\Commands;
4
5		use CultuurNet\UDB3\Media\Properties\MIMEType;
6		use ValueObjects\Identity\UUID;
7		use ValueObjects\String\String;
8
9		class UploadImage
10		{
11		/**
12		* @var UUID
13		*/
14		protected $fileId;
15
16		/**
17		* @var String
18		*/
19		protected $description;
20
21		/**
22		* @var String
23		*/
24		protected $copyrightHolder;
25
26		/**
27		* @var MIMEType
28		*/
29		protected $mimeType;
30
31		/**
32		* @param UUID $fileId
33		* @param MIMEType $mimeType
34		* @param String $description
35		* @param String $copyrightHolder
36		*/
37	View Code Duplication	public function __construct(
		0 ignored issues – show Duplication introduced 2015-12-18 10:07 UTC by Report Bug Copy Issue Report This method seems to be duplicated in your project. Duplicated code is one of the most pungent code smells. If you need to duplicate the same code in three or more different places, we strongly encourage you to look into extracting the code into a single class or operation. You can also find more detailed suggestions in the “Code” section of your repository. Loading history...
38		UUID $fileId,
39		MIMEType $mimeType,
40		String $description,
41		String $copyrightHolder
42		) {
43		$this->fileId = $fileId;
44		$this->description = $description;
		0 ignored issues – show Documentation Bug introduced 2015-12-18 10:53 UTC by Report Bug Copy Issue Report It seems like `$description` can also be of type `string`. However, the property `$description` is declared as type `object<ValueObjects\String\String>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
45		$this->copyrightHolder = $copyrightHolder;
		0 ignored issues – show Documentation Bug introduced 2015-12-18 10:53 UTC by Report Bug Copy Issue Report It seems like `$copyrightHolder` can also be of type `string`. However, the property `$copyrightHolder` is declared as type `object<ValueObjects\String\String>`. Maybe add an additional type check? Our type inference engine has found a suspicous assignment of a value to a property. This check raises an issue when a value that can be of a mixed type is assigned to a property that is type hinted more strictly. For example, imagine you have a variable `$accountId` that can either hold an Id object or false (if there is no account id yet). Your code now assigns that value to the `id` property of an instance of the `Account` class. This class holds a proper account, so the id value must no longer be false. Either this assignment is in error or a type check should be added for that assignment. class Id { public $id; public function __construct($id) { $this->id = $id; } } class Account { /** @var Id $id */ public $id; } $account_id = false; if (starsAreRight()) { $account_id = new Id(42); } $account = new Account(); if ($account instanceof Id) { $account->id = $account_id; } Loading history...
46		$this->mimeType = $mimeType;
47		}
48
49		/**
50		* @return UUID
51		*/
52		public function getFileId()
53		{
54		return $this->fileId;
55		}
56
57		/**
58		* @return String
59		*/
60		public function getDescription()
61		{
62		return $this->description;
63		}
64
65		/**
66		* @return String
67		*/
68		public function getCopyrightHolder()
69		{
70		return $this->copyrightHolder;
71		}
72
73		/**
74		* @return MIMEType
75		*/
76		public function getMimeType()
77		{
78		return $this->mimeType;
79		}
80		}
81

cultuurnet / udb3-php

Pull Request — master (#105)

UploadImage A

Complexity

Size/Duplication

Coupling/Cohesion

Importance

5 Methods

How to fix Duplicated Code

Duplicated Code

Duplication Side-by-Side

Filter issues like