Completed
Pull Request — master (#397)
by Kristof
03:59
created
src/LocalEntityService.php 1 patch
Doc Comments   +3 added lines patch added patch discarded remove patch
@@ -78,6 +78,9 @@
 block discarded – undo
78 78
         return $document->getRawBody();
79 79
     }
80 80
 
81
+    /**
82
+     * @param string $id
83
+     */
81 84
     public function iri($id)
82 85
     {
83 86
         return $this->iriGenerator->iri($id);
Please login to merge, or discard this patch.
src/Offer/ReadModel/JSONLD/OfferUpdate.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -23,7 +23,7 @@  discard block
 block discarded – undo
23 23
      */
24 24
     public static function calendar(Calendar $calendar)
25 25
     {
26
-        $offerCalenderUpdate = function ($body) use ($calendar) {
26
+        $offerCalenderUpdate = function($body) use ($calendar) {
27 27
             // Purge any existing calendar data
28 28
             unset(
29 29
                 $body->calendarType,
@@ -33,8 +33,8 @@  discard block
 block discarded – undo
33 33
                 $body->openingHours
34 34
             );
35 35
 
36
-            return (object) array_merge(
37
-                (array) $body,
36
+            return (object)array_merge(
37
+                (array)$body,
38 38
                 $calendar->toJsonLd()
39 39
             );
40 40
         };
Please login to merge, or discard this patch.
src/Offer/Events/Image/AbstractImageEvent.php 1 patch
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -48,7 +48,7 @@
 block discarded – undo
48 48
 
49 49
     /**
50 50
      * @param array $data
51
-     * @return mixed The object instance
51
+     * @return AbstractImageEvent The object instance
52 52
      */
53 53
     public static function deserialize(array $data)
54 54
     {
Please login to merge, or discard this patch.
src/Variations/Command/CreateOfferVariationJSONDeserializer.php 3 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
     }
71 71
 
72 72
     /**
73
-     * @param mixed $json
73
+     * @param stdClass $json
74 74
      *
75 75
      * @throws ValidationException
76 76
      */
Please login to merge, or discard this patch.
Unused Use Statements   -2 removed lines patch added patch discarded remove patch
@@ -3,8 +3,6 @@
 block discarded – undo
3 3
 namespace CultuurNet\UDB3\Variations\Command;
4 4
 
5 5
 use CultuurNet\Deserializer\JSONDeserializer;
6
-use CultuurNet\UDB3\Offer\IriOfferIdentifierFactory;
7
-use CultuurNet\UDB3\Offer\IriOfferIdentifierFactoryInterface;
8 6
 use CultuurNet\UDB3\Variations\Model\Properties\Description;
9 7
 use CultuurNet\UDB3\Variations\Model\Properties\OwnerId;
10 8
 use CultuurNet\UDB3\Variations\Model\Properties\Purpose;
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
     private function getErrorMessages($validationErrors)
121 121
     {
122 122
         $errorMessages = array_map(
123
-            function ($error) {
123
+            function($error) {
124 124
                 return $error['message'];
125 125
             },
126 126
             $validationErrors
Please login to merge, or discard this patch.
src/Variations/Command/EditDescriptionJSONDeserializer.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@
 block discarded – undo
70 70
     }
71 71
 
72 72
     /**
73
-     * @param mixed $json
73
+     * @param stdClass $json
74 74
      *
75 75
      * @throws ValidationException
76 76
      */
Please login to merge, or discard this patch.
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -120,7 +120,7 @@
 block discarded – undo
120 120
     private function getErrorMessages($validationErrors)
121 121
     {
122 122
         $errorMessages = array_map(
123
-            function ($error) {
123
+            function($error) {
124 124
                 return $error['message'];
125 125
             },
126 126
             $validationErrors
Please login to merge, or discard this patch.
src/Variations/Model/OfferVariation.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     private function guardNotDeleted()
123 123
     {
124 124
         if ($this->isDeleted()) {
125
-            throw new AggregateDeletedException((string) $this->id);
125
+            throw new AggregateDeletedException((string)$this->id);
126 126
         }
127 127
     }
128 128
 
@@ -148,7 +148,7 @@  discard block
 block discarded – undo
148 148
      */
149 149
     public function getAggregateRootId()
150 150
     {
151
-        return (string) $this->id;
151
+        return (string)$this->id;
152 152
     }
153 153
 
154 154
     /**
Please login to merge, or discard this patch.
src/Variations/Model/Events/OfferVariationEvent.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -37,7 +37,7 @@
 block discarded – undo
37 37
     public function serialize()
38 38
     {
39 39
         return array(
40
-            'id' => (string) $this->getId(),
40
+            'id' => (string)$this->getId(),
41 41
         );
42 42
     }
43 43
 
Please login to merge, or discard this patch.
src/Variations/Model/Events/OfferVariationCreated.php 1 patch
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -94,10 +94,10 @@
 block discarded – undo
94 94
     public function serialize()
95 95
     {
96 96
         return parent::serialize() + array(
97
-            'origin_url' => (string) $this->getOriginUrl(),
98
-            'owner_id' => (string) $this->getOwnerId(),
99
-            'purpose' => (string) $this->getPurpose(),
100
-            'description' => (string) $this->getDescription(),
97
+            'origin_url' => (string)$this->getOriginUrl(),
98
+            'owner_id' => (string)$this->getOwnerId(),
99
+            'purpose' => (string)$this->getPurpose(),
100
+            'description' => (string)$this->getDescription(),
101 101
         );
102 102
     }
103 103
 
Please login to merge, or discard this patch.
src/Variations/ReadModel/Search/Doctrine/DBALRepository.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -49,11 +49,11 @@
 block discarded – undo
49 49
         $this->connection->insert(
50 50
             $this->connection->quoteIdentifier($this->tableName),
51 51
             [
52
-                'id' => (string) $variationId,
53
-                'owner' => (string) $ownerId,
54
-                'purpose' => (string) $purpose,
52
+                'id' => (string)$variationId,
53
+                'owner' => (string)$ownerId,
54
+                'purpose' => (string)$purpose,
55 55
                 'inserted' => time(),
56
-                'origin_url' => (string) $eventUrl,
56
+                'origin_url' => (string)$eventUrl,
57 57
             ]
58 58
         );
59 59
 
Please login to merge, or discard this patch.
Unused Use Statements   -1 removed lines patch added patch discarded remove patch
@@ -2,7 +2,6 @@
 block discarded – undo
2 2
 
3 3
 namespace CultuurNet\UDB3\Variations\ReadModel\Search\Doctrine;
4 4
 
5
-use CultuurNet\UDB3\Offer\OfferType;
6 5
 use CultuurNet\UDB3\Variations\Model\Properties\Id;
7 6
 use CultuurNet\UDB3\Variations\Model\Properties\OwnerId;
8 7
 use CultuurNet\UDB3\Variations\Model\Properties\Purpose;
Please login to merge, or discard this patch.