SearchQueryFactory::createQueryString() - Code Metrics - Inspection of "III-2789 Permission checks with dynamic sapi versi..." - cultuurnet/udb3-php - Measure and Improve Code Quality continuously with Scrutinizer

Completed

Pull Request — master (#397)

by Kristof

created 2019-02-14 10:21 UTC

SearchQueryFactory::createQueryString() A

↳ Parent: SearchQueryFactory

Complexity

Conditions	2
Paths	2

Size

Total Lines

Duplication

Lines	0
Ratio	0 %

Importance

Changes

Metric	Value
dl	0
loc	15
rs	9.7666
c	0
b	0
f	0
cc	2
nc	2
nop	2

<?php

namespace CultuurNet\UDB3\Offer\Security;

use CultuurNet\Search\Parameter\Query;
use CultuurNet\UDB3\ValueObject\SapiVersion;
use ValueObjects\StringLiteral\StringLiteral;

class SearchQueryFactory implements SearchQueryFactoryInterface
{
    /**
     * @var SapiVersion
     */
    private $sapiVersion;

    /**
     * @param SapiVersion $sapiVersion
     */
    public function __construct(SapiVersion $sapiVersion)
    {
        $this->sapiVersion = $sapiVersion;
    }

    /**
     * @inheritdoc
     */
    public function createFromConstraint(
        StringLiteral $constraint,
        StringLiteral $offerId
    ) {
        return new Query($this->createQueryString($constraint, $offerId));
    }

    /**
     * @inheritdoc
     */
    public function createFromConstraints(
        array $constraints,
        StringLiteral $offerId
    ) {
        $queryString = '';

        foreach ($constraints as $constraint) {
            if (strlen($queryString)) {
                $queryString .= ' OR ';
            }

            $queryString .= $this->createQueryString($constraint, $offerId);
        }

        return new Query($queryString);
    }

    /**
     * @param StringLiteral $constraint
     * @param StringLiteral $offerId
     * @return string
     */
    private function createQueryString(
        StringLiteral $constraint,
        StringLiteral $offerId
    ) {
        $constraintStr = '(' . strtolower($constraint->toNative()) . ')';
        $offerIdStr = $offerId->toNative();

        if ($this->sapiVersion->sameValueAs(SapiVersion::V3())) {
            $id = 'id';
        } else {
            $id = 'cdbid';
        }

        return '(' . $constraintStr . ' AND ' . $id . ':' . $offerIdStr . ')';
    }
}


1			<?php
2
3			namespace CultuurNet\UDB3\Offer\Security;
4
5			use CultuurNet\Search\Parameter\Query;
6			use CultuurNet\UDB3\ValueObject\SapiVersion;
7			use ValueObjects\StringLiteral\StringLiteral;
8
9			class SearchQueryFactory implements SearchQueryFactoryInterface
10			{
11			/**
12			* @var SapiVersion
13			*/
14			private $sapiVersion;
15
16			/**
17			* @param SapiVersion $sapiVersion
18			*/
19			public function __construct(SapiVersion $sapiVersion)
20			{
21			$this->sapiVersion = $sapiVersion;
22			}
23
24			/**
25			* @inheritdoc
26			*/
27			public function createFromConstraint(
28			StringLiteral $constraint,
29			StringLiteral $offerId
30			) {
31			return new Query($this->createQueryString($constraint, $offerId));
32			}
33
34			/**
35			* @inheritdoc
36			*/
37			public function createFromConstraints(
38			array $constraints,
39			StringLiteral $offerId
40			) {
41			$queryString = '';
42
43			foreach ($constraints as $constraint) {
44			if (strlen($queryString)) {
45			$queryString .= ' OR ';
46			}
47
48			$queryString .= $this->createQueryString($constraint, $offerId);
49			}
50
51			return new Query($queryString);
52			}
53
54			/**
55			* @param StringLiteral $constraint
56			* @param StringLiteral $offerId
57			* @return string
58			*/
59			private function createQueryString(
60			StringLiteral $constraint,
61			StringLiteral $offerId
62			) {
63			$constraintStr = '(' . strtolower($constraint->toNative()) . ')';
64			$offerIdStr = $offerId->toNative();
65
66			if ($this->sapiVersion->sameValueAs(SapiVersion::V3())) {
67			$id = 'id';
68			} else {
69			$id = 'cdbid';
70			}
71
72			return '(' . $constraintStr . ' AND ' . $id . ':' . $offerIdStr . ')';
73			}
74			}
75

cultuurnet / udb3-php

Pull Request — master (#397)

SearchQueryFactory::createQueryString() A

Complexity

Size

Duplication

Importance

Duplication Side-by-Side

Filter issues like