Completed
Pull Request — master (#454)
by Jonas
05:25 queued 02:08
created
src/Cdb/ExternalId/ArrayMappingService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -25,7 +25,7 @@
 block discarded – undo
25 25
     public function getCdbId($externalId)
26 26
     {
27 27
         if (isset($this->externalIdMapping[$externalId])) {
28
-            return (string) $this->externalIdMapping[$externalId];
28
+            return (string)$this->externalIdMapping[$externalId];
29 29
         } else {
30 30
             return null;
31 31
         }
Please login to merge, or discard this patch.
src/LabelCollection.php 1 patch
Spacing   +6 added lines, -6 removed lines patch added patch discarded remove patch
@@ -16,7 +16,7 @@  discard block
 block discarded – undo
16 16
     {
17 17
         array_walk(
18 18
             $labels,
19
-            function ($item) {
19
+            function($item) {
20 20
                 if (!$item instanceof Label) {
21 21
                     throw new \InvalidArgumentException(
22 22
                         'Argument $labels should only contain members of type Label'
@@ -51,7 +51,7 @@  discard block
 block discarded – undo
51 51
     {
52 52
         $labels = array_filter(
53 53
             $this->labels,
54
-            function (Label $existingLabel) use ($label) {
54
+            function(Label $existingLabel) use ($label) {
55 55
                 return !$existingLabel->equals($label);
56 56
             }
57 57
         );
@@ -75,7 +75,7 @@  discard block
 block discarded – undo
75 75
     {
76 76
         $equalLabels = array_filter(
77 77
             $this->labels,
78
-            function (Label $existingLabel) use ($label) {
78
+            function(Label $existingLabel) use ($label) {
79 79
                 return $label->equals($existingLabel);
80 80
             }
81 81
         );
@@ -122,7 +122,7 @@  discard block
 block discarded – undo
122 122
     {
123 123
         $intersectLabels = array_filter(
124 124
             $this->labels,
125
-            function ($label) use ($labelCollection) {
125
+            function($label) use ($labelCollection) {
126 126
                 return $labelCollection->contains($label);
127 127
             }
128 128
         );
@@ -155,8 +155,8 @@  discard block
 block discarded – undo
155 155
     public function toStrings()
156 156
     {
157 157
         $labels = array_map(
158
-            function (Label $label) {
159
-                return (string) $label;
158
+            function(Label $label) {
159
+                return (string)$label;
160 160
             },
161 161
             $this->labels
162 162
         );
Please login to merge, or discard this patch.
src/Offer/DefaultOfferEditingService.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -92,7 +92,7 @@
 block discarded – undo
92 92
         $this->guardId($id);
93 93
 
94 94
         $this->labelService->createLabelAggregateIfNew(
95
-            new LabelName((string) $label),
95
+            new LabelName((string)$label),
96 96
             $label->isVisible()
97 97
         );
98 98
 
Please login to merge, or discard this patch.
src/Label/ReadModels/JSON/ItemVisibilityProjector.php 2 patches
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -85,14 +85,14 @@  discard block
 block discarded – undo
85 85
         foreach ($items as $item) {
86 86
             $offerLd = $item->getBody();
87 87
 
88
-            $addToArray = isset($offerLd->{$addTo}) ? (array) $offerLd->{$addTo} : [];
88
+            $addToArray = isset($offerLd->{$addTo}) ? (array)$offerLd->{$addTo} : [];
89 89
 
90 90
             $addToArray[] = $labelName->toNative();
91 91
             $offerLd->{$addTo} = array_values(array_unique($addToArray));
92 92
 
93 93
             if (isset($offerLd->{$removeFrom})) {
94 94
                 $offerLd->{$removeFrom} = array_values(
95
-                    array_diff((array) $offerLd->{$removeFrom}, [$labelName])
95
+                    array_diff((array)$offerLd->{$removeFrom}, [$labelName])
96 96
                 );
97 97
 
98 98
                 if (count($offerLd->{$removeFrom}) === 0) {
@@ -121,8 +121,8 @@  discard block
 block discarded – undo
121 121
                 }
122 122
             } catch (DocumentGoneException $exception) {
123 123
                 $this->logger->alert(
124
-                    'Can not update visibility of label: "'. $labelRelation->getLabelName() . '"'
125
-                    . ' for the relation with id: "' . $labelRelation->getRelationId() . '"'
124
+                    'Can not update visibility of label: "'.$labelRelation->getLabelName().'"'
125
+                    . ' for the relation with id: "'.$labelRelation->getRelationId().'"'
126 126
                     . ' because the document could not be retrieved.'
127 127
                 );
128 128
             }
Please login to merge, or discard this patch.
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -106,7 +106,7 @@
 block discarded – undo
106 106
 
107 107
     /**
108 108
      * @param LabelName $labelName
109
-     * @return \CultuurNet\UDB3\ReadModel\JsonDocument[]|\Generator
109
+     * @return \Generator
110 110
      */
111 111
     private function getRelatedItems(LabelName $labelName)
112 112
     {
Please login to merge, or discard this patch.
src/ContactPoint.php 2 patches
Indentation   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -67,9 +67,9 @@
 block discarded – undo
67 67
     public function serialize()
68 68
     {
69 69
         return [
70
-          'phone' => $this->phones,
71
-          'email' => $this->emails,
72
-          'url' => $this->urls,
70
+            'phone' => $this->phones,
71
+            'email' => $this->emails,
72
+            'url' => $this->urls,
73 73
         ];
74 74
     }
75 75
 
Please login to merge, or discard this patch.
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -112,21 +112,21 @@
 block discarded – undo
112 112
     public static function fromUdb3ModelContactPoint(Udb3ModelContactPoint $contactPoint)
113 113
     {
114 114
         $phones = array_map(
115
-            function (TelephoneNumber $phone) {
115
+            function(TelephoneNumber $phone) {
116 116
                 return $phone->toString();
117 117
             },
118 118
             $contactPoint->getTelephoneNumbers()->toArray()
119 119
         );
120 120
 
121 121
         $emails = array_map(
122
-            function (EmailAddress $emailAddress) {
122
+            function(EmailAddress $emailAddress) {
123 123
                 return $emailAddress->toString();
124 124
             },
125 125
             $contactPoint->getEmailAddresses()->toArray()
126 126
         );
127 127
 
128 128
         $urls = array_map(
129
-            function (Url $url) {
129
+            function(Url $url) {
130 130
                 return $url->toString();
131 131
             },
132 132
             $contactPoint->getUrls()->toArray()
Please login to merge, or discard this patch.
src/StringFilter/BreakTagToNewlineStringFilter.php 1 patch
Spacing   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -12,7 +12,7 @@
 block discarded – undo
12 12
     {
13 13
         if (!is_string($string)) {
14 14
             throw new \InvalidArgumentException(
15
-                'Argument should be string, got ' . gettype($string) . ' instead.'
15
+                'Argument should be string, got '.gettype($string).' instead.'
16 16
             );
17 17
         }
18 18
 
Please login to merge, or discard this patch.
src/LabelImporter.php 1 patch
Spacing   +2 added lines, -2 removed lines patch added patch discarded remove patch
@@ -15,13 +15,13 @@
 block discarded – undo
15 15
         );
16 16
 
17 17
         $visibleLabels = $labelCollection->filter(
18
-            function (Label $label) {
18
+            function(Label $label) {
19 19
                 return $label->isVisible();
20 20
             }
21 21
         )->toStrings();
22 22
 
23 23
         $hiddenLabels = $labelCollection->filter(
24
-            function (Label $label) {
24
+            function(Label $label) {
25 25
                 return !$label->isVisible();
26 26
             }
27 27
         )->toStrings();
Please login to merge, or discard this patch.
src/EventSourcing/DBAL/AggregateAwareDBALEventStore.php 2 patches
Doc Comments   +1 added lines, -1 removed lines patch added patch discarded remove patch
@@ -169,7 +169,7 @@
 block discarded – undo
169 169
     }
170 170
 
171 171
     /**
172
-     * @return mixed
172
+     * @return Table
173 173
      */
174 174
     public function configureTable()
175 175
     {
Please login to merge, or discard this patch.
Spacing   +4 added lines, -4 removed lines patch added patch discarded remove patch
@@ -70,7 +70,7 @@  discard block
 block discarded – undo
70 70
         $this->payloadSerializer  = $payloadSerializer;
71 71
         $this->metadataSerializer = $metadataSerializer;
72 72
         $this->tableName          = $tableName;
73
-        $this->aggregateType      = (string) $aggregateType;
73
+        $this->aggregateType      = (string)$aggregateType;
74 74
     }
75 75
 
76 76
     /**
@@ -105,7 +105,7 @@  discard block
 block discarded – undo
105 105
         $this->guardStream($eventStream);
106 106
 
107 107
         // Make the transaction more robust by using the transactional statement.
108
-        $this->connection->transactional(function (Connection $connection) use ($eventStream) {
108
+        $this->connection->transactional(function(Connection $connection) use ($eventStream) {
109 109
             try {
110 110
                 foreach ($eventStream as $domainMessage) {
111 111
                     $this->insertMessage($connection, $domainMessage);
@@ -123,7 +123,7 @@  discard block
 block discarded – undo
123 123
     private function insertMessage(Connection $connection, DomainMessage $domainMessage)
124 124
     {
125 125
         $data = array(
126
-            'uuid'           => (string) $domainMessage->getId(),
126
+            'uuid'           => (string)$domainMessage->getId(),
127 127
             'playhead'       => $domainMessage->getPlayhead(),
128 128
             'metadata'       => json_encode($this->metadataSerializer->serialize($domainMessage->getMetadata())),
129 129
             'payload'        => json_encode($this->payloadSerializer->serialize($domainMessage->getPayload())),
@@ -228,7 +228,7 @@  discard block
 block discarded – undo
228 228
     {
229 229
         foreach ($eventStream as $domainMessage) {
230 230
             /** @var DomainMessage $domainMessage */
231
-            $id = (string) $domainMessage->getId();
231
+            $id = (string)$domainMessage->getId();
232 232
         }
233 233
     }
234 234
 }
Please login to merge, or discard this patch.
src/Offer/Events/Image/AbstractImagesEvent.php 1 patch
Spacing   +3 added lines, -3 removed lines patch added patch discarded remove patch
@@ -36,9 +36,9 @@  discard block
 block discarded – undo
36 36
      */
37 37
     public function serialize()
38 38
     {
39
-        $serializedData =  parent::serialize() + array(
39
+        $serializedData = parent::serialize() + array(
40 40
             'images' => array_map(
41
-                function (Image $image) {
41
+                function(Image $image) {
42 42
                     return $image->serialize();
43 43
                 },
44 44
                 $this->images->toArray()
@@ -61,7 +61,7 @@  discard block
 block discarded – undo
61 61
     {
62 62
         $images = ImageCollection::fromArray(
63 63
             array_map(
64
-                function ($imageData) {
64
+                function($imageData) {
65 65
                     return Image::deserialize($imageData);
66 66
                 },
67 67
                 $data['images']
Please login to merge, or discard this patch.